Received-SPF: pass (google.com: domain of linux-kernel+bounces-151103-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 15:27:30 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: Tianchen Ding <dtcccc@linux.alibaba.com>
CC: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>, "Peter
 Zijlstra" <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>,
	"Vincent Guittot" <vincent.guittot@linaro.org>, Dietmar Eggemann
	<dietmar.eggemann@arm.com>, Steven Rostedt <rostedt@goodmis.org>, Ben Segall
	<bsegall@google.com>, Mel Gorman <mgorman@suse.de>, "Daniel Bristot de
 Oliveira" <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>,
	"Abel Wu" <wuyun.abel@bytedance.com>
Subject: Re: [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight_entity()
Message-ID: <ZiIc4mU/RcSPI+WV@chenyu5-mobl2>
References: <20240306022133.81008-1-dtcccc@linux.alibaba.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240306022133.81008-1-dtcccc@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6YQkxgJfl07ZXPDEO+a2O6xkU3RWPgTKngBKim2JGa5zB7QPYPly8/GDRI32?=
 =?us-ascii?Q?UflaAsmw5NKjNokzJMKYbkiNCJr16O2JGK5ZK5cm9Ysg72nVfAdfWkePIg+V?=
 =?us-ascii?Q?HIFudNcyOGd/V22TyGDpdh9AFyz49gPe0rMSCF4JN/opai4//26unpaoIbAG?=
 =?us-ascii?Q?16LQKuKgBohKnlJ5zwLej563qko3dLN/DttGnBzEZHtd4ChsZvQCWkFOd8Ku?=
 =?us-ascii?Q?Cg/7rYsUwxyMjha0u5WQW7cNyAogiW9NwcSK3kL6/7Dc4abwhwUJh7vOSDJL?=
 =?us-ascii?Q?hoZH4/nHZlVuaW/TgYNhKCWj2JVHSPMWfPMM3v5b6wEA0PTg3YXg7NumZdWR?=
 =?us-ascii?Q?AjiCM0hQ+7UJH9k1Y6i0fqiZToUnoLOx3aTQQ2C/3vJV+DhKV2BW5DBRElkz?=
 =?us-ascii?Q?uJ79KNMAUdUarbo3QWhCI/9/iUUHuXBDiWXg69Fj4nXKbGdq/pdHw/AmXBUm?=
 =?us-ascii?Q?kLWSAoJx+l3DAvI/ukpTKDLD4fDmTdKKbG5uwtuGjLr71mO0ZI6P3q9oD0AO?=
 =?us-ascii?Q?Hg+uW8MeN4bZgq75fT7777ooXWOFw1ILoiatHk8Of9pawwrTiF2bMr2pN7KG?=
 =?us-ascii?Q?sdFdrZ8NQC+tAKLomAHEyB/ok6GZzHBwOiHNanLWml8T6hSAyFwxBC+hU8vK?=
 =?us-ascii?Q?EgMIJrS3vfzXwuW/vW+AJRQBG/Veb9E6rSd8uvUXxJ1SsB4vmC9LZwq8qnyA?=
 =?us-ascii?Q?Z7zx0LBL+0azjn4TSvjmuwhO1dSo1LsjMyOmpqAD60eIWuqK936uAn5dfk+4?=
 =?us-ascii?Q?PsHg6YbsKRISbCcJFbMsL4ottHQnK461TINbHYp0dxD49qex65zY7CSgyjor?=
 =?us-ascii?Q?ccf1vEVgXeDd3dNzBoHMBXjQL1oF46hVomGVp3EEbA8vN+PBtjiRBAKOsiOl?=
 =?us-ascii?Q?lBJzWRxNM2kYKl7Tuhq/1I1cltORAppyng3/azaNmjxw/GrSVILS0VqRU2s0?=
 =?us-ascii?Q?vxhI5WMRGdNI9Ptd7XNOX11ttVFJyM1fOI/Jr+1vNth+ZsuCf/Ir3Mm+je0b?=
 =?us-ascii?Q?7O9CdmJTrs1btoKeYUXo2s8rMrtSI6ZfhtUMOYSDY1VTEW+mxvQXhdVo36Ou?=
 =?us-ascii?Q?p3KuV+kWW38eU1XUulyjGmHWrUxvPD8mXGfO2KQw5CjaMLGj3Dq4Z4dmYNxB?=
 =?us-ascii?Q?Ei2VGc28iN7gXeqd6FLiHv16oBsxq6O3aTyPRB0lrIeE09NBHdBF9IrVTxsI?=
 =?us-ascii?Q?Cum+qbFAtpmEa5SUQKB9othw3aiINETh5gPTQTF0HnnjVIYO+ZpdDJojpxRS?=
 =?us-ascii?Q?E+tkscIlKvHdMaCiBLq9K1Xeuv2hrsGo3t4LvuZ6HD5ehAHUPF36/DjCtFVB?=
 =?us-ascii?Q?bKgK0evd3bcdRkYEUzRlhwKz6tIqTYY9AF1D2Lz4dYs/0yECwWlFHxZRn7HH?=
 =?us-ascii?Q?3X71tAFSgN+BJDkFghJmrXV9CMkX09xu48M50DJlLP9JN2sL7y0E3hT5n/ev?=
 =?us-ascii?Q?egYbKZvRtiDsmum7AhKG6TlNWxDOWD5tOTr4cUdW0H4VvhjDBm1+I1ILVlK4?=
 =?us-ascii?Q?uhbHhiYaQSfG2XqkWQZig30cmqrtU16+3gpIJ3E77LWO9rChn/Dyj1UIvVYE?=
 =?us-ascii?Q?EflZ9UHjggnO6CobmRVj7l7G7Jd8IRIgIsv9Dhe7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 183b6b11-6766-41bb-78c6-08dc604235ce
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 07:27:46.8802
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: THGkOjkd15R8G3N+XX+YsTlrHk5CWmH8f3NWQAsqOXWgGvWVUubdqdX6Ekc+gBU9os0v/yBubk1olPqKwhb34Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7860
X-OriginatorOrg: intel.com

On 2024-03-06 at 10:21:31 +0800, Tianchen Ding wrote:
> According to the discussion in [1], fix a calculation bug in
> reweight_entity().
> 
> [1] https://lore.kernel.org/all/59585184-d13d-46e0-8d68-42838e97a702@bytedance.com/
> 
> v2:
> Add fixes tag to the 1st patch.
> 
> v1: https://lore.kernel.org/all/20240304030042.2690-1-dtcccc@linux.alibaba.com/
> 
> Tianchen Ding (2):
>   sched/eevdf: Always update V if se->on_rq when reweighting
>   sched/eevdf: Fix miscalculation in reweight_entity() when se is not
>     curr
> 
>  kernel/sched/fair.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> -- 
> 2.39.3
>

Applied this patch set on top of the reweight_entity fix at
https://lore.kernel.org/lkml/ZiEaKOQwiNEglYtS@chenyu5-mobl2/
it has passed 100 cycles of trinity test without any issue.

For the whole serie,

Tested-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu