Message-ID: <47999CF2.9070805@garzik.org>
Date: Fri, 25 Jan 2008 03:25:22 -0500
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Greg Kroah-Hartman <gregkh@suse.de>
CC: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
       Mike Halcrow <mhalcrow@us.ibm.com>,
       Phillip Hellewell <phillip@hellewell.homeip.net>
Subject: Re: [PATCH 076/196] ecryptfs: remove version_str file from sysfs
References: <20080125071127.GA4860@kroah.com> <1201245134-4876-76-git-send-email-gregkh@suse.de>
In-Reply-To: <1201245134-4876-76-git-send-email-gregkh@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 989
Lines: 29

Greg Kroah-Hartman wrote:
> This file violates the one-value-per-file sysfs rule.
> 
> If you all want it added back, please do something like a per-feature
> file to show what is present and what isn't.
> 
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: Mike Halcrow <mhalcrow@us.ibm.com>
> Cc: Phillip Hellewell <phillip@hellewell.homeip.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
>  fs/ecryptfs/main.c |   43 -------------------------------------------
>  1 files changed, 0 insertions(+), 43 deletions(-)

It's not really good policy to rip out ABIs found in release kernels 
like this, even if the motivation is sound.

IMO "don't break ABIs" rule is far more important than a 
one-value-per-file sysfs rule.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/