Received-SPF: pass (google.com: domain of linux-kernel+bounces-151216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 19 Apr 2024 17:05:06 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: "Colberg, Peter" <peter.colberg@intel.com>
Cc: "Xu, Yilun" <yilun.xu@intel.com>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
	"mdf@kernel.org" <mdf@kernel.org>,
	"andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
	"Wu, Hao" <hao.wu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"russ.weight@linux.dev" <russ.weight@linux.dev>,
	"Pagani, Marco" <marpagan@redhat.com>, "Rix, Tom" <trix@redhat.com>,
	"matthew.gerlach@linux.intel.com" <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH RESEND] fpga: dfl: omit unneeded casts of u64 values for
 dev_dbg()
Message-ID: <ZiIzwjggxFmXvau8@yilunxu-OptiPlex-7050>
References: <20240329000429.7493-1-peter.colberg@intel.com>
 <Zgt7fA/Jfks/iKYi@yilunxu-OptiPlex-7050>
 <61cf643fda9b983b8a78b9f66c46290becf4f537.camel@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <61cf643fda9b983b8a78b9f66c46290becf4f537.camel@intel.com>

On Thu, Apr 18, 2024 at 09:30:48PM +0000, Colberg, Peter wrote:
> On Tue, 2024-04-02 at 11:29 +0800, Xu Yilun wrote:
> > On Thu, Mar 28, 2024 at 08:04:29PM -0400, Peter Colberg wrote:
> > > Omit unneeded casts of u64 values to unsigned long long for use with
> > > printk() format specifier %llx. Unlike user space, the kernel defines
> > > u64 as unsigned long long for all architectures; see commit 2a7930bd77fe
> > > ("Documentation/printk-formats.txt: No casts needed for u64/s64").
> > 
> > The change is OK. But I suggest just delete the unnecessary dev_dbg()
> > since now people normally don't want these "Hello, I'm here!" info.
> 
> How would you like me to proceed? Should I remove dev_dbg() in all DFL

I think do for all DFL would be enough. Usually you want something to
follow up and do the related clean up in advance.

Thanks,
Yilun

> modules? There are "Hello, I'm here!" in non-DFL FPGA modules, too.
> 
> $ rg --sort=path -c dev_dbg drivers/fpga/
> drivers/fpga/altera-freeze-bridge.c:7
> drivers/fpga/altera-pr-ip-core.c:1
> drivers/fpga/dfl-afu-dma-region.c:7
> drivers/fpga/dfl-afu-error.c:1
> drivers/fpga/dfl-afu-main.c:8
> drivers/fpga/dfl-fme-error.c:1
> drivers/fpga/dfl-fme-main.c:3
> drivers/fpga/dfl-fme-mgr.c:12
> drivers/fpga/dfl-fme-perf.c:2
> drivers/fpga/dfl-fme-pr.c:1
> drivers/fpga/dfl-fme-region.c:1
> drivers/fpga/dfl-n3000-nios.c:1
> drivers/fpga/dfl-pci.c:3
> drivers/fpga/dfl.c:4
> drivers/fpga/fpga-bridge.c:4
> drivers/fpga/fpga-region.c:3
> drivers/fpga/socfpga-a10.c:2
> drivers/fpga/stratix10-soc.c:4
> 
> Thanks,
> Peter