Received-SPF: pass (google.com: domain of linux-kernel+bounces-151227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <377b0acf906b9bcfbc1053ca07d64f14a6cf9a1e.camel@physik.fu-berlin.de>
Subject: Re: [PATCH -next] dma: Add dev_id parameter description in
 request_dma_bycap
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Yang Li <yang.lee@linux.alibaba.com>, ysato@users.sourceforge.jp, 
	dalias@libc.org
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 19 Apr 2024 11:21:55 +0200
In-Reply-To: <20240419090259.39542-1-yang.lee@linux.alibaba.com>
References: <20240419090259.39542-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

Hi Yang,

On Fri, 2024-04-19 at 17:02 +0800, Yang Li wrote:
> This patch adds the missing description for the dev_id parameter in the
> kernel documentation for the request_dma_bycap function.
>=20
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  arch/sh/drivers/dma/dma-api.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/sh/drivers/dma/dma-api.=
c
> index 89cd4a3b4cca..65005d348877 100644
> --- a/arch/sh/drivers/dma/dma-api.c
> +++ b/arch/sh/drivers/dma/dma-api.c
> @@ -116,6 +116,7 @@ static int search_cap(const char **haystack, const ch=
ar *needle)
>   * request_dma_bycap - Allocate a DMA channel based on its capabilities
>   * @dmac: List of DMA controllers to search
>   * @caps: List of capabilities
> + * @dev_id: Unique identifier for the device that is requesting a DMA ch=
annel
>   *
>   * Search all channels of all DMA controllers to find a channel which
>   * matches the requested capabilities. The result is the channel

Thanks. This should include "sh:" in the subject. I will add this manually
when picking up the patch. Also, the missing Fixes tag as Geert noted.

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Adrian

--=20
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913