Received-SPF: pass (google.com: domain of linux-kernel+bounces-151311-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <229b9ae2-1705-493b-b0fc-9de6c32925a5@quicinc.com>
Date: Fri, 19 Apr 2024 15:50:32 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Umang Chheda <quic_uchheda@quicinc.com>
Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcs6490-rb3gen2: enable PMIC
 Volume and Power buttons
To: Bjorn Andersson <andersson@kernel.org>
CC: Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240403132839.2117675-1-quic_uchheda@quicinc.com>
 <6b3gqfrvljvlfaf365l55kjcbjd4rfmw223tro6rqy5crykxgb@l66dptcrujip>
 <3ca2f601-ce45-43cf-b0dd-e28865874455@quicinc.com>
 <jlwxlnllpt557eiktovujcrfm2qwd3ynlxpo2v2witkekvocey@indbptcgvitm>
Content-Language: en-US
In-Reply-To: <jlwxlnllpt557eiktovujcrfm2qwd3ynlxpo2v2witkekvocey@indbptcgvitm>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 4/15/2024 7:30 AM, Bjorn Andersson wrote:
> On Fri, Apr 12, 2024 at 04:18:36PM +0530, Umang Chheda wrote:
>> Hi Bjorn,
>>
>> On 4/9/2024 8:47 PM, Bjorn Andersson wrote:
>>> On Wed, Apr 03, 2024 at 06:58:39PM +0530, Umang Chheda wrote:
>>>> The Volume Down & Power buttons are controlled by the PMIC via
>>>> the PON hardware, and the Volume Up is connected to a PMIC gpio.
>>>>
>>>> Enable the necessary hardware and setup the GPIO state for the
>>>> Volume Up gpio key.
>>>>
>>>> Signed-off-by: Umang Chheda <quic_uchheda@quicinc.com>
>>>> ---
>>>
>>> I suppose this isn't a "resend" either, so please send me a new version
>>> of this as well.
>>>
>>
>> I had earlier sent [1] for review, on which I hadn't received any review comments.
>>
> 
> I see.
> 
> If you want reviews on your patches, ask a colleague to invest a few
> minutes in the patch and send a Reviewed-by or Tested-by. That both 
> 
> Not only will this give you reviews, it will show the community and the
> maintainer that there's someone out there who's interested in seeing the
> patch merged.
>

Thanks for the suggestion! will ask colleagues to help with R-by/T-By tags on the patches
as suggested.

>> Hence, I resent this patch again after 2 weeks for review.
>>
> 
> Please only resend patches if you strongly believe that necessary
> recipients didn't receive the patch.
> 
Ack

Regards,
Umang

> Regards,
> Bjorn