Received-SPF: pass (google.com: domain of linux-kernel+bounces-151349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Received-SPF: Pass (protection.outlook.com: domain of axis.com designates
 195.60.68.100 as permitted sender) receiver=protection.outlook.com;
 client-ip=195.60.68.100; helo=mail.axis.com; pr=C
From: Waqar Hameed <waqar.hameed@axis.com>
To: <alexandre.belloni@bootlin.com>
CC: <linux-rtc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rtc: rx8111: handle VLOW flag
In-Reply-To: <20240417191937.33790-2-alexandre.belloni@bootlin.com> (alexandre
	belloni's message of "Wed, 17 Apr 2024 21:19:36 +0200")
References: <20240417191937.33790-1-alexandre.belloni@bootlin.com>
	<20240417191937.33790-2-alexandre.belloni@bootlin.com>
User-Agent: a.out
Date: Fri, 19 Apr 2024 13:04:34 +0200
Message-ID: <pndh6fxmx4t.fsf@axis.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 11:04:35.5806
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d138189-877c-4374-285d-08dc60607fc6
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5PEPF00014B9B.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB9143

On Wed, Apr 17, 2024 at 21:19 +0200 alexandre.belloni@bootlin.com wrote:

> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> Allow userspace to get battery status information and be able to warn when
> battery is low and has to be replaced.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>  drivers/rtc/rtc-rx8111.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/rtc/rtc-rx8111.c b/drivers/rtc/rtc-rx8111.c
> index 4a35bd921b33..8450d9f0b566 100644
> --- a/drivers/rtc/rtc-rx8111.c
> +++ b/drivers/rtc/rtc-rx8111.c
> @@ -95,6 +95,9 @@ enum rx8111_regfield {
>  	RX8111_REGF_INIEN,
>  	RX8111_REGF_CHGEN,
>  
> +	/* RX8111_REG_STATUS_MON. */
> +	RX8111_REGF_VLOW,
> +
>  	/* Sentinel value. */
>  	RX8111_REGF_MAX
>  };
> @@ -129,6 +132,8 @@ static const struct reg_field rx8111_regfields[] = {
>  	[RX8111_REGF_SWSEL1] = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 3, 3),
>  	[RX8111_REGF_INIEN]  = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 6, 6),
>  	[RX8111_REGF_CHGEN]  = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 7, 7),
> +
> +	[RX8111_REGF_VLOW]  = REG_FIELD(RX8111_REG_STATUS_MON, 1, 1),
>  };
>  
>  static const struct regmap_config rx8111_regmap_config = {
> @@ -276,6 +281,13 @@ static int rx8111_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)
>  
>  		vlval = regval ? RTC_VL_DATA_INVALID : 0;
>  
> +		ret = regmap_field_read(data->regfields[RX8111_REGF_VLOW],
> +					&regval);
> +		if (ret)
> +			return ret;
> +
> +		vlval |= regval ? RTC_VL_BACKUP_LOW : 0;
> +
>  		return put_user(vlval, (typeof(vlval) __user *)arg);
>  	default:
>  		return -ENOIOCTLCMD;

Looks good to me!

Tested-by: Waqar Hameed <waqar.hameed@axis.com>
Reviewed-by: Waqar Hameed <waqar.hameed@axis.com>