Received-SPF: pass (google.com: domain of linux-kernel+bounces-151370-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Content-Type: multipart/signed;
 boundary=4631f6a9b2d371b5a1490d95dc7549b23a9b87b8b54b5e8e1f77dbc0f933;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Fri, 19 Apr 2024 13:29:34 +0200
Message-Id: <D0O2C1JJOF90.3MOQH6PE1M2SL@gmail.com>
Subject: Re: [PATCH 3/4] gpu: host1x: Convert to platform remove callback
 returning void
From: "Thierry Reding" <thierry.reding@gmail.com>
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 "David Airlie" <airlied@gmail.com>, "Daniel Vetter" <daniel@ffwll.ch>
Cc: "Mikko Perttunen" <mperttunen@nvidia.com>,
 <dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
References: <cover.1712681770.git.u.kleine-koenig@pengutronix.de>
 <7e31909b1e536f0ddbb060b1aaa0a9e943687c8a.1712681770.git.u.kleine-koenig@pengutronix.de>
In-Reply-To: <7e31909b1e536f0ddbb060b1aaa0a9e943687c8a.1712681770.git.u.kleine-koenig@pengutronix.de>

--4631f6a9b2d371b5a1490d95dc7549b23a9b87b8b54b5e8e1f77dbc0f933
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Tue Apr 9, 2024 at 7:02 PM CEST, Uwe Kleine-K=C3=B6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/gpu/host1x/dev.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

--4631f6a9b2d371b5a1490d95dc7549b23a9b87b8b54b5e8e1f77dbc0f933
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmYiVZ8ACgkQ3SOs138+
s6ED0BAApayQb5R8tzI25oRF9vE4dD7fgryHQ6lE8bDFua62RK1xuC0+16Fi323n
5eHdLgQSC/zdAUB+E0OeRpqWg7JGTJqfbfbn9hE5HT3qQu9MxDzI9btpGAHowNlv
SOzzsMOjICuAhZ/92iZ0jp1EtsyU7QdhQ6jOMeFHqQFNggvpzXjLzeh+E+BoRvNK
1SAGI1x+Eo7PHrFAOHgoZn/grnlyuSlGelszK5hwx3Rsr8LQ4qbYtMzTNKkdtDxv
OSgiDSEuTQaqbROckvB5IOK8TZKwMMukSYkpJg/omb0y8dDjfWvqX38VTl2+NfIs
jGa97Fi0/N2Ny9weM3jk7Rx64HCW/FxcCAcj0Wk9fVZAkh8aFUXYUxjigLFncDVr
0p3BWfYeBebl8RSCQ4u0omoo9Ar5+yoBXs8+WhAm5QPdoqseCruj1JPFqiZl3KLt
FYgRGmAIIMIh0R7089+8oT8wPc2t+HN/Wsoif8z+B/RqIERQBCfKV4GXd6I3nkKN
2wl8TZUIWMGvy4VsXG8r4iufoHgW15AoWMOuI0gCgZt8ukVhyRdZGyX0Y1a0eFmP
EHdY2XHmvOSEFlQE71pXm1kvocBHzChg0eEvBkb5s9m9VPp0LnKbiyQty4bYuCN+
x5bLRkc13YsDn5sdB61L1qKLgDXWLMpn7zjelxT+M0aoJdAgDqU=
=suAC
-----END PGP SIGNATURE-----

--4631f6a9b2d371b5a1490d95dc7549b23a9b87b8b54b5e8e1f77dbc0f933--