To: hpa@zytor.com
CC: miklos@szeredi.hu, akpm@linux-foundation.org,
       linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
In-reply-to: <4798EB07.50002@zytor.com> (hpa@zytor.com)
Subject: Re: [patch 10/26] mount options: fix devpts
References: <20080124193341.166753833@szeredi.hu> <20080124193429.480166399@szeredi.hu> <4798EB07.50002@zytor.com>
Message-Id: <E1JIKn4-0001Jb-Vo@pomaz-ex.szeredi.hu>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Fri, 25 Jan 2008 10:24:02 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 28

> > Also add minor fix: when parsing the "mode" option, mask with
> > S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
> > mask.
> 
> umode_t is 16 bits, so it doesn't.  The change is still good, of course.

We still use 16 bit types?  Strange ;)

> 
> > +	if (config.mode != DEVPTS_DEFAULT_MODE)
> > +		seq_printf(seq, ",mode=%03o", config.mode);
> 
> I would rather this be unconditional, than that it be conditional on 
> something other than the user having specified it in the first place.

Yeah, it's a matter of taste.  I'll update the patch.

Actually, a lot of filesystems share the options 'uid=X', 'gid=X',
'mode=X' (or 'umask=X').  This could be handled by the VFS, saving
some code, and making things more consistent.  One day maybe...

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/