Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp590927lqt; Fri, 19 Apr 2024 05:13:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUuad4CQ1yGCsLLFK/jJa+hX4eH0VqpLkLzc+1RPhcXstLBKKgJcZZEca/XovoPmO1YES7wOaGGrthVr6H0Hh31Ynq2PdKL7CQLWua95w== X-Google-Smtp-Source: AGHT+IHFWlCaukm2tfDV35jjARaH7AVuHtQ7AASB9frjS2QRPh/4zenI5M0m53KuXWohk6hRjuol X-Received: by 2002:a17:90a:604f:b0:2ac:23ec:6a4e with SMTP id h15-20020a17090a604f00b002ac23ec6a4emr2116205pjm.31.1713528780560; Fri, 19 Apr 2024 05:13:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713528780; cv=pass; d=google.com; s=arc-20160816; b=DH7sOmEDt28jU8VLFs340AsQYhvs1r9EtRWF8PWYg63P3hEQt43a5GEAEk4Gch6Kp2 Ko+foJPcv1Ts4fAy9Mha1JagHhOLCuNKUBT1EaZPD86nQ8ra7xe2Nf3UqMVoYqVseYfP 2I+KmzwSFaImq9Vn2qpvwZ7ZPp+W0kgTw1NGazaxagtjosuBPrR1gsJISMcbs1nYGzf4 FbpB+znFr1rJ5psq/gECBU5EyRYjIArbidWVqTu5lLOOVADHoXcY/3aToOdVeAbezZjd haUX9E5mUUbkrkQw7DjnBfSf3hxDmLQpWYYF66eIY77gVXx4Wt108L/JM2VZECd0TBY+ hlMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=/P9L2VtL/ZKozSohvFSXvYb6ofUKS8td/MBAOU2mTwE=; fh=uXNcFGf+6+IS98DcvTd1qbd0QMT6wIT5uTr/zFQmKzY=; b=HNh/cCqrMbm9kAgsLwDCThcAwa1Gyt167wfMCEYPMGfDS0RQOs/NnGiDd/Z2cqzj/+ 6G/mvs2OtLZo3PDXcux9n+tK1UJfUXCr97HrBC9Cawik/xgDWZcmwIvKuJbEy9Ym90fT +LRv9NeyuYKZSxe8bqaW2ICVOhNXKhoHGj5vsZDqEknX+Qcj5Luy3jdNI9VrU/MuMpNb JaXAE8WepjHYCRz/heS1uBToKe960CNBNHh3yY317Ww806nmiQEDGGUZECsJdzwvujYv UAMazUdbKBlLWD3NJJLzdjvToilWvn3jmSCiuqVEeqTCe1LHT0f1d0WckdpCzunp2iay Xlmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-151398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151398-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n16-20020a17090a161000b002a5a407e79csi3185561pja.159.2024.04.19.05.13.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 05:13:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-151398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151398-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5E697B214E3 for ; Fri, 19 Apr 2024 12:12:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5875785273; Fri, 19 Apr 2024 12:12:47 +0000 (UTC) Received: from mail-m25499.xmail.ntesmail.com (mail-m25499.xmail.ntesmail.com [103.129.254.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4312378285; Fri, 19 Apr 2024 12:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.129.254.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713528766; cv=none; b=Fk+MsmtDSYiauG3Wri77oc+a3ZseTDq7m02XcisARHpoOPu/KyX5U80JTl1z1+WwFLwNsHvCXbIH1qPBkqgaKM7o2NZWMNHFwLPEZHWkzV7k0i6gdGdxXfzywCPoJtZ6Ei/Yex4F2QrU5fPwauNT5puFAJEQlTdfVgfN9eEoxhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713528766; c=relaxed/simple; bh=KZGUHlRWEuj7dHpQ9LaQKSzrzqTzErAnF5h96rQdeJo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=df+Wz76eGw2j8kZMQhMIWr1ahw+qZzZ/Rv3QJNrCxgkV4LA3o/cnWZP5274YDUbuaUYbD1eSGIdHszHKGGRjG/3ikKEY0UBgBV2gDY7scFf4sFHc5enl7++pYSY8z3FDPudzJKjLuQtSp/ltonmPKWB3PZgk71QWfXHupAogvIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=easystack.cn; spf=none smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=103.129.254.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [110.185.170.227]) by smtp.qiye.163.com (Hmail) with ESMTPA id 6F0EF56025F; Fri, 19 Apr 2024 14:14:28 +0800 (CST) From: Jun Gu To: kuba@kernel.org Cc: dev@openvswitch.org, echaudro@redhat.com, jun.gu@easystack.cn, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v4] net: openvswitch: Check vport netdev name Date: Fri, 19 Apr 2024 14:14:25 +0800 Message-Id: <20240419061425.132723-1-jun.gu@easystack.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVlCTh8eVk5DGksYGh4dTxgfSlUZERMWGhIXJBQOD1 lXWRgSC1lBWUpKS1VKQ05VSkxLVUlJTFlXWRYaDxIVHRRZQVlPS0hVSk1PSUxOVUpLS1VKQktLWQ Y+ X-HM-Tid: 0a8ef4fdf7cc023dkunm6f0ef56025f X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Ok06Pxw5Gjc0Th8uMRwoLA9N GQkaFChVSlVKTEpITktMSU1DQ0JCVTMWGhIXVREOFVUcDjseGggCCA8aGBBVGBVFWVdZEgtZQVlK SktVSkNOVUpMS1VJSUxZV1kIAVlBSkxJSjcG Ensure that the provided netdev name is not one of its aliases to prevent unnecessary creation and destruction of the vport by ovs-vswitchd. Signed-off-by: Jun Gu Acked-by: Eelco Chaudron --- net/openvswitch/vport-netdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 903537a5da22..618edc346c0f 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) int err; vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); - if (!vport->dev) { + /* Ensure that the device exists and that the provided + * name is not one of its aliases. + */ + if (!vport->dev || strcmp(name, ovs_vport_name(vport))) { err = -ENODEV; goto error_free_vport; } -- 2.25.1