Received-SPF: pass (google.com: domain of linux-kernel+bounces-151401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 08:17:27 -0400
From: Parker Newman <parker@finest.io>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Parker Newman
 <pnewman@connecttech.com>, Ilpo =?UTF-8?B?SsOkcnZpbmVu?=
 <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v1 4/4] serial: exar: change port_type ternary line
 wrapping
Message-ID: <20240419081727.435437d0@SWDEV2.connecttech.local>
In-Reply-To: <379d43bd-d5eb-4877-8781-888c82821bb8@kernel.org>
References: <cover.1713452766.git.pnewman@connecttech.com>
	<0081b6a7bbe1ad6ce114132f9ee86677a761de6d.1713452766.git.pnewman@connecttech.com>
	<379d43bd-d5eb-4877-8781-888c82821bb8@kernel.org>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:lvffdMyJ6rI=;3x/ki+/JYMfzigA6OjZQS5lxRx7
 t7CewaI8psr1Qtsj9JHgNXvVjT/Zxwl6z++Ga6+pzuXNIDNhhLbU8q3OnUljgclBliRFVz0iz
 BGqo//nSLxPQAJ1ZTzqaL3O+tqHn4myNDJOze+QjXifq2npjvo/f03Cpsh2ftaqj4n33EskKt
 Yj5uzWeCgXipUlQH72F280vvLi/QRFBGGpC7QaWxFOA9VxQZpg0DO00Gyr6nbDgihwdN/hwYd
 yngjPDNjahFNHYcKIqKg4Jk1OUPNHnW5Qd+bqzXHvz6Y7/gSdvfEEYMsCPNAiy3j4gugqW1s6
 Pd84Z8B1HI00A17boqdLxxWAcylQj8TqfOl1CwE8fIPCuimBq+hHLV09C+alw8BfpreSaNAx+
 nUjfu1acZk6qgRnrJjxiybweZhX0lZS/2zf2BCN0tzRXWBgQIonKRSk+Bzktw754AZKSkqxvh
 IeGfsGB8+9xuUn5dIQRkxohYd+H0F+INZQbCV9cGHoVEXNTH8+/DNdHgRruu6cdYlpW6NTwx5
 UBnDQhQm+7TsQn3Y3TJFk6bSkPeWeLMQCrR4hPSoL2RxGBBSGxOOKbfGEcvezM4TTLTcreRWn
 Yy9WMZC9HEnVnOmcI24JyTC1WxRoM0VboBBtv429mPWK8lsSpxHXYYSqlmKc7elZuw5JC/i4i
 vCtfGNqlusQEsMUvOEjRiFERgSpnhFE6Iqqni4EeZuVgMRr1fgAaWkK28zLxZeWqCAJ0jQ/f2
 V4UQg87BIxVc8THBiYP9K2nLhd3SVG5thMvyXTPIqv1cM8vPfHPlr4=

On Fri, 19 Apr 2024 08:07:50 +0200
Jiri Slaby <jirislaby@kernel.org> wrote:

> On 18. 04. 24, 17:36, Parker Newman wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > Change line wrapping of ternary operators in
> > cti_get_port_type_xr17c15x_xr17v25x() for better readability.
> >
> > Old example:
> >
> > 	port_type =3D port_num =3D=3D 0 ?
> > 			CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485;
> >
> > New:
> > 	port_type =3D port_num =3D=3D 0 ? CTI_PORT_TYPE_RS232 :
> > 				CTI_PORT_TYPE_RS422_485;
>
> This is worse IMO. Ilpo suggested a bit different alignment. But still..=
.
>
> > Based on feedback from:
> > Link: https://lore.kernel.org/linux-serial/f2353b8c-2079-b895-2707-f6b=
e83161288@linux.intel.com
>
> You should have CCed the author.
>
> > Signed-off-by: Parker Newman <pnewman@connecttech.com>
> > ---
> >   drivers/tty/serial/8250/8250_exar.c | 20 ++++++++++----------
> >   1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/=
8250/8250_exar.c
> > index 10725ad0f3ef..a76b4e5bab4e 100644
> > --- a/drivers/tty/serial/8250/8250_exar.c
> > +++ b/drivers/tty/serial/8250/8250_exar.c
> > @@ -741,19 +741,19 @@ static enum cti_port_type cti_get_port_type_xr17=
c15x_xr17v25x(struct exar8250 *p
> >   		break;
> >   	// 1x RS232, 1x RS422/RS485
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_1_1:
> > -		port_type =3D port_num =3D=3D 0 ?
> > -			CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485;
> > +		port_type =3D port_num =3D=3D 0 ? CTI_PORT_TYPE_RS232 :
> > +					CTI_PORT_TYPE_RS422_485;
>
>
> Well, could you initialize port_type =3D CTI_PORT_TYPE_RS232? And here d=
o
> only:
> if (port_num > 0)
>      return CTI_PORT_TYPE_RS422_485;
> ?
>

I like this idea I will move to that. Thanks.

>
> >   		break;
> >   	// 2x RS232, 2x RS422/RS485
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2_2:
> > -		port_type =3D port_num < 2 ?
> > -			CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485;
> > +		port_type =3D port_num < 2 ? CTI_PORT_TYPE_RS232 :
> > +					CTI_PORT_TYPE_RS422_485;
>
> And so on.
>
> >   		break;
> >   	// 4x RS232, 4x RS422/RS485
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_4_4:
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_4_4_SP:
> > -		port_type =3D port_num < 4 ?
> > -			CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485;
> > +		port_type =3D port_num < 4 ? CTI_PORT_TYPE_RS232 :
> > +					CTI_PORT_TYPE_RS422_485;
> >   		break;
> >   	// RS232/RS422/RS485 HW (jumper) selectable
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2:
> > @@ -789,13 +789,13 @@ static enum cti_port_type cti_get_port_type_xr17=
c15x_xr17v25x(struct exar8250 *p
> >   		break;
> >   	// 6x RS232, 2x RS422/RS485
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_6_2_SP:
> > -		port_type =3D port_num < 6 ?
> > -			CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485;
> > +		port_type =3D port_num < 6 ? CTI_PORT_TYPE_RS232 :
> > +					CTI_PORT_TYPE_RS422_485;
> >   		break;
> >   	// 2x RS232, 6x RS422/RS485
> >   	case PCI_SUBDEVICE_ID_CONNECT_TECH_PCI_UART_2_6_SP:
> > -		port_type =3D port_num < 2 ?
> > -			CTI_PORT_TYPE_RS232 : CTI_PORT_TYPE_RS422_485;
> > +		port_type =3D port_num < 2 ? CTI_PORT_TYPE_RS232 :
> > +					CTI_PORT_TYPE_RS422_485;
> >   		break;
> >   	default:
> >   		dev_err(&pcidev->dev, "unknown/unsupported device\n");
> > --
> > 2.43.2
> >
>