Received-SPF: pass (google.com: domain of linux-kernel+bounces-151410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Apr 2024 13:31:51 +0100
From: Simon Horman <horms@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, sgoutham@marvell.com,
	gakula@marvell.com, hkelam@marvell.com, sbhatta@marvell.com
Subject: Re: [net-next PATCH v2] octeontx2-pf: Add ucast filter count
 configurability via devlink.
Message-ID: <20240419123151.GB3975545@kernel.org>
References: <20240418190031.1115865-1-saikrishnag@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240418190031.1115865-1-saikrishnag@marvell.com>

On Fri, Apr 19, 2024 at 12:30:31AM +0530, Sai Krishna wrote:
> Added a devlink param to set/modify unicast filter count. Currently
> it's hardcoded with a macro.
> 
> commands:
> 
> To get the current unicast filter count
>  # devlink dev param show pci/0002:02:00.0 name unicast_filter_count
> 
> To change/set the unicast filter count
>  # devlink dev param  set  pci/0002:02:00.0  name unicast_filter_count
>  value 5 cmode runtime
> 
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> ---
> v2:
>     - Addressed review comments given by Simon Horman
> 	1. Updated the commit message with example commads
>       2. Modified/optimized conditions

Reviewed-by: Simon Horman <horms@kernel.org>