Received-SPF: pass (google.com: domain of linux-kernel+bounces-151418-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Fri, 19 Apr 2024 05:36:33 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
	lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
	f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
	srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org,
	allen.lkml@gmail.com, broonie@kernel.org,
	Phillip Pearson <philpearson@google.com>
Subject: Re: [PATCH 5.4 000/215] 5.4.274-rc1 review
Message-ID: <a5c09590-edfe-4fef-8edc-75a39b92446e@roeck-us.net>
References: <20240411095424.875421572@linuxfoundation.org>
 <787e0ac1-cb31-47d9-8200-3f6a3b4119dd@roeck-us.net>
 <c5d0c7f7-96a0-4806-b3b6-269d9189037d@roeck-us.net>
 <2024041949-strained-steadfast-13cf@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024041949-strained-steadfast-13cf@gregkh>

On Fri, Apr 19, 2024 at 12:41:02PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 18, 2024 at 12:38:59PM -0700, Guenter Roeck wrote:
> > On Thu, Apr 18, 2024 at 12:25:21PM -0700, Guenter Roeck wrote:
> > > On Thu, Apr 11, 2024 at 11:53:29AM +0200, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 5.4.274 release.
> > > > There are 215 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > [ ... ]
> > > > 
> > > > Sean Christopherson <seanjc@google.com>
> > > >     KVM: Always flush async #PF workqueue when vCPU is being destroyed
> > > > 
> > > 
> > > This backport is bad. In kvm_setup_async_pf(), it removes a call to
> > > kvm_get_kvm(). However, it does not remove the call to kvm_put_kvm()
> > > in its error handler. Also see upstream commit 7863e346e108 ("KVM:
> > > async_pf: Cleanup kvm_setup_async_pf()") which explains that one of
> > > the error paths in kvm_setup_async_pf() which is not supposed to be
> > > observed can be observed after all.
> > > 
> > 
> > Reverting the above commit from v5.4.y fixes the problem. Alternatively,
> > applying commit 7863e346e108 on top of v5.4.274 fixes it as well.
> > 
> > I added Phillip Pearson to Cc:; he did all the testing and can provide
> > additional information if needed.
> 
> So which is recommended, revert or add the other commit?
> 
We decided to apply 7863e346e108.

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/5465806

Guenter