Received-SPF: pass (google.com: domain of linux-kernel+bounces-151432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <cd505cc611db537c1ecfab8a35e43ba9e1e28171.camel@linux.ibm.com>
Subject: Re: [PATCH] scsi: qla2xxx: Use -EIO in qla_get_tmf()
From: James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To: Markus Elfring <Markus.Elfring@web.de>, linux-scsi@vger.kernel.org,
        kernel-janitors@vger.kernel.org,
        GR-QLogic-Storage-Upstream@marvell.com,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Nilesh Javali
 <njavali@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Date: Fri, 19 Apr 2024 08:45:48 -0400
In-Reply-To: <18be23bd-415e-4030-8035-d1f180cdca7a@web.de>
References: <18be23bd-415e-4030-8035-d1f180cdca7a@web.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Fri, 2024-04-19 at 14:34 +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 19 Apr 2024 14:24:56 +0200
> 
> Add a minus sign before the error code “EIO”
> so that a negative value will eventually be returned
> as in another error case.

No it won't.  If you look how it's used the consumer doesn't pass on
the error.

James