Received-SPF: pass (google.com: domain of linux-kernel+bounces-151433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 19 Apr 2024 08:50:18 -0400
From: Parker Newman <parker@finest.io>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Parker Newman
 <pnewman@connecttech.com>
Subject: Re: [PATCH v1 3/4] serial: exar: remove unneeded parenthesis
Message-ID: <20240419085018.5a5c5826@SWDEV2.connecttech.local>
In-Reply-To: <4a7a1c35-f1f6-4ed3-ad57-d71891220219@kernel.org>
References: <cover.1713452766.git.pnewman@connecttech.com>
	<1dbe1847d92dd34d223c6dc6b5cd0731b78e98e5.1713452766.git.pnewman@connecttech.com>
	<2024041951-paradox-stable-320e@gregkh>
	<4a7a1c35-f1f6-4ed3-ad57-d71891220219@kernel.org>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:hl9aSz4ph+8=;Dt2eAanbqVuhgV/69Tg9c4UYaHW
 tvKR/ltNSYLIVW+Hae3nIGPcB7M2F+46otcCUYlkbnr6eq+HNV4DN6C0Sn40I/nLhMgKMCBv8
 iCqc1m4FkgGdTdAC4ezkj+5eMYPESxrlnVB8oSaqLoQO0zP/dSY/BuHFR2VvbLlFe9mVmaF/w
 pRzT5nBhwQAn15AO4STwD6PGOQMvEVEUnaYcFADUU7UBd+B/ZGOXEeiSpirPIiKs+vDCmpUPa
 OxFz3fz1ePsfryru0D6b/x3DZRAgh4LLYPXo8YEE00YxuEsuVEF3pEOPvyGEQOl+eocpp4kCf
 b9zfOAxLO83yUWZ9qMY2s9fSZVwrQ8OC28HILfhL4Zto4xpGax4PrtrSSw8hmW8nNm4Zb/hBA
 2c9UM/6hjtylpLk1+3ZtWx7Vhb52d6AjF3V4sb6SCiDiq9I1Zd4s04FSRn+r9+OlG5uHNnI0w
 5AhfxQFY3q0inxXXxKB0SztKAzrizj5tSQIOVxWwZgbF63pVww76C3fmry/xbEOADoOpAdIZ/
 pWwCrhlnCCUnYr/U5vOO7ObfhJSpn9RoDRyURuuv2weKpASoGcNBDx1LN4Huf2ac6/FWogepv
 ucYEVfbdp9nQi8qM6fbPqRuoG2mwEXQbD6ZVkVFoVBWqkRnDjyYwVtTLjF4V65qT/9HKxVMLK
 dN7WLlu5E+WHaiVZnbzUSH6fHV9O3Ohnc4F82cDFYoNm9iib8JGwNggKJFjjtTVyIWFSTgeu4
 gS16xn096qr3TJ+hnoi9FglXhW4WUZ8NoyaPYqT4Xd3e4sCKplDXzU=

On Fri, 19 Apr 2024 09:01:22 +0200
Jiri Slaby <jirislaby@kernel.org> wrote:

> On 19. 04. 24, 8:58, Greg Kroah-Hartman wrote:
> > On Thu, Apr 18, 2024 at 11:36:30AM -0400, Parker Newman wrote:
> >> From: Parker Newman <pnewman@connecttech.com>
> >>
> >> Remove unneeded parenthesis from several locations.
> >>
> >> Based on feedback from:
> >> Link: https://lore.kernel.org/linux-serial/f2353b8c-2079-b895-2707-f6=
be83161288@linux.intel.com
> >>
> >> Signed-off-by: Parker Newman <pnewman@connecttech.com>
> >> ---
> >>   drivers/tty/serial/8250/8250_exar.c | 28 ++++++++++++++------------=
--
> >>   1 file changed, 14 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial=
/8250/8250_exar.c
> >> index 01748ddbf729..10725ad0f3ef 100644
> >> --- a/drivers/tty/serial/8250/8250_exar.c
> >> +++ b/drivers/tty/serial/8250/8250_exar.c
> >> @@ -317,7 +317,7 @@ static inline u8 exar_ee_read_bit(struct exar8250=
 *priv)
> >>
> >>   	regb =3D exar_read_reg(priv, UART_EXAR_REGB);
> >>
> >> -	return (regb & UART_EXAR_REGB_EEDO ? 1 : 0);
> >> +	return regb & UART_EXAR_REGB_EEDO ? 1 : 0;
> >
> > Again, spell out the ? : stuff here please.  Using () isn't the proble=
m :)
>
> Could this in fact be inline bool exar_is_ee_set() (or alike) and return
> that regb & UART_EXAR_REGB_EEDO directly (w/o using ternary at all)?
>
> thanks,

That would work. I will update.
Thanks,
Parker