Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp637838lqt; Fri, 19 Apr 2024 06:25:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXcghaa6eqWM7SgxoLBFG3ppvrPrgLZtYBRBpd4SiPIBc3soz28HqXHcYfkmoj1Q3cLE3P60s18y4n+GfKXfSQ4sZ1MsqD8uhqlQ8Kwdg== X-Google-Smtp-Source: AGHT+IFEP24BtcdepIrwd117SKK27R2di4+KBM02xuTKiUf2Dt5KJqVxm663DF97RglQQWh1+Fdt X-Received: by 2002:a2e:b0d8:0:b0:2da:7944:9549 with SMTP id g24-20020a2eb0d8000000b002da79449549mr1407828ljl.35.1713533114850; Fri, 19 Apr 2024 06:25:14 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id d8-20020a50f688000000b0056fda099020si2292714edn.394.2024.04.19.06.25.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 06:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aa5bLbHd; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-151464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151464-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 81C461F233BF for ; Fri, 19 Apr 2024 13:25:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06C5B127B72; Fri, 19 Apr 2024 13:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aa5bLbHd" Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE08241C66 for ; Fri, 19 Apr 2024 13:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713533105; cv=none; b=N1F0Z0iGLdP7Oo3f97DmFhu26VSsLmnOHI2oBimCE/+GtrMWcJ4rP1hkYxQ5NbKZr0eUKO3lT8z6jkBJVKOkMPVAa806Ijr6B0YSNYW+aLRI7RjkH1Hq4gapKfgAb7Ib46Hi6w4tA5cuTYic56M2BNL5FjrEuKIb4Ka7+WaUbn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713533105; c=relaxed/simple; bh=UWXTaQ82HyFtQb3TRUV4cf5MB8r08tl9SIn+hgm0d+I=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Hs5Uc6KA7HAb0tdf/5ZJ/gCc4s9M1V4PdqT4nsnrTwd1Ux/5D+2QKxI6z+C82E8yjnUyCwyNE9M/Xz9AvxxiqM9JOxkklxpdGtO44FWorGgEdKhqpE6El5El6D+qfnV89JNEPwllRpw7QGDtWEFUOQsXDx/rvrDG4ET3NYgNHFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aa5bLbHd; arc=none smtp.client-ip=209.85.219.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-de45e5c3c68so2301021276.0 for ; Fri, 19 Apr 2024 06:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713533103; x=1714137903; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VkrOJ4wKG+fycpys61fJmDawiloLrXFnzq3mdhSsqRc=; b=aa5bLbHdbG/MRkL+K3v6q4HnJIyKyjT0PNGYQzu3xcKehSZhCBZo0Oa2STrIIHGxmI NYTDDIHZoVKFVSiamSwyZc86AOfpOIsn9UzsEhWUDoei/N+k2CeqKrZONtwqmJYwFtjn wGfloUa4qUl6S+LdV8pTsGWWZrfUk29P50IoEp4t9KHOcVz35KI3CWO3IqcCz7Z0kE1N Oucg0qfX3gDjuPo3fPNcf+8M7igM1XtK8XVeaOy+i+rCTjKt+e9Uy9X9LMwoFFo9WSOS hkT64eWbFcnhvV5hl2FFgt/1S9LdhwHvAHps+QECurjuNctvfCVrK7H5h77RkdcohOHI MroQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713533103; x=1714137903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VkrOJ4wKG+fycpys61fJmDawiloLrXFnzq3mdhSsqRc=; b=FHNtupgACpEeRVJ6xEuFbhr5VzoLyHv97+mFyNM3fmUjVTOAO+9gK8+7pB/zJTBdDQ APvid9dmh6+mxXXs1v1fJDm7fhVqeoJ7zJ68vvkwt4/q3v/Ss/rWKxOb3pGfnaW28hUI 6M4t/Rt7h9C4zVtAKVyiQKUDXQnqb96aWrml4v3Q1oZAJALiTC3btsBQqL3NSdYWpzWs pK+EfNpCLQT1/2+ZJBIIhMW+UFsdAsv3VG089gfqLEvDXmK5pSOUadGLUjgCmxd/AFef xAe7zWrs9EeyFBSsoGYFDF/uT+4fMPCzO+XjT56XPz9L6CjrSdPI/FxyxSggGNVD+mwj KVkA== X-Forwarded-Encrypted: i=1; AJvYcCU0JMqqMD9bs+O6gf3tDrGS4ZC42fpHDtYDprw65wryOJjwSJhAJfTZZmzuh7r26KM8FQvr16iHc4qH4uy1ioynaFLjv61NK2kf7sGW X-Gm-Message-State: AOJu0YzSEuEDy3YfihdIE2C+8xpjUbxUWs/dI35anIPGmFIHCLNrblQs enREl+ub+Sl7VojpngaZwwz/4n5gPLENcK43MwLR0MmHB/6QNpIDODBnO60UIN5SHlrP8YHScL8 AD1009G8k+zNhwbp1EMzxqSanFTT/F79HBaAO8w== X-Received: by 2002:a25:55:0:b0:dcc:f0a:e495 with SMTP id 82-20020a250055000000b00dcc0f0ae495mr1727089yba.3.1713533102898; Fri, 19 Apr 2024 06:25:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240415105328.3651441-1-zengheng4@huawei.com> In-Reply-To: From: Linus Walleij Date: Fri, 19 Apr 2024 15:24:52 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() To: Dan Carpenter Cc: Andy Shevchenko , Zeng Heng , linux-kernel@vger.kernel.org, xiexiuqi@huawei.com, linux-gpio@vger.kernel.org, weiyongjun1@huawei.com, liwei391@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 17, 2024 at 7:49=E2=80=AFPM Dan Carpenter wrote: > Probably we should add a comment to say: > > /* Return -ENODEV if the property 'pinctrl-0' is not present. */ Would you mind sending a oneliner on top to fix this? Yours, Linus Walleij