Received-SPF: pass (google.com: domain of linux-kernel+bounces-151468-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 15:25:26 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado <nfraprado@collabora.com>, 
	kernel@collabora.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Pin-yen Lin <treapking@chromium.org>, Hsin-Te Yuan <yuanhsinte@chromium.org>
Subject: Re: [PATCH v3] power: supply: sbs-battery: Handle unsupported
 PROP_TIME_TO_EMPTY_NOW
Message-ID: <b3btqqoijplf4ezr4akbj3dd5nevlf2pzen47bzwbm424pwnci@gc3etymakduu>
References: <20240418-sbs-time-empty-now-error-v3-1-f286e29e3fca@collabora.com>
 <f8c0bdd4-58fb-45a5-a70e-cc97f176222e@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cydfw5cw3mawxhkn"
Content-Disposition: inline
In-Reply-To: <f8c0bdd4-58fb-45a5-a70e-cc97f176222e@collabora.com>


--cydfw5cw3mawxhkn
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Apr 19, 2024 at 09:26:41AM +0200, AngeloGioacchino Del Regno wrote:
> Il 18/04/24 19:34, N=EDcolas F. R. A. Prado ha scritto:
> > Despite the RunTimeToEmpty() (0x11) function being defined in the SBS
> > specification as required, it seems that not all batteries implement it.
> > On platforms with such batteries, reading the property will cause an
> > error to be printed:
> >=20
> > power_supply sbs-8-000b: driver failed to report `time_to_empty_now' pr=
operty: -5
> >=20
> > This not only pollutes the log, distracting from real problems on the
> > device, but also prevents the uevent file from being read since it
> > contains all properties, including the faulty one.
> >=20
> > The following table summarizes the findings for a handful of platforms:
> >=20
> > Platform                                Status  Manufacturer    Model
> > ------------------------------------------------------------------------
> > mt8186-corsola-steelix-sku131072        OK      BYD             L22B3PG0
> > mt8195-cherry-tomato-r2                 NOT OK  PANASON         AP16L5J
> > mt8192-asurada-spherion-r0              NOT OK  PANASON         AP15O5L
> > mt8183-kukui-jacuzzi-juniper-sku16      NOT OK  LGC KT0         AP16L8J
> > mt8173-elm-hana                         OK      Sunwoda         L18D3PG1
> > sc7180-trogdor-lazor-limozeen-nots-r5   NOT OK  Murata          AP18C4K
> > sc7180-trogdor-kingoftown               NOT OK  333-AC-0D-A     GG02047=
XL
> > rk3399-gru-kevin                        OK      SDI             4352D51
> >=20
> > Detect if this is one of the quirky batteries during presence update, so
> > that hot-plugging works as expected, and if so report -ENODATA for
> > POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, which removes it from uevent and
> > prevents throwing errors.
> >=20
> > Signed-off-by: N=EDcolas F. R. A. Prado <nfraprado@collabora.com>
>=20
> N=EDcolas, please, I think that sending this commit to stable for backpor=
ting
> makes a lot of sense since you're actually fixing laptops (that does not
> really require a Fixes tag) that are supported upstream since .. lots of =
time
> ago.
>=20
> In any case, this LGTM.
>=20
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collab=
ora.com>

Considering we have a single commit adding TTE, it should be fine to
just add a Fixes tag for that:

Fixes: 6ea0126631b0 ("power: supply: sbs-battery: add support for time_to_e=
mpty_now attribute")

-- Sebastian

--cydfw5cw3mawxhkn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYicMEACgkQ2O7X88g7
+prwSg//ZJvOpFl9Jz8TJ0tdJb6BXGy3zv4WAEvPZT8oJPsjaJMUC1Bm+R3uCNfD
vuVZdlRzou3EwLWyho1vN2iR8Oi7DmpfZTMUcjGkbIxul2ty4g1mc6gEkycPt/ku
MkNeD1XD4A+R88dR7x2oaGzcA4WxUbnQMqEwzy1t7D6wVSo5aDaenFFHCOAhHwAX
MbKn6oe+taewYosI8rkVBO/K9HdaEOczHb9ds1Dp3WfL/LvJarKUcS27Sk35GCfF
9VWT9PYXqheMnkqGmnwUqGxRwSMyQqUxRv60IzWg9RgA1iZv8C/vIvcdcixQNw0w
ObmltEPif2u7QA9kM1g+wOmhkbdeuf/Qvmloekja5y7zgZK9OQQdiqDjSUpJzK6k
tNMU9OlfRBHA38S6UUc131UidHvKSiODKbBjMzubqMcXdEo628iIWk8Inw90sF94
Z8YOwomDfFiur7oCW19gUOnNJS+fAmrUd85fRjuHLYldF5zPH+mixbWwqizFF6G/
IYyzPtCLPVRDbPl2msd2Ev2hlMyKfMgtPeh0tdQJJ37Qn7f1KkDZ2vunHIsbdS4Q
kXGj9yUkg5Zsz5mDsNyioBC6rd7WDDJuw43YAfz3JAZ6NSuKTRjilk3DDZW4tUoD
l08yAaC8ax90uizXdxwZvnPty1YZ3bqlBwHqu66r3YO0VsM6Tyw=
=1rQq
-----END PGP SIGNATURE-----

--cydfw5cw3mawxhkn--