Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp649697lqt; Fri, 19 Apr 2024 06:42:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXzlis1736lBmIBQliD5gWhgTAaQ2/ifeWJq0b4MrnBHkfK1H6ipSrzUKwdEMT/fH7n3HQdvFgCx5F8FmtlRsIrCJlqKxuRPDt1JtoA4A== X-Google-Smtp-Source: AGHT+IEVqMeuo5ezoj/3KxYInoc3T6OgQtRVXmf8ktQltGBn1qIcTBk9I9jqGVNyRgRoxXsp5gE6 X-Received: by 2002:a17:906:742:b0:a54:c130:21fc with SMTP id z2-20020a170906074200b00a54c13021fcmr1561586ejb.16.1713534150776; Fri, 19 Apr 2024 06:42:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713534150; cv=pass; d=google.com; s=arc-20160816; b=ya+8H6kUWfYe+d2pGcJishcLoh+OK37Yg76vzk85mdxvXtiT1jwW77nAofAU1uqHia T5Sz0smq0KeDxZAjk9GtVMubir/C1KiVa1NhRTHWLlrhXj+6riAJDlvGP2+/PWpUBqWB j/LZxM7gJkgQrwk7nFBi7oP55JUjE5FjK/l1HpTQIZq0nsoPAB5lhWtic919OswbECVC NoqD0j7JzYoG1O4qv4uEK9TqNw3MF3GE6fDMfjIitVBQy+swdYeSSRDJch6Gp4TqzOO8 TK0mJ0V381SWqhUPJ2tzlUv8i/bewRh3AED8qaLYDx9g5rmBnXTIwKD2QUfFpFPLiP7A ueeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=gLeEh2KpL41aMiPmjvijMeQ+NpYYZ/n5pl7R+QoZm+E=; fh=C7CnuncgQU1sDXBfHuIYr/83S5eR0ui5lUKwOBXe4V0=; b=TZQsOe/pESGdruwJGB3L5I6iN2ID9nBP68on+x75b8ucvwkJ3bfCRyqwum6GBrTVCt Cz7MmJ/UOUXDEWh4nTIlIW4A8jg5DOqJLgknFOA86bDhHMlqvvyhFe/9BlNfks+2Is+e 5DyXr2V14SIz7NdOXh0kUBZX6Zb0Zip9O+VICbSbEOj/xgptgtHCt+gWBI9pv8IW8ZvY dTaphkf8nNv5gIJEejOgtN8HPcYGa0D45tl0Rd+p8hwPIi2tK/h6ln3Gbul/KRaOzjo5 IRzDyk/CdoAj+Qg4fGv6UeokK5rVjrwqDebURhroMOMa3ozmtxunR0QC+zwLUegH5BYb fRbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=P5wnIWlP; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-151493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151493-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ca6-20020a170906a3c600b00a46cc89b5ecsi2141850ejb.160.2024.04.19.06.42.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 06:42:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=P5wnIWlP; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-151493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151493-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 815981F23AF2 for ; Fri, 19 Apr 2024 13:42:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 57FC4128833; Fri, 19 Apr 2024 13:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="P5wnIWlP" Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7014612A151 for ; Fri, 19 Apr 2024 13:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713534131; cv=none; b=cOqzdhpsPSEyVRlkY0NJwVL6evQh6GjQidfP1RY6ewkaSYf9LGZi9GIKmzQWZmjRmet6Px7qffebm75El+a5XvJ8M2FiAly0CkecqgacOUKD4JFkKHLtb7dekwQIiSbVk9DDjLwk3eXVUpXaIlSNfzNxpNiDzlMzCo+T3R0ftaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713534131; c=relaxed/simple; bh=m+aW3ZV1GbE1e9yfgDFlcGvNARGgqlrucJS6VWZSudI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Za8zTRXppOYxsI3xdiHUm0eYr2cnrs1OVrwLLNOPfcMjVA9oxKkA2Oi2Qobp2DQXjNdAeK+9+IMaoTtsaBwl7LzWdFWQ5ETVp9DpKyAuCGcO8yz2lsB9aYrcd3EkUZu2qLv3Nu211SytnoYpPqE25FNnYQ622q6xIMefu9P7Nto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz; spf=pass smtp.mailfrom=xff.cz; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b=P5wnIWlP; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xff.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1713533777; bh=m+aW3ZV1GbE1e9yfgDFlcGvNARGgqlrucJS6VWZSudI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=P5wnIWlPxezCqS2wvKd6KcgnwYxU+XsjnFt1xIkJTx20A17TE15EBcLuNpCOoDYTg emXzPzvLZcjc6Xsxsz7PDpNeXjd2K7Umcx+vH7JxALRvh9aTEY9SA5u8qu+mh959mq HcUbOxybGwzDSnFgggrKIbiola9mUZSyr2J8ISbc= Date: Fri, 19 Apr 2024 15:36:17 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm Message-ID: Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20240224150604.3855534-1-megi@xff.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240224150604.3855534-1-megi@xff.cz> Hi, On Sat, Feb 24, 2024 at 04:05:57PM GMT, megi xff wrote: > From: Ondrej Jirman > > This series refactors blender setup from individual planes to a common > place where it can be performed at once and is easier to reason about. > > In the process this fixes a few bugs that allowed blender pipes to be > disabled while corresponding DRM planes were requested to be enabled. > > Please take a look. :) > > v2: > - use regmap_write where possible > - add review tags It would be nice to have this applied. Kind regards, o. > Thank you very much, > Ondřej Jirman > > Ondrej Jirman (3): > drm/sun4i: Unify sun8i_*_layer structs > drm/sun4i: Add more parameters to sunxi_engine commit callback > drm/sun4i: Fix layer zpos change/atomic modesetting > > drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +- > drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 70 ++++++++++++++++++++- > drivers/gpu/drm/sun4i/sun8i_mixer.h | 20 ++++++ > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 85 +++---------------------- > drivers/gpu/drm/sun4i/sun8i_ui_layer.h | 20 ++---- > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 86 +++----------------------- > drivers/gpu/drm/sun4i/sun8i_vi_layer.h | 20 ++---- > drivers/gpu/drm/sun4i/sunxi_engine.h | 13 +++- > 9 files changed, 125 insertions(+), 195 deletions(-) > > -- > 2.44.0 >