Received-SPF: pass (google.com: domain of linux-kernel+bounces-151484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 19 Apr 2024 21:35:18 +0800
From: Chao Gao <chao.gao@intel.com>
To: Xin Li <xin3.li@intel.com>
CC: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<seanjc@google.com>, <pbonzini@redhat.com>, <corbet@lwn.net>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
	<shuah@kernel.org>, <vkuznets@redhat.com>, <peterz@infradead.org>,
	<ravi.v.shankar@intel.com>, <xin@zytor.com>
Subject: Re: [PATCH v2 07/25] KVM: VMX: Set intercept for FRED MSRs
Message-ID: <ZiJzFsoHR41Sd8lE@chao-email>
References: <20240207172646.3981-1-xin3.li@intel.com>
 <20240207172646.3981-8-xin3.li@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240207172646.3981-8-xin3.li@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XjeIc/nOl42JLJQEANKULSpDtZsPHcfOZYADUbbIg7GIPg4MRM/16uYwYtzT?=
 =?us-ascii?Q?IT1aRAK9pgzARLN1Y+kF1mBeY0NGMf6Nwf/Q8OKvn//FxFEPF0z0Cwav5bWG?=
 =?us-ascii?Q?GFdzSfQm96AM9S2H4yvPvJMIPImYaMtcV09j/iIyU9ORbQXp0JBLWV2OJ9co?=
 =?us-ascii?Q?0hscreJ0kpxKz3sOZuj3iBK9vBpiZjgu82Y2F1jt2pHljbKKZJJMIblVhQsG?=
 =?us-ascii?Q?x4u0D86lWZ96cVO+uXB/yDzhD7p0YeY6YLmWoDoXO0n5Xf+XO9czKPOC7KGs?=
 =?us-ascii?Q?Nf/w9Da4cX05UqwcuH8B/OXYupAcFDxAttcvOsI3Q3n5zBXntdtHxSPVC/0O?=
 =?us-ascii?Q?NJvqPrgcq8QLXmCyYJzLNmAl7oDIO03JvxRu5565eWpoRDgAu2n6XjrBWcXP?=
 =?us-ascii?Q?PkmZ0TeVo7Go0uv/FjUlGyp8s/DLVQrPVfvV7EKwOwhaRbmhnwJ9QBliBD2d?=
 =?us-ascii?Q?Vc1Hml2I7JrQqDSn5lu7GuhxdKRVAz+7XM8m/jEgwwRbfg0d4+Sv5QuFJXQC?=
 =?us-ascii?Q?6RRhbNM3iOTp84isSjnTnwt03PJEls8rcNaK5+nYLrQuA9zndWTAGjXVPTXD?=
 =?us-ascii?Q?ItAcIfcfKzQQ98es7xEdCgZvXBnOkSBO/bO+eFXf0M1yeMDDzlP/RrXh2fJe?=
 =?us-ascii?Q?++IkcMXPmPjZ8JAUxl9SrXTzFLEIBaeQ0qbUgZnnBUfE0ttSC4UPRSxzthHC?=
 =?us-ascii?Q?9g51KEDHMMOwFAmGW2xB1G6Eb8UPkZ1V47yKOaqtWNaSTBKdgDw1cQQKILLq?=
 =?us-ascii?Q?A+A5x8TFPD0ZE47V3mnYIbmmpeWBkz6W8reaCbiA9EHLk5jkuuBT4OreFBYI?=
 =?us-ascii?Q?7hl6YB2IChsho/dO968vc3pfg00LGLPITIfpKQm+Mfv9jW8JD4gMaNzi9M1+?=
 =?us-ascii?Q?TSIAxw98Bo4yMErs9WhPuL4kMpE/wNLHWgXxPiRpOHeAOiVFM2OaBq1O4N9D?=
 =?us-ascii?Q?Xrord3wUUJntmU7YsW/OByYhm0LzoyZjWOaN+I74LLOreL5+aopKuDyBzv/y?=
 =?us-ascii?Q?OV4UiNmUOwpOBh/X4BHX+E4W4eQl1X9T9bT7YUHCGlRZD0f1PAB+oq0oe0BT?=
 =?us-ascii?Q?YWI+OZ1knI/mmwTuLARZZFP07pU4bWvn4D5R475I1IvV5KHaQDqtcFkX2j4D?=
 =?us-ascii?Q?NmQQ8OFzgL5iNTefHUas+HZI96sx2pBo5o/rQ+IRYMnWubhpTSFQmtTs1sQQ?=
 =?us-ascii?Q?mi17Wim5GyIFfR9Ze0j1sjg4Og9ryVH1RPQctdHDwzHd6Lf5LmNoeNgtQ0U3?=
 =?us-ascii?Q?Nvg3FC2WgW4tIcj1f5t1HSM64U4I894gkG50ditN1jDfeSu5dfIaRU0QvV3F?=
 =?us-ascii?Q?PA7+O7pUu6nOYEmA6rOxuVH8yqOXfXrr9Xzs4WL5PR1mFr0SHvTNh81oazox?=
 =?us-ascii?Q?2NaGb9toQlFeDlQm+p6uBVvRTkCZwa3pTfZWGqIaiC0iVG8hwI421ffbcDjx?=
 =?us-ascii?Q?nPW9euoVf5eSpFFCzVxcQQFB7dDtVI6Z9MFbiYoH6q+V+7INNGhh1B1xhlGq?=
 =?us-ascii?Q?pnIwO6D2XAHuHBMClGGQksvWU7tqwS5kw8Szb1bCSkKWrI+4MFXk+nFr1h7Z?=
 =?us-ascii?Q?Dmx0bJdVowjsPmbK55zz8/BpsUpWhAZiKQldvx1M?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54e707e4-8fd7-4363-77da-08dc6075938a
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 13:35:28.4115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0o3HKwfTGGCpujbHvIApQRwktDAU+SPwhJ+fzZ2w75xqsLHnP8LKwUW6aftr1TeDAQEXj4NY0dcKk2Oux3VXKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8099
X-OriginatorOrg: intel.com

On Wed, Feb 07, 2024 at 09:26:27AM -0800, Xin Li wrote:
>Add FRED MSRs to the valid passthrough MSR list and set FRED MSRs intercept
>based on FRED enumeration.
>
>Signed-off-by: Xin Li <xin3.li@intel.com>
>Tested-by: Shan Kang <shan.kang@intel.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>

two nits below.

>---
>
>Change since v1:
>* Enable FRED MSRs intercept if FRED is no longer enumerated in CPUID
>  (Chao Gao).
>---
> arch/x86/kvm/vmx/vmx.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index 34b6676f60d8..d58ed2d3d379 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -693,6 +693,9 @@ static bool is_valid_passthrough_msr(u32 msr)
> 	case MSR_LBR_CORE_TO ... MSR_LBR_CORE_TO + 8:
> 		/* LBR MSRs. These are handled in vmx_update_intercept_for_lbr_msrs() */
> 		return true;
>+	case MSR_IA32_FRED_RSP0 ... MSR_IA32_FRED_CONFIG:
>+		/* FRED MSRs should be passthrough to FRED guests only */

This comment sounds weird. It sounds like the code will be something like:
		if guest supports FRED
			return true
		else
			return false

how about "FRED MSRs are pass-thru'd to guests which enumerate FRED"?

Or to align with above comment for LBR MSRs, just say

/* FRED MSRs. These are handled in vmx_vcpu_config_fred_after_set_cpuid() */

>+		return true;
> 	}
> 
> 	r = possible_passthrough_msr_slot(msr) != -ENOENT;
>@@ -7774,10 +7777,12 @@ static void update_intel_pt_cfg(struct kvm_vcpu *vcpu)
> static void vmx_vcpu_config_fred_after_set_cpuid(struct kvm_vcpu *vcpu)
> {
> 	struct vcpu_vmx *vmx = to_vmx(vcpu);
>+	bool fred_enumerated;
> 
> 	kvm_governed_feature_check_and_set(vcpu, X86_FEATURE_FRED);
>+	fred_enumerated = guest_can_use(vcpu, X86_FEATURE_FRED);
> 
>-	if (guest_can_use(vcpu, X86_FEATURE_FRED)) {
>+	if (fred_enumerated) {
> 		vm_entry_controls_setbit(vmx, VM_ENTRY_LOAD_IA32_FRED);
> 		secondary_vm_exit_controls_setbit(vmx,
> 						  SECONDARY_VM_EXIT_SAVE_IA32_FRED |
>@@ -7788,6 +7793,16 @@ static void vmx_vcpu_config_fred_after_set_cpuid(struct kvm_vcpu *vcpu)
> 						    SECONDARY_VM_EXIT_SAVE_IA32_FRED |
> 						    SECONDARY_VM_EXIT_LOAD_IA32_FRED);
> 	}
>+
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP0, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP1, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP2, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_RSP3, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_STKLVLS, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_SSP1, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_SSP2, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_SSP3, MSR_TYPE_RW, !fred_enumerated);
>+	vmx_set_intercept_for_msr(vcpu, MSR_IA32_FRED_CONFIG, MSR_TYPE_RW, !fred_enumerated);

Use a for-loop here? e.g., 
	for (i = MSR_IA32_FRED_RSP0; i <= MSR_IA32_FRED_CONFIG; i++)
> }
> 
> static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
>-- 
>2.43.0
>
>