Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp657369lqt; Fri, 19 Apr 2024 06:55:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVrc/QxNztvpDO3KnTnUdHyL0Yv8Z+LuKkiDJSbseMD6uXt2p9eOCUAb06snTTs9agchUpD3MRHEFfQco1KxIApCowIcwDZaDlETzPQBw== X-Google-Smtp-Source: AGHT+IEgHy52CcthbYbVJfQvBPuvaide1UHlgLM0f9G7+RDLsrqYT713kHLbhCf2J8jfvy9FaGa4 X-Received: by 2002:a17:90a:4982:b0:29f:ac52:9ae2 with SMTP id d2-20020a17090a498200b0029fac529ae2mr2162559pjh.42.1713534939709; Fri, 19 Apr 2024 06:55:39 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u10-20020a17090abb0a00b0029c74a38c69si5039763pjr.168.2024.04.19.06.55.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 06:55:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=YNvexn1h; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-151491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151491-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 66D07B21383 for ; Fri, 19 Apr 2024 13:41:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD9F712AAEB; Fri, 19 Apr 2024 13:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YNvexn1h" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0ABD1292DC; Fri, 19 Apr 2024 13:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713534108; cv=none; b=M24e4TzJ4++OJOyGbvdQwPWOqF97ANLVnTIYhFzWzKc/5oA9NiTpdli1FjVawnph55acI0sBICIH/aP6SnqzO3KlKeofN2D171LWm/AC3c+iXVuiGzH669GZMHf2VTDrubk0f/BSu4gzmza0L3sxwuIqSVgBpDuakrELoWE01/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713534108; c=relaxed/simple; bh=YWtwWwFaBIA9VlLC/ZdB22WXXGjlkyXLSpJuWuzctw4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nlOxfXAehkEOJEdGiuq/AFRXHIpasC178XFp6yf4oA+fIdv2R50Baz+aozQ4nyQtg/amTVPSdrWU6baSd/xoUGOIsZwLpujPrJfEsjKXG5m03F9M6Sarzaco/Ji/Q9bzmUEr6DBfzbITT59sShXQcge7j7uB+ONO/ZP7zJT2bA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YNvexn1h; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55215C072AA; Fri, 19 Apr 2024 13:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713534108; bh=YWtwWwFaBIA9VlLC/ZdB22WXXGjlkyXLSpJuWuzctw4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YNvexn1hyeCUgjOFwOrH6x4neJZeusd80IyEHjrXYC5693cH6khvm4zOxu/4cK64A yg0NkIEAeg8E+XV1kHQrucaj0eDLqedTtWOH2JS0MmqCblQWBiQkR4ogIwro7QyF3b KbUF/vQvFNokmVcfg+A1LxggZ5niZkCI5IhC1HbTFc5rvQsPN1JoXWpOzZn+LjziJz 2cQ5ozqd1PUoYcdahN7SfmlSbCdgQl+8BugDl2Ib4Nwm8qrAw4u65e8rzKH/LTxfJB /wcTVmMocK+SFcWKvCZBCKFrSfWIhmYpN1Zws1YesfhXgKFrUHZw9mUa/EuYHON7Y5 RfD024kVBMw3w== Message-ID: Date: Fri, 19 Apr 2024 15:41:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] regulator: pca9450: enable restart handler for I2C operation To: Holger Assmann , lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, yibin.gong@nxp.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240419083104.3329252-1-h.assmann@pengutronix.de> <20240419083104.3329252-2-h.assmann@pengutronix.de> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240419083104.3329252-2-h.assmann@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/04/2024 10:31, Holger Assmann wrote: > The NXP PCA9450 can perform various kinds of power cycles when triggered > by I2C-command. > We therefore make this functionality accessible by introducing a > respective restart handler. It will be used after a priority has been > defined within the devicetree. > .. > + > static int pca9450_i2c_probe(struct i2c_client *i2c) > { > enum pca9450_chip_type type = (unsigned int)(uintptr_t) > @@ -845,12 +875,35 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) > return PTR_ERR(pca9450->sd_vsel_gpio); > } > > + /* Register I2C restart handler if one is defined by device tree */ > + if (!of_property_read_u32(i2c->dev.of_node, "priority", > + &pca9450->restart_handler.priority)) { Priority property does not define whether this is or is not restart handler. In case of missing priority, you should use just default: SYS_OFF_PRIO_DEFAULT. Not skip the registering. Best regards, Krzysztof