Received-SPF: pass (google.com: domain of linux-kernel+bounces-151526-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240418121249.42380-1-Jason@zx2c4.com> <20240418121249.42380-4-Jason@zx2c4.com>
 <e4cbb6ab-975a-4d91-9bde-6976b4d84eba@amazon.co.uk>
In-Reply-To: <e4cbb6ab-975a-4d91-9bde-6976b4d84eba@amazon.co.uk>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Fri, 19 Apr 2024 16:02:01 +0200
Message-ID: <CAHmME9r8+ULD74ehz-LOpuAXb57BDFCD9Gr3Aw-JPJfTLC5OCw@mail.gmail.com>
Subject: Re: [PATCH v7 3/3] virt: vmgenid: add support for devicetree bindings
To: robh@kernel.org
Cc: tytso@mit.edu, krzk@kernel.org, "Landge, Sudan" <sudanl@amazon.co.uk>, 
	conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	sudanl@amazon.com, graf@amazon.com, dwmw@amazon.co.uk, 
	krzysztof.kozlowski@linaro.org, xmarcalx@amazon.co.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Rob,

On Fri, Apr 19, 2024 at 3:30=E2=80=AFPM Landge, Sudan <sudanl@amazon.co.uk>=
 wrote:
> >   config VMGENID
> >          tristate "Virtual Machine Generation ID driver"
> >          default y
> > -       depends on ACPI
> > +       depends on ACPI || OF
>
> Version 2 of the patches had these flag but were removed in version3
> following the below review comment from Rob:
> "One of those is pretty much always enabled, so it can probably be droppe=
d."
> reference :
> https://lore.kernel.org/lkml/CAL_JsqJoB5CYajWuntMdQrJZir+ZA-69Q0cwvxcVZAq=
s-mXC+Q@mail.gmail.com/

Are you sure about that? I see other drivers that depend on `ACPI ||
OF`, and this driver is totally useless without either disabled
(right?), so the dependency makes sense. I think? Not an expert in
this area, so I'm happy to defer to what you know is best, but I did
want to lightly pushback a bit.

Jason