Received-SPF: pass (google.com: domain of linux-kernel+bounces-151535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <852918ac-31a9-4924-a551-8b91de91b0e4@intel.com>
Date: Fri, 19 Apr 2024 22:01:47 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 02/18] mm/rmap: always inline anon/file rmap
 duplication of a single PTE
To: David Hildenbrand <david@redhat.com>, <linux-kernel@vger.kernel.org>
CC: <linux-mm@kvack.org>, <linux-doc@vger.kernel.org>,
	<cgroups@vger.kernel.org>, <linux-sh@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, Andrew
 Morton <akpm@linux-foundation.org>, "Matthew Wilcox (Oracle)"
	<willy@infradead.org>, Peter Xu <peterx@redhat.com>, Ryan Roberts
	<ryan.roberts@arm.com>, Yang Shi <shy828301@gmail.com>, Zi Yan
	<ziy@nvidia.com>, Jonathan Corbet <corbet@lwn.net>, Hugh Dickins
	<hughd@google.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker
	<dalias@libc.org>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Chris Zankel <chris@zankel.net>, Max Filippov <jcmvbkbc@gmail.com>, "Muchun
 Song" <muchun.song@linux.dev>, Miaohe Lin <linmiaohe@huawei.com>, "Naoya
 Horiguchi" <naoya.horiguchi@nec.com>, Richard Chang <richardycc@google.com>
References: <20240409192301.907377-1-david@redhat.com>
 <20240409192301.907377-3-david@redhat.com>
Content-Language: en-US
From: "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20240409192301.907377-3-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWpHYjRpbjNYVGF5RUFrSWVwLzl6UDk4amxQNzR1aWJMSTdqR3FKbXFBYXNh?=
 =?utf-8?B?UENwNHBTRTRNSkJVOWtUUFRVV0VtdDVvRDI5cmhZREdSS0F6eGpUbFQwSHVm?=
 =?utf-8?B?TWltSG9tR2VJY2xVWXhVdkpqamkyZXVGRUo1T1dLNFVXN1o1VktCakZiQTdD?=
 =?utf-8?B?S2h6a2dCYmxHSGVIN1BVYXR3VVN5dDdOU2x0U2ZhMHFxQTY5OFEyaEluRjZP?=
 =?utf-8?B?TWEyelFVWDBFSEZFN3g2aS9xWHJjeUszeXZnUkJhR2dCZEMxNnJyZ2NEVkYr?=
 =?utf-8?B?UVhMbWtsYm9KeEpwU2R6M0p1ZzE1cFFyTXl1ZHhXQUphQXJDZS9sV0pEYXJO?=
 =?utf-8?B?SmJBL0NjYkJ3dmQ0VXN4b1h3aVovbENta0JqejdxcHBaVVoyQ3l3TXE2WG1I?=
 =?utf-8?B?L21IS3MrTWZYYWQxb3NzTWFocllrVVVmTjErN3U3b0s1cWprWFFXeUpxci9n?=
 =?utf-8?B?SXpnT0oyMFZxcUJRcEIrU1A0VzNaYzU2b0pabnNGaVpNV3lGa3hyVnVjRjNs?=
 =?utf-8?B?M1B3bHBhT2o5R01IRFBnT1YxcHpJQ1ZIV3NRNk5NbjExYWRZTDEzM211Z3dM?=
 =?utf-8?B?MnhUb1dsL01hVWdaOE1tYlVPTnJtZjJQbEtKQk02SGVRT25nenk5azZjeWM5?=
 =?utf-8?B?ejd2Nnk3cmhCSnlaUnZIeHZCUTNSbUhOcmNqL25STUU1aXJEc1RJWnQzWlNr?=
 =?utf-8?B?elFhbGRyWER1VGNkRzU5U1FEY0lQbVVmSGFSbU1zeVdzK0FveGNUbHdvMDY4?=
 =?utf-8?B?SXJxWStvcC9TaEcybUgwbjZ4NmFMSFdwbkV3NHd4QVpYRjFsOXhDakJYY1B2?=
 =?utf-8?B?eU1LdzVGNkhkTXA2UFlMV1hqRThWMnZLODlwQnNHZ055WHUxN0pDemtUNmlm?=
 =?utf-8?B?bUszeUt5QWgyWForcitla2VKVnVOcUN5S0N4NVZGT0tsc0pkeVJIUlZ5R1My?=
 =?utf-8?B?UGNwYW1qaCtYaW1XUUFCajk3K0dCWng3WXNad1o1dVdtWVloNmVySDkyeUd1?=
 =?utf-8?B?UWg1czJEQStEdmhzYjdhb21oZTI2TUJheTJBNHpCRlQ5M0NoVExrZlU3c04z?=
 =?utf-8?B?Y3dFek9yZUpXU3d3V0xqZjJsNVVDZHZxRVBuaDFWQlpxazQvUzBmNGtlakY4?=
 =?utf-8?B?QVVhZTNqRlJjQmVXOTF5ak0wYlZXSjBzejljdnBOOGgwVElaVHZrYVc4MFNx?=
 =?utf-8?B?TGRtNXByQUsrWEtrcjhBMHZ6WGtjeHBMR242QXpSa09OdGRUcVljSGt0MWJ5?=
 =?utf-8?B?bFJSL1hxZDNFWHlOQWo1M1FvS1UwWDN5NG1BMW9DYkx5ZlRlV0JrWE8zam9t?=
 =?utf-8?B?MkFTcS83ZDFDaFQ4M3o1Vk42cnoxR0pGMTAza254WFo0Z25SQ09US0NHMWpU?=
 =?utf-8?B?ZW9nelhPbU9Zd0srR1BuTTFlVWg3WGc1TUZXMXdqUEtBcEg0VWE3QUdNaFBo?=
 =?utf-8?B?SEI5ZlZPc0sreU8zN0kzUExSL3A4MTl3ZTJiejVlUkErV1hOelBUY1dmMWFF?=
 =?utf-8?B?cFNDQlpRUmpKemRQSnAxRFl6VlIwVWN3QVhrN2tGOHk4Q0UvbjJkMnlOUTE4?=
 =?utf-8?B?OENuejduVTBwUkMzazFWeHVySWt1SWowc0dtOVNTc3lNVzVjM1NxelR4VHV3?=
 =?utf-8?B?UnVuZDFVL1d5cktsQk56Y3JiM2p2MzZYRHdqb2w3MjI2RDdBZEJERTBLL1FF?=
 =?utf-8?B?bnF3Mk1SM1VtNGxJRG1PTWI0MllzZ2pEV2c2MGsxaVJ0SXdyVmhCaVN6NXB0?=
 =?utf-8?B?dysvOGdmYVFxRlRRcnFHbU5CY2h6R2Y4NVdORmRTM3pkRHZTTHpnVndMWTJ4?=
 =?utf-8?B?b0F1R2R6K0EzemlVVDdVeE5XQUU3TFdqdEhQUjY3djlEaHBhMmV4L24zVVMz?=
 =?utf-8?B?MytEZWJsckpHOFNIZ0xzeG1XaFlFV0JKY29XVVlGQlhjQm50L2lmRXdrWUdq?=
 =?utf-8?B?UFhIT2QxNVFhZHQzMFdlaERxZE1kZm5odExWU2Fla3VxM0FNVGFCYU9MZnlN?=
 =?utf-8?B?Vk9zeW9qdTc2ZlVjY20rN0daOFZ3NGhDaE5FeTl2MEF0bVVDVXFNdGx1cDFW?=
 =?utf-8?B?b0ttT0xiRFJyODV1SlpyL0s4L29xc0R0Nm1hS05sSkFyTUdJSkROZjNmbis2?=
 =?utf-8?B?WEcxOS9NVWpqRGdFY1BXRmhyMHZnUWVva0pVUmd4eDhYYWtZS1Q3M0hlbkdK?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fb88c039-2d90-4c9a-ef4f-08dc607947dd
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 14:01:59.5471
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rs3ePm46BdHvVcenJPebi/WbaaHzDrl6IKabEmZznFFzC8uZgO/cFj20RZGnnwMsMkRwYi0A4ESCUAfIU20/ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6730
X-OriginatorOrg: intel.com


On 4/10/2024 3:22 AM, David Hildenbrand wrote:
> As we grow the code, the compiler might make stupid decisions and
> unnecessarily degrade fork() performance. Let's make sure to always inline
> functions that operate on a single PTE so the compiler will always
> optimize out the loop and avoid a function call.
> 
> This is a preparation for maintining a total mapcount for large folios.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>