Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp673354lqt; Fri, 19 Apr 2024 07:17:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUAIubbkJHqrUJTvTkEdWzWg9vi8Fd+q8qowYjCnsnYiua2UZkKmwx7sw+MkIB25sqgpq8UTjn2KYro8MAoQ3GftfW9SegMagsXzAKATA== X-Google-Smtp-Source: AGHT+IFOD75i4Xo+Gd16UPjrNHcs5Tz9bp5nQYOK2DHzSDUzYjryZuhhzCMKSXqmGCxQyUDTpzGV X-Received: by 2002:a05:6a21:6d83:b0:1a7:68bf:6eba with SMTP id wl3-20020a056a216d8300b001a768bf6ebamr2852434pzb.42.1713536265037; Fri, 19 Apr 2024 07:17:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713536265; cv=pass; d=google.com; s=arc-20160816; b=0jxOw2CdoTrdkmXdxuk8E9GpLvqMGl4kWHwA0NgU3WPVF0FbzdHNmAc9JlyfTPqCjE enKXvLCJAl/alG7DirvC8me6GCT15kE/lBInlfTdZlsFHeoOaApoOtMWAybju+50A7Yv uvdslvnhHpE3kESFITXiEAO4FyWdyks0wsoRFZ3GHuOiEStEkwofjsVIa6T2zabWNmdq bLu9e8ePDFwvC6g3xolFfPacuW9HR7PDu6M0lvFImaNe70hyF4IQUjC30PAHYuE6+1VV qbatTbH6ms/dEi8/XlQ3TacsdgscnD4ZBBu7R+bWt8eAxZ7LIF7rRMb2S8NBLeKTNAHN cv0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HRYEfTZmLXj+D60Algfz1aIldDy/MDscqh+Le/BywI8=; fh=KlAqJY118nQbThd+aD60uqPgPio1O5K66t0SP96nav4=; b=niCVKJn95F+aUak9qn2PcZ+kkPK1HRI0/A2Y3jzJV9Du3j3ugbUlvkLOzoYSGOiVuc Z0nMNA/HYk9hI2JAGOj5lW6hHEMo9xRKFKvwZ1LfdcZB+TSKaB/b7imUo8X+nf68gsAA UPKazZO7NUllAn1Ra4qfamD8FkQwXbA0ji3PiaGG2W0BnRWnyfigu0qC9EJvZNNXPtmi X1KnjSO/Hk9OQx5xgctMbVSKCyOFZ1XZH3qqULlzVhiXjd3C5Zt+cOwzWRCXe6UEOmqe M1VBGkg1bxnFXaJcLNt+x83RuibIU38pbKDlGo3rv2CQCCPnmcj4HA6Ro8fNxd2MVZLM Y6dA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VS9F9Aml; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-151541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151541-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x9-20020a17090a164900b002a2341b88fbsi5074440pje.64.2024.04.19.07.17.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 07:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VS9F9Aml; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-151541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151541-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BD074B2590F for ; Fri, 19 Apr 2024 14:08:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA800137778; Fri, 19 Apr 2024 14:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VS9F9Aml" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CA9A136E03; Fri, 19 Apr 2024 14:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713535450; cv=none; b=EcS9v+VG7ice2YGff84c9ex+6o0Eeq2XWMUWjHuzS0wWkU2CfFQUoD1kvk7pzwIBzblu4JuURwT5yb5tqF1vAHoe1FXl2AKxN6Txel4TEvgNL82UymU3mA9yKQmXVMcAqRRIk9Ei3NiO4vYqWJmqGGQB+5a35sZ4WrUpj1HsFGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713535450; c=relaxed/simple; bh=zd4B2k2WaVQRixz1Zz7N9Fik5Yjb6pyjzhJ5NlvMHZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GDHmyTfMCCAODVPFXbQnoM1mPYcCUBW26jhdB8I1qjXt+t5hhFjS//wmUsvhBlCM4VJOru0Dm3W6uaL5+t0ls3XSulQdvV5YwRPOstqPvY7iz8CcDsS7A2o7ZKQYaG+V8OYR+8ovI/QYOimiG6SF530l2K/WJaSX5WTTS4ln7ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VS9F9Aml; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F1DC32781; Fri, 19 Apr 2024 14:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713535449; bh=zd4B2k2WaVQRixz1Zz7N9Fik5Yjb6pyjzhJ5NlvMHZ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VS9F9AmlyXURr86YUdWYb7QN54sEF+o9/HopbQ4zfMb5YwPOAncRA6X6L4yQm8A2j 9YHZPcyknj2LuFKdbF4qqLu9FEW9kN2n9SX1EBn6ftAmfEWi3Z+C7xmjhUWcE3iye3 okShGGuMa+cG/4TfFhmZOH93RJzKObNz8g7O1dPQ= Date: Fri, 19 Apr 2024 16:04:03 +0200 From: Greg Kroah-Hartman To: Wander Lairson Costa Cc: Brendan Higgins , David Gow , Rae Moar , Matti Vaittinen , Shuah Khan , Maxime Ripard , "open list:KERNEL UNIT TESTING FRAMEWORK (KUnit)" , "open list:KERNEL UNIT TESTING FRAMEWORK (KUnit)" , open list Subject: Re: [PATCH v4 1/2] kunit: unregister the device on error Message-ID: <2024041955-strangely-snack-b335@gregkh> References: <20240419132504.9488-1-wander@redhat.com> <20240419132504.9488-2-wander@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419132504.9488-2-wander@redhat.com> On Fri, Apr 19, 2024 at 10:25:01AM -0300, Wander Lairson Costa wrote: > kunit_init_device() should unregister the device on bus register error, > but mistakenly it tries to unregister the bus. > > Unregister the device instead of the bus. > > Signed-off-by: Wander Lairson Costa > Fixes: d03c720e03bd ("kunit: Add APIs for managing devices") Reviewed-by: Greg Kroah-Hartman