Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp676666lqt; Fri, 19 Apr 2024 07:22:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW1VElJo7DQ9uVVXYEC6uwDzpe0/xOokN7+JRZfIOi7WKMQ/JX7NCywL58xvtt0ZNUT/hb8sq1zEvJWNezkHjJonqvOMAexM4MEv6P7Zg== X-Google-Smtp-Source: AGHT+IGBKfRK63ixBbSzhaYrtkSMA16ocHOFNMnArGvYdot1s9zSW8ZFLyvg6KDI5pVYZxlsL3Uz X-Received: by 2002:a19:6445:0:b0:518:b144:9020 with SMTP id b5-20020a196445000000b00518b1449020mr1538986lfj.61.1713536571709; Fri, 19 Apr 2024 07:22:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713536571; cv=pass; d=google.com; s=arc-20160816; b=ZCBSqGCoNcjUT2Z2VrAMpCewK1xKqKy83B8V632JMrvfOdUi8idP8WVXjpO6RMfHJx in5LNLXuaYzudG6Z/h28TvWOtlFv4WDL9dh5cuKue3U/TxhICpAek0rJSae45Nhv4zTs dngtPhU2Q6keb9zloHK012Ewg32h34TJmA6qQzICd3lZDKVzvlVGWLtML8ffX58gHHOH 1t5+kDDnt0v7aT06OFFRK7BvZIp8qJsUZ7bBmnDYi7yeXjGa0RUVnnVaxOCWiF1Tu9J/ xzyVrLdOCBGtLXoNpSpksdJ8CfHCfYjYHFNxsdo1pLa1GvBwckdhrJBrHlBCS3lOYvB3 iZCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=T+y7+J2wbn+FxsaSDNsiBBdtQp+H6naiE2HcMJYbVmU=; fh=SAvl1c1Dd4ZRId14XFxaiOszWCNp0kJVXITxcM3assA=; b=I/qFbahtt03VfEp5vVRpxm9RDFtB7wiyhyO+2ZYV168083bduJzu8siATyzXo8aZMs 59NPsSzlnatz8EtdoJneusNcFc81GT9Usvfhq/A2C081mhV1k9OgMAoi+Ch7sRgG1sxU GLxGcGUARSlA/f4veADV/k2q2Xcuhgl1+sskAONNg8Ki5NDNi8YxUG0VybDYtPyw1Gp/ fhqfvtaPrhravOpU/vUQyvbd84H6ukEafYEOwXaFwPcVK2bxsKZnNhr3L/oKH4NzSEOw R8DmocZFz+QyjGS3bC2lSzMr8PHQdZG6l5dfTyaGimFxM6mTVj1o1bv5K6liu34+iHhs APLQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=WErG7uO4; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-151558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151558-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z21-20020a170906241500b00a555ba222c2si2175890eja.966.2024.04.19.07.22.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 07:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=WErG7uO4; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-151558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151558-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 74B3F1F26094 for ; Fri, 19 Apr 2024 14:14:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8610212DD97; Fri, 19 Apr 2024 14:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WErG7uO4" Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E42B8063B; Fri, 19 Apr 2024 14:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713535986; cv=none; b=N9URmrAYdJ6z+w0awMI6aoPjXidhVPy4bCi/aF6KLSMn0a6lgZKJhtQvkmoUsYNMA7KFnND4Ljl4u5zHNIUmAM47mSDD2ngyFuvzMFENUKIZPjg44Rp8EKQ/GoB0Tzg3GCDlN0KsXVJ1PyaVWfYEOFqiYSYD7opkogzle03PvIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713535986; c=relaxed/simple; bh=T+y7+J2wbn+FxsaSDNsiBBdtQp+H6naiE2HcMJYbVmU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mzQlYf33BpgZkXJlN6nVQwXvEfyKKMYRIZtxF81Y0Pka6uijSkTYC+okfTA5927CfqPMHwMAQl3QMxkZE+ufobPEFlRNZ4NL2mP3tedepJ71S7Y2IOFBR566XDRqmzjwPscBvmcMiCwiLClDj4QXDN+QqLLNyjAzt62RnhGCJ6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WErG7uO4; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a51ddc783e3so250409666b.0; Fri, 19 Apr 2024 07:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713535983; x=1714140783; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T+y7+J2wbn+FxsaSDNsiBBdtQp+H6naiE2HcMJYbVmU=; b=WErG7uO4+1L7iGNI6nvRzREQCNG+T5NLkYMxJseCiYOw2ZmdIU+QEvN9NyIiKVZx7s 0h3guF2iVvTjruNShJCW1xcBwYXpC6BZToGHlrHSEtbdzx5J/EvwDqu/Z26Vua0TJw7g llt6u23X5HxBHy8T5PwtWEvD0iPzh88XM+dwAHn8+0fGEuUjB2p6HR1dCTtcK87ZKbh/ XlxBHdhr2iwijCJao9nGuW1avRPkTn1xD4WY/JIsg8mZvbEzTEP6fAkdMK+zeda/lDj7 GRCIJMZU0ADB7LCBTqqh2J2Cr2VsN/z9phLYeLvZrrF/w5vkaRB3H/ca1oXvIAzvXttR tUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713535983; x=1714140783; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T+y7+J2wbn+FxsaSDNsiBBdtQp+H6naiE2HcMJYbVmU=; b=YObGgs+piIufwC9dlw1issluv14TorfXpfPhXdNx0ywgsHH0B/ZrvmeAWIJXHs9NSX l/P2lSJubjD6Nanr2QBc1lwsfaYBH3CbJ/JJzbr/qS0KhNab4xtMjKAEcq3dha8F6DNL UmMX8XHhiGyuSJuU8dth+dOVaRjo1/GqqKHixxo7oQPvvp3DzuKo8U5/n0RLNZ4Hc9oH h2IsHDRa2+AqDsqvf1XIrjBnsiji3WoGwy+mCekOon+DJVNMKw6z+B0GryD7bW7+wXjF ldOfqLRD7FljLjOMnQ5tsEgcUr9VAEhq64cYannVXAe79FF17KtQdHx3/M39HerFMBFo xh4A== X-Forwarded-Encrypted: i=1; AJvYcCVnxTC0JRHBu4JxHz5upAcOEj8BTg2CN/wrwEDZEBBkSJYhbdR/Yvpi0LrpqEVjQshy9n7xSFkq3ljRSq+LuQaOMWTTm+tL+J+NMaI5Hpo2nM5KPQOnJKpiy87HDexD5I1bZQ5ceEacRXBwcoDe X-Gm-Message-State: AOJu0YzU/AUgJ5UqE1sIsWlgKbe06IKPr9LfecpsHaHW4owOAE/lGfFR IBUeNAbouhCNGdgGj0OB+0UDR964mHYe1XvaG1caXYx37JvbfOayyAcNLLYBDl8FFuunMOoZCGp zlg0GFaJrc/yZV/PLGMAI1ogeXmQ= X-Received: by 2002:a17:906:3bd4:b0:a55:8efa:2129 with SMTP id v20-20020a1709063bd400b00a558efa2129mr555147ejf.52.1713535983460; Fri, 19 Apr 2024 07:13:03 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240419140017.work.012-kees@kernel.org> In-Reply-To: <20240419140017.work.012-kees@kernel.org> From: Andy Shevchenko Date: Fri, 19 Apr 2024 17:12:26 +0300 Message-ID: Subject: Re: [PATCH 0/5] string: Merge separate tests into string_kunit.c To: Kees Cook Cc: Andy Shevchenko , Ivan Orlov , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 5:02=E2=80=AFPM Kees Cook w= rote: > > Hi, > > We have a few lone function tests (strscpy and strcat) that are better > collected into the common string_kunit.c test suite. Perform various > renamings, merge everything, and clean up after them. All makes sense to me, thanks for doing this! Reviewed-by: Andy Shevchenko --=20 With Best Regards, Andy Shevchenko