Received-SPF: pass (google.com: domain of linux-kernel+bounces-151578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Apr 2024 22:23:02 +0800
From: Chao Gao <chao.gao@intel.com>
To: Xin Li <xin3.li@intel.com>
CC: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<seanjc@google.com>, <pbonzini@redhat.com>, <corbet@lwn.net>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
	<shuah@kernel.org>, <vkuznets@redhat.com>, <peterz@infradead.org>,
	<ravi.v.shankar@intel.com>, <xin@zytor.com>
Subject: Re: [PATCH v2 09/25] KVM: VMX: Switch FRED RSP0 between host and
 guest
Message-ID: <ZiJ+RkHDJzalqN05@chao-email>
References: <20240207172646.3981-1-xin3.li@intel.com>
 <20240207172646.3981-10-xin3.li@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240207172646.3981-10-xin3.li@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hh54OvC5sfi6XgVpwMwUWvHc9vsfnPtsNezF5XX1JpBYpeT8ocYhRQtU/7F5?=
 =?us-ascii?Q?aXDtAfEFbREzwWzxVTX63BZmiQ0DptL00XUhv/ZSvVyzTWctsFdwHgJu5+fI?=
 =?us-ascii?Q?okYttAEa6D/L90deWN9am/v0hGuFkSjV4yT3p91qoVMKfpdVsGTSdsoJbBkG?=
 =?us-ascii?Q?XHW8hQ9CT2BFNID9bS2Y049q+NR9c6Vo3e/x2i3eSamhK/+dKsx+HE+teW8Q?=
 =?us-ascii?Q?7wDGS3PnNQ5r7i54J2PEtvOvzppMp9hcsICFLsNKMTMe7kh6Bgdu3nTmVbhS?=
 =?us-ascii?Q?jeYYHQsDXIDSfUWZGMx5pSHcfu44YwncFvlxYqazv8IDRacSDnz9MWsIHm51?=
 =?us-ascii?Q?o75GB1HzZChLGhMFJmTMJKwSLHtDfqbuYdXSmQGJy1ZJ1g3Un1Irh9w0T6EZ?=
 =?us-ascii?Q?K3bSJvO8EYW02iOJy5uUq35lZRQf2e89Qy6MgTy1d5cM+Cq1TWF7nOevhbNH?=
 =?us-ascii?Q?F4iPTexGTe8IKO1X8OnUBKOiJ1NxnlLz8AELWCvRJtN+weW4bEzBANlt/S9y?=
 =?us-ascii?Q?pLr11tITtBzoKHXbaFvWxUrPeibKtvkIDmoiwZKwJF7033tSNn0nZCw3DVIc?=
 =?us-ascii?Q?Ku2eGtjHq2/1xp/3pDPkCHv2qpkwvuE3blCi3pF99W3mQWpe3zrW2kmClynK?=
 =?us-ascii?Q?fcNmpMtd5xNUeZEVKmRDHIGa6NQjufbA6HkkGvWBvaIzab8PVismj1S6NABj?=
 =?us-ascii?Q?akiA0cs2G7PvKcQDHVblQkMHSPUWjZTWve0onz5BhZhbOBrcNoCC89NbXdWc?=
 =?us-ascii?Q?oBUiwxuRoGVu8Guu5iIYYcPvwFXnrzX5QlUmc7Gm4nSwGBzw51sVs90wZwEf?=
 =?us-ascii?Q?jrmIe+IShaX1iqkt4wTIUXc/XQN5R9JI1bD0IxHFMkUbZQXeMyzyTqOSwV8b?=
 =?us-ascii?Q?dcDweZCrEXLINV73E6Diy8xOfKyR9vOU5dfy1iNx18yEXHmrx4hrQchUjsiM?=
 =?us-ascii?Q?Dqv7kwDO4Suh/tnw1P0RxnMSYDKirGrXkBr7WRnEVAAL5+ZSsOdaJ1I9GIj/?=
 =?us-ascii?Q?VX4nWqq78kyX8NvbSBibhZ2VayHJ1j62v8fSHwY0cdGOOZe0j8WFoS2Xf+u0?=
 =?us-ascii?Q?2PHa1OEVbEFBrw+E/uCqyIfjT6xPPK/3rZV76UkWAIxUnkS2vc80k/IAzyw2?=
 =?us-ascii?Q?3ovK7nF0oHMEfOEsnCSwxQEB8IrlTFyQY279QG+t0LhtmqV/XVLaeS+yJZpp?=
 =?us-ascii?Q?FsOl5SXdt3WRjWDfHs+rpz22DgNbylNg7aS2WpXCzJD3xbwc3v6YxToncAXa?=
 =?us-ascii?Q?5UFwqGakNJoEQ7hJPptopzOj8zGMNLQGGEQdltVZyKcAIf/BWT7Guj/2B2fi?=
 =?us-ascii?Q?9BZX8Y6pCfX7tHR14It2pZjptclZdS0+XGdwwV6YtN1llB1pZEUtNps7YAbd?=
 =?us-ascii?Q?TGWID0sxc5ymqL8FtPVi1uTv3tKljr7kwChDsuhVEpcBg8PJq8hacqY1/A7Q?=
 =?us-ascii?Q?/2Iux8Mf17qtMuXQ6i+vOnSSH69VMCCE8lSkd6p/W3oK4HaLp9Rdk01TQ+uM?=
 =?us-ascii?Q?0FukJGHsMSb00wxFQAGibYElqcG921v1q0CPe6o0Cr8G4NKGiRWlsD7QTrBm?=
 =?us-ascii?Q?TWLwrwYBRE6X1arouxHPA6unGlh1q8Rynii9uM9w?=
X-MS-Exchange-CrossTenant-Network-Message-Id: afc8f0bb-fec9-446b-f706-08dc607c3f22
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 14:23:13.4679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sq8iKgDyYpdNTshhcq/kn74YRCwAiC4Gj2JSGSibAYdKklNvVhpPLq5PFdEzaZUCl85za5ioj69XQ1+ngOj8bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7627
X-OriginatorOrg: intel.com

On Wed, Feb 07, 2024 at 09:26:29AM -0800, Xin Li wrote:
>Switch MSR_IA32_FRED_RSP0 between host and guest in
>vmx_prepare_switch_to_{host,guest}().
>
>MSR_IA32_FRED_RSP0 is used during ring 3 event delivery only, thus
>KVM, running on ring 0, can run safely with guest FRED RSP0, i.e.,
>no need to switch between host/guest FRED RSP0 during VM entry and
>exit.
>
>KVM should switch to host FRED RSP0 before returning to user level,
>and switch to guest FRED RSP0 before entering guest mode.
>
>Signed-off-by: Xin Li <xin3.li@intel.com>
>Tested-by: Shan Kang <shan.kang@intel.com>
>---
>
>Changes since v1:
>* Don't use guest_cpuid_has() in vmx_prepare_switch_to_{host,guest}(),
>  which are called from IRQ-disabled context (Chao Gao).
>* Reset msr_guest_fred_rsp0 in __vmx_vcpu_reset() (Chao Gao).
>---
> arch/x86/kvm/vmx/vmx.c | 17 +++++++++++++++++
> arch/x86/kvm/vmx/vmx.h |  2 ++
> 2 files changed, 19 insertions(+)
>
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index b7b772183ee4..264378c3b784 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -1337,6 +1337,16 @@ void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
> 	}
> 
> 	wrmsrl(MSR_KERNEL_GS_BASE, vmx->msr_guest_kernel_gs_base);
>+
>+	if (guest_can_use(vcpu, X86_FEATURE_FRED)) {
>+		/*
>+		 * MSR_IA32_FRED_RSP0 is top of task stack, which never changes.
>+		 * Thus it should be initialized only once.
>+		 */
>+		if (unlikely(vmx->msr_host_fred_rsp0 == 0))
>+			vmx->msr_host_fred_rsp0 = read_msr(MSR_IA32_FRED_RSP0);

can we just drop this and use "(unsigned long)task_stack_page(current) + THREAD_SIZE"
as host fred rsp0?

>+		wrmsrl(MSR_IA32_FRED_RSP0, vmx->msr_guest_fred_rsp0);

any reason to not use wrmsrns?

>+	}
> #else
> 	savesegment(fs, fs_sel);
> 	savesegment(gs, gs_sel);
>@@ -1381,6 +1391,11 @@ static void vmx_prepare_switch_to_host(struct vcpu_vmx *vmx)
> 	invalidate_tss_limit();
> #ifdef CONFIG_X86_64
> 	wrmsrl(MSR_KERNEL_GS_BASE, vmx->msr_host_kernel_gs_base);
>+
>+	if (guest_can_use(&vmx->vcpu, X86_FEATURE_FRED)) {
>+		vmx->msr_guest_fred_rsp0 = read_msr(MSR_IA32_FRED_RSP0);
>+		wrmsrl(MSR_IA32_FRED_RSP0, vmx->msr_host_fred_rsp0);

same question.

>+	}
> #endif
> 	load_fixmap_gdt(raw_smp_processor_id());
> 	vmx->guest_state_loaded = false;
>@@ -4889,6 +4904,8 @@ static void __vmx_vcpu_reset(struct kvm_vcpu *vcpu)
> 
> #ifdef CONFIG_X86_64
> 	if (kvm_cpu_cap_has(X86_FEATURE_FRED)) {
>+		vmx->msr_guest_fred_rsp0 = 0;
>+
> 		vmcs_write64(GUEST_IA32_FRED_CONFIG, 0);
> 		vmcs_write64(GUEST_IA32_FRED_RSP1, 0);
> 		vmcs_write64(GUEST_IA32_FRED_RSP2, 0);
>diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
>index 3ad52437f426..176ad39be406 100644
>--- a/arch/x86/kvm/vmx/vmx.h
>+++ b/arch/x86/kvm/vmx/vmx.h
>@@ -278,6 +278,8 @@ struct vcpu_vmx {
> #ifdef CONFIG_X86_64
> 	u64		      msr_host_kernel_gs_base;
> 	u64		      msr_guest_kernel_gs_base;
>+	u64		      msr_host_fred_rsp0;
>+	u64		      msr_guest_fred_rsp0;
> #endif
> 
> 	u64		      spec_ctrl;
>-- 
>2.43.0
>
>