Received-SPF: pass (google.com: domain of linux-kernel+bounces-151582-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 19 Apr 2024 10:26:38 -0400
From: Frank Li <Frank.li@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 01/12] arm64: dts: imx93: use FSL_EDMA_RX for rx
 channel
Message-ID: <ZiJ/Ho/tjjoAehoa@lizhi-Precision-Tower-5810>
References: <20240419-imx93-dts-4-13-v2-0-9076e1d7d399@nxp.com>
 <20240419-imx93-dts-4-13-v2-1-9076e1d7d399@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240419-imx93-dts-4-13-v2-1-9076e1d7d399@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QRaVMnzAbdDIDXsWd3meRqClIz5xIrwPSfKkXwygiu5G75Zhx9i1OaenZkas?=
 =?us-ascii?Q?uREu5J6l9NtuuC0pVVlcWUm2HcTlfdZQay7p9OrbHbQ4b6+O4PoN9Ke6JwjZ?=
 =?us-ascii?Q?kSXO1DAQVYi/ZK76rVSYgC+1P6dwlXhQOefp39WgoVzeqNIbqH0Zez/KoLiG?=
 =?us-ascii?Q?KU9mNVwt+zCa85omPIEuKdzMlI3J7Nl5UDy8dGNAFA3pTGaxaGaJT5JGc+LP?=
 =?us-ascii?Q?weLverzaG/z1up+ecBPpf8TPrbtJz8v5g0zKAIjH/OCL5eVoptLTMbJVjCXU?=
 =?us-ascii?Q?rvv9HgVoy8KyMuPDlBlqzlMg3DNAA531YPDLcVuc+RoyRl13ryVGksaiT7jR?=
 =?us-ascii?Q?bCUMnSczkbPpDddWBMxJXUhPrz0FBC4kkBy9fF0AGW+AOStjxAZzny/F73uu?=
 =?us-ascii?Q?e5+WQfvtWKl1jr0Y92pol+3di/Jg/HFtrkCMaeGUwLzXfE72X4EoEFECgfnW?=
 =?us-ascii?Q?yKgARURVI9mv+glxBQ2MbIlveYNpFsBwKEKs+etDyrObqppECqX9FuY0k449?=
 =?us-ascii?Q?PYqa8vISolfRF0Ibcf8jhflDbZp+5HvMGC71q0p7ElkvHWB6oiVRF4La0lLy?=
 =?us-ascii?Q?PC83jbilhMxlqngfEinfZNhECSbQJUhdu1ewlHG21ZDk8+e3SWKGpLM0ix5j?=
 =?us-ascii?Q?LYvQfv4+1n9iiEGt3ZQd/rVzD0s8PKrbgf63k70pvaH57vON6Bis3rZC0OW2?=
 =?us-ascii?Q?a+OiOodAcq/1qmy7mCjpQetvVs5bmY2tlu/me4XFfelPeSRvnokmGPl2UqDu?=
 =?us-ascii?Q?aDEg9FzIi/zjrnRtN1y2BUwPOdRdm0cfmKIj6Az4KRawaMPVkNtuBC/HlECM?=
 =?us-ascii?Q?DPN8oft7mzFI7BoC7dkiHWqYKLFARQcMfwMHKFoEqqNp19gYnCal9yjAQRx7?=
 =?us-ascii?Q?/iH+3j5aOl9nsVtEGe+AphNzzwZesyvL9ZOy8cUwYFQoQhxJjI8mnZbL2mV3?=
 =?us-ascii?Q?UMdZxawpQWSyvBDWUuidTDAERaJ1npxZY01u1A+7cULEJ0uy7zsqtYijcPyw?=
 =?us-ascii?Q?z87Xhwi+Sw0/gEQD16oIrkHkRPLf+0u2+5+W77k4CzXKeQSYtIiCeqfqLPBa?=
 =?us-ascii?Q?F6ezhY2O+vq3Tt4KaG2GaETfeABxKPGq+dRSbruWK2FTJ95UcVszjTBpqtTE?=
 =?us-ascii?Q?oCjwzzNujufVHohyxVXYeciWlLRzU/D5M8x+TkC+fwdZ5PCt+HI3RvJ136rk?=
 =?us-ascii?Q?0eL5XKpTPtb+s4EKONIfyTc5jXKc8B4WDdtUX7QSdaYV6lHp9CgRlmp28BhC?=
 =?us-ascii?Q?L029zGRH7c68OH0tGppFV2s3wCkkLgq0wMtNWFUMFPHPkT3Ozk29SgHUg1rU?=
 =?us-ascii?Q?+hiUdPfspdRMDHMuT0P+QPhGBrqNcO4RH3KVs97R8s0SFJ8kTX5pGnxzpXJ0?=
 =?us-ascii?Q?sySFNZY3qjn6mvJ+mcvgbtgUa9NflixsW2XiMt0VteuANWJO3pM69QA1hW+f?=
 =?us-ascii?Q?hWy1XNWZZa7lDvND6+RZdhSCjsibnrkoH7DljU071OVzJb7Qpn76a8YrNFKH?=
 =?us-ascii?Q?FVvSALoNuDEJyiOF2oviJL/0Gwvzn/dDn4tEpZM35XUHBGG4fb+hcjLIMliF?=
 =?us-ascii?Q?AIk/s1ZgQdmk56CevDk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 568bbbe5-1c97-4211-19db-08dc607cbf67
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 14:26:48.4674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EUtBqPalDAyZOKlWKQDBM7o4QOlJOI5ynCOq6nRfpzGPrSW/Jk0FkQXCGs57+HztMp3DsYLtb9PvHzCUSh4+Kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8611

On Fri, Apr 19, 2024 at 11:36:56AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Use FSL_EDMA_RX for dma rx channel bitmask, which is intuitive.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index b8ef9b938856..42bbe491a29b 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -4,6 +4,7 @@
>   */
>  
>  #include <dt-bindings/clock/imx93-clock.h>
> +#include <dt-bindings/dma/fsl-edma.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> @@ -361,7 +362,7 @@ lpuart1: serial@44380000 {
>  				interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART1_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma1 17 0 1>, <&edma1 16 0 0>;
> +				dmas = <&edma1 17 0 FSL_EDMA_RX>, <&edma1 16 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -372,7 +373,7 @@ lpuart2: serial@44390000 {
>  				interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART2_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma1 19 0 1>, <&edma1 18 0 0>;
> +				dmas = <&edma1 19 0 FSL_EDMA_RX>, <&edma1 18 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -400,7 +401,7 @@ sai1: sai@443b0000 {
>  					 <&clk IMX93_CLK_SAI1_GATE>, <&clk IMX93_CLK_DUMMY>,
>  					 <&clk IMX93_CLK_DUMMY>;
>  				clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> -				dmas = <&edma1 22 0 1>, <&edma1 21 0 0>;
> +				dmas = <&edma1 22 0 FSL_EDMA_RX>, <&edma1 21 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -737,7 +738,7 @@ lpuart3: serial@42570000 {
>  				interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART3_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma2 18 0 1>, <&edma2 17 0 0>;
> +				dmas = <&edma2 18 0 FSL_EDMA_RX>, <&edma2 17 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -748,7 +749,7 @@ lpuart4: serial@42580000 {
>  				interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART4_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma2 20 0 1>, <&edma2 19 0 0>;
> +				dmas = <&edma2 20 0 FSL_EDMA_RX>, <&edma2 19 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -759,7 +760,7 @@ lpuart5: serial@42590000 {
>  				interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART5_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma2 22 0 1>, <&edma2 21 0 0>;
> +				dmas = <&edma2 22 0 FSL_EDMA_RX>, <&edma2 21 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -770,7 +771,7 @@ lpuart6: serial@425a0000 {
>  				interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART6_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma2 24 0 1>, <&edma2 23 0 0>;
> +				dmas = <&edma2 24 0 FSL_EDMA_RX>, <&edma2 23 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -813,7 +814,7 @@ sai2: sai@42650000 {
>  					 <&clk IMX93_CLK_SAI2_GATE>, <&clk IMX93_CLK_DUMMY>,
>  					 <&clk IMX93_CLK_DUMMY>;
>  				clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> -				dmas = <&edma2 59 0 1>, <&edma2 58 0 0>;
> +				dmas = <&edma2 59 0 FSL_EDMA_RX>, <&edma2 58 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -826,7 +827,7 @@ sai3: sai@42660000 {
>  					 <&clk IMX93_CLK_SAI3_GATE>, <&clk IMX93_CLK_DUMMY>,
>  					 <&clk IMX93_CLK_DUMMY>;
>  				clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> -				dmas = <&edma2 61 0 1>, <&edma2 60 0 0>;
> +				dmas = <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -845,7 +846,7 @@ xcvr: xcvr@42680000 {
>  					 <&clk IMX93_CLK_DUMMY>,
>  					 <&clk IMX93_CLK_AUD_XCVR_GATE>;
>  				clock-names = "ipg", "phy", "spba", "pll_ipg";
> -				dmas = <&edma2 65 0 1>, <&edma2 66 0 0>;
> +				dmas = <&edma2 65 0 FSL_EDMA_RX>, <&edma2 66 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -856,7 +857,7 @@ lpuart7: serial@42690000 {
>  				interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART7_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma2 88 0 1>, <&edma2 87 0 0>;
> +				dmas = <&edma2 88 0 FSL_EDMA_RX>, <&edma2 87 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> @@ -867,7 +868,7 @@ lpuart8: serial@426a0000 {
>  				interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_LPUART8_GATE>;
>  				clock-names = "ipg";
> -				dmas = <&edma2 90 0 1>, <&edma2 89 0 0>;
> +				dmas = <&edma2 90 0 FSL_EDMA_RX>, <&edma2 89 0 0>;
>  				dma-names = "rx", "tx";
>  				status = "disabled";
>  			};
> 
> -- 
> 2.37.1
>