Received-SPF: pass (google.com: domain of linux-kernel+bounces-151568-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240418121249.42380-1-Jason@zx2c4.com> <20240418121249.42380-4-Jason@zx2c4.com>
 <e4cbb6ab-975a-4d91-9bde-6976b4d84eba@amazon.co.uk> <CAHmME9r8+ULD74ehz-LOpuAXb57BDFCD9Gr3Aw-JPJfTLC5OCw@mail.gmail.com>
 <e2de24bf-d154-4b11-b322-8bad7de8a0a6@linaro.org>
In-Reply-To: <e2de24bf-d154-4b11-b322-8bad7de8a0a6@linaro.org>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Fri, 19 Apr 2024 16:16:05 +0200
Message-ID: <CAHmME9qEWHb_q+BS3MvCXbOZJNcrakdZBGCm3-eyu0B6ucPZ1w@mail.gmail.com>
Subject: Re: [PATCH v7 3/3] virt: vmgenid: add support for devicetree bindings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh@kernel.org, tytso@mit.edu, krzk@kernel.org, 
	"Landge, Sudan" <sudanl@amazon.co.uk>, conor+dt@kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, sudanl@amazon.com, graf@amazon.com, 
	dwmw@amazon.co.uk, xmarcalx@amazon.co.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 19, 2024 at 4:14=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 19/04/2024 16:02, Jason A. Donenfeld wrote:
> > Hi Rob,
> >
> > On Fri, Apr 19, 2024 at 3:30=E2=80=AFPM Landge, Sudan <sudanl@amazon.co=
uk> wrote:
> >>>   config VMGENID
> >>>          tristate "Virtual Machine Generation ID driver"
> >>>          default y
> >>> -       depends on ACPI
> >>> +       depends on ACPI || OF
> >>
> >> Version 2 of the patches had these flag but were removed in version3
> >> following the below review comment from Rob:
> >> "One of those is pretty much always enabled, so it can probably be dro=
pped."
> >> reference :
> >> https://lore.kernel.org/lkml/CAL_JsqJoB5CYajWuntMdQrJZir+ZA-69Q0cwvxcV=
ZAqs-mXC+Q@mail.gmail.com/
> >
> > Are you sure about that? I see other drivers that depend on `ACPI ||
> > OF`, and this driver is totally useless without either disabled
> > (right?), so the dependency makes sense. I think? Not an expert in
> > this area, so I'm happy to defer to what you know is best, but I did
> > want to lightly pushback a bit.
> >
>
> There are just 18 cases, so I would argue that it's not a real pattern
> but could be just growing organically, without really thinking.
>
> The driver could still be probed on some !ACPI and !OF system via driver
> name matching.
>
> Keeping it as is seems harmless, but OTOH, if this stays, you miss ||
> COMPILE_TEST

Fair enough, I'll ditch it.

Jason