Received-SPF: pass (google.com: domain of linux-kernel+bounces-151613-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 19 Apr 2024 15:56:43 +0100
From: Conor Dooley <conor@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Konstantin P." <ria.freelander@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Konstantin Pugin <rilian.la.te@ya.ru>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	Lech Perczak <lech.perczak@camlingroup.com>,
	Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: sc16is7xx: Add compatible line for
 XR20M1172 UART
Message-ID: <20240419-defection-bagful-12d55d763b0f@spud>
References: <20240419124506.1531035-1-rilian.la.te@ya.ru>
 <20240419124506.1531035-3-rilian.la.te@ya.ru>
 <20240419-glue-pyramid-584728c0076a@spud>
 <CAF1WSuy4OJVTU5VJdn23BSw4aTAq7i8UQ416V7BxveuQ+5=-1w@mail.gmail.com>
 <dc6573ba-37cb-4394-9a89-16b6f8caa7ad@kernel.org>
 <CAF1WSuzVLrsYt6+CyMHJuRbuXNEy2XnWhbHkcPHT3xXpB3Yh-Q@mail.gmail.com>
 <ZiKFNllT9tMHlH7M@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3QBmqN9SXTsyWoKd"
Content-Disposition: inline
In-Reply-To: <ZiKFNllT9tMHlH7M@smile.fi.intel.com>


--3QBmqN9SXTsyWoKd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 19, 2024 at 05:52:38PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 19, 2024 at 05:34:44PM +0300, Konstantin P. wrote:
> > On Fri, Apr 19, 2024 at 5:24=E2=80=AFPM Krzysztof Kozlowski <krzk@kerne=
l.org> wrote:
> > > On 19/04/2024 16:17, Konstantin P. wrote:
>=20
> ...
>=20
> > > Commits must stand on their own. Cover letter is not merged. This is =
the
> > > place where you add new hardware, so here you describe and explain the
> > > hardware.
> >=20
> > It is also described in patch 3 in the series. I need to repeat this
> > description in patch 2 too?
> >=20
> > Cite from patch 3:
> >=20
> > XR20M1172 register set is mostly compatible with SC16IS762, but it has
> > a support for additional division rates of UART with special DLD regist=
er.
>=20
> The point is, if I got it correctly, to have a few words in the descripti=
on
> of the DT binding itself, so whoever reads the bindings (w/o even accessi=
ng
> the Git history of the project) may understand this.

Yes, each patch must independently justify the change - although in this
case it is about the history not people reading the bindings as I was
talking about the commit message and not the contents of the diff.
It's especially true when I only get sent the bindings patch, although
=66rom other messages in this thread that may not have been intentional.

Thanks,
Conor.

--3QBmqN9SXTsyWoKd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZiKGKwAKCRB4tDGHoIJi
0q0PAP44mYOzU2Bud3h4ppjoMoHflukxo0/CWv1h/ScDLfOD0gD+I57CXhw3f2IP
bJ5AsqUviTEcb5TEYLOuvx7JV0WL7gU=
=jgJr
-----END PGP SIGNATURE-----

--3QBmqN9SXTsyWoKd--