Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp702596lqt; Fri, 19 Apr 2024 08:03:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQ2+fH+RhcFh2F6gi78dZNe576b6iIkSgyYrlc9mbjmQYu8FvPuWvIeEFQm6aYrG33eh5dHK0zeBu9hAfhtVyytvezIeh2cXsuPQyTGA== X-Google-Smtp-Source: AGHT+IGNKhLirN7iKgB21FGF+wZwUMt4JAszBF1/XPrCS8+Q0Mg41UVWNLf/s8imTIyw9HjVbcic X-Received: by 2002:a50:8e5b:0:b0:56e:ddc:17ad with SMTP id 27-20020a508e5b000000b0056e0ddc17admr2177891edx.30.1713538987794; Fri, 19 Apr 2024 08:03:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713538987; cv=pass; d=google.com; s=arc-20160816; b=xMHBDo/yBwQ1AXH+wMpxwnQj6pENrf4Y+nWTmUUPfAdxDwZYbsdxbeOItkQS+PYMyg tQB8f9M6QrNhy2RrXnnCPk3l80OOkUmikbbE5vBeKy75M7Br7s8b/2+684xeubncmjvG bRKuTsfCv/E2/o1nVOi0fwmJ36sDGbwYhLOldhaI1b1Oy5whCU3+gNW8vQSYC9FHl98A SwbZx2Vqm74jbjGO+zdJubALcAURlJXX8CYJLQ2iROzUg7Ztgw2EV0lR9WwjestS4vHV +gsLPkC8b+m9ZFCkTjX0t/saBTTqJAZ3FKcopA15vJJUdU0vyJ4WMO0yV4dDKOXeGRip UDKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Q5l3DrKtVmRlu1zHtwVyAGR5CrXZw06HBbbhzszuOCs=; fh=d+T+/WjPkQV2vyIyKw9oYRR3oD2t/qSX04XdHJPpaco=; b=0fWW/m+3gDSi9nn30siulZHOLSgseujNKzsh88AAG7N5kbTMYjIp5dJIiWwaTz6m7c kfUtWHwlV8Txvq2ZlZBeFkxsRdoWIlVwKRSNUsTpXQDwU11POUNWzVOaAvRtWWONQfxc nKhVcOF7gl9x35ZBUnUR9kxcgHkWP6lhYpva8A9ksPsUoOcuUL6fhv9sPRW95BcQGSnZ NXZLmkQXKpFi3fHvK/qo3MvTL4sNp2UiWtXbcsbHBZondfZpYj1AjDGGDJL/gpD2ZVKa UT2m4aLk+Vypx96A8WzHO6dksPGNy8cPFwnmCQz/9hMiop4OskrpPYX/ByqXhK33p7bX 81eQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tRIAHecZ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-151623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151623-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z3-20020a056402274300b00571d721a06esi622320edd.549.2024.04.19.08.03.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:03:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tRIAHecZ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-151623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151623-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B39F21F24947 for ; Fri, 19 Apr 2024 15:02:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2980F12FB2A; Fri, 19 Apr 2024 15:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tRIAHecZ" Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A46812F394 for ; Fri, 19 Apr 2024 15:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713538949; cv=none; b=Jo7BRLiTB7s9eUAAjA/BihxGVRMcPEPA1tj4m4JjXu7kCh6TH4ayyE2quIPcc8fbvwVmlFu8T6OaF/vLnPtAi7osdJBZPQyaFLU5RW17TLvHPHCK55BAwk6sD6uwKGsNn1Xos+rVPhwUx9iyqvXRKk+mb8KLMr7LmsJL4DcQGQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713538949; c=relaxed/simple; bh=vs8I0n1fwkO45SFsUzTWz0UgIPjHU3Owfx+JLcvKa/4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mogTKYmy0LxNezSys4P6PnSmhitsFUCLvKgQ0wtWtfp/jLbtI8JzO18SV/Vx5xJDA7/YTEITxMPmHHrGIwk2MqazLZgrDBmznKxCABDFS4XILfTtHWELeluVF+9VwNE2R5NbZ2ZcfeaxJCNyMZwlSR9Bi2WLBqFllZ3wb2/7fS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tRIAHecZ; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-51abd9fcbf6so1436686e87.1 for ; Fri, 19 Apr 2024 08:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713538945; x=1714143745; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q5l3DrKtVmRlu1zHtwVyAGR5CrXZw06HBbbhzszuOCs=; b=tRIAHecZDcDzhBSVIf3j1Q/gB7N9uYKoW7MX9PCgwy7GG3/rKTBFpaNvSiF+zGs2rB l3dI+Wog7rAejrMxSJTDUubk4zHeChYNLuerBRvdkFmcFRXy+GIETeYXWegEDS2Fs1L/ +HqgjrKEokdTCRTX0gIFaN7SW2rEjG8pdy4uYGn1fAwIa+F63MuSMLSmbp1GZdSotzmE 9XtLDglnKANWi45FXJV/7YK54NI5Vooz0m83eiA6tiPkvREZfmoFBhIjAfa8OYafbzn2 9Ozr8Nn/kYAF3XRZpUqpj++FiPnpa8eVwH6L+2njHXYChPcvI6wEUTET7yyIB1KqxZnt DYyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713538945; x=1714143745; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q5l3DrKtVmRlu1zHtwVyAGR5CrXZw06HBbbhzszuOCs=; b=Ti6u6O+wmRe2gvgMF+uQR4Txat7vsiz3xYSqZKqHjoyHaoN9caqlDnUjGVz3mggzkb PkOkWeimWWgmEDAkd2N+RRWJsJfj3T7gkL0ThNOgEjMTK6ASHqxuHuR/KzmsZBlF3Kqq KxExNDxzh+Fjmu84JUCmkRdL0KLywJX5wQVoPXcUJEisT5Ll8S4WWcpBUp2og25qGMH/ iGEKgLdcTlh1Wz5wHXcjbrQJBFz8Yh6bgZuFxtDmw90B06OWC3s8MdWWFHSY+c7HqAkw i9VFVNpPAXGTJMQoGUg5kLHuVG4OhK7tbxNKuMzI7VeRat4VCRPMQu0BKlBfZbgG3mdb lpQg== X-Forwarded-Encrypted: i=1; AJvYcCVnaAyACopK4EMXG39YQRqjqoU96z5D8rATRWAt0zvbuxYdgikvroUTGrE5HvcfX7gt3j7Q7Pk+BeDxFBZZPGuDQFqJANI2NuA+ahBr X-Gm-Message-State: AOJu0YynhDhFUVRgYNwnEdXVeNp4bUDej+Hwr8YJQt+JjOEAHZXWrmcf 6SCrNLd5HQeVSNFhuGoZBeJWHkpRFD6AohG2TfaLJ63g67jAWFexv3ax9Jizudo= X-Received: by 2002:a2e:3209:0:b0:2d8:2714:38e6 with SMTP id y9-20020a2e3209000000b002d8271438e6mr1865865ljy.25.1713538945291; Fri, 19 Apr 2024 08:02:25 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::8a5]) by smtp.gmail.com with ESMTPSA id y18-20020a05651c021200b002d9f3bed88dsm636898ljn.77.2024.04.19.08.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:02:24 -0700 (PDT) Date: Fri, 19 Apr 2024 18:02:23 +0300 From: Dmitry Baryshkov To: Aleksandr Mishin Cc: Robert Foss , Swapnil Jakhade , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Tomi Valkeinen , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nikhil Devshatwar , Aradhya Bhatia , Jani Nikula , Rob Herring , Zhu Wang , Yuti Amonkar , Jyri Sarha , Quentin Schulz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path Message-ID: <4ytkvuigcxhs437rp46sawpzs6ewhgcldgvsy5c5ohpajt76vh@jg45sjwtwlgx> References: <20240419113637.25745-1-amishin@t-argos.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419113637.25745-1-amishin@t-argos.ru> On Fri, Apr 19, 2024 at 02:36:37PM +0300, Aleksandr Mishin wrote: > In cdns_mhdp_atomic_enable(), there is an error return on failure of > drm_mode_duplicate() which leads to the mutex remaining locked. > Add a mutex unlock call. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference") > Signed-off-by: Aleksandr Mishin > --- > This patch is against drm-misc-next branch of drm-misc repo. > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry