Received-SPF: pass (google.com: domain of linux-kernel+bounces-151626-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 17:07:12 +0200
From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Makefile: remove some unnecessary header include
 paths
Message-ID: <ZiKIoLKtG0suO-8i@bergen.fjasle.eu>
References: <20240416121838.95427-1-masahiroy@kernel.org>
 <20240416121838.95427-3-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="fwy6oIwWUjQAVF0b"
Content-Disposition: inline
In-Reply-To: <20240416121838.95427-3-masahiroy@kernel.org>
Jabber-ID: nicolas@jabber.no


--fwy6oIwWUjQAVF0b
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue 16 Apr 2024 21:18:36 GMT, Masahiro Yamada wrote:
> The include directive with the double-quote form, #include "...",
> first searches for the specified header in the directory containing
> the source file.
>=20
> If all local headers are included using the double-quote form instead
> of the angle bracket form, there is no need to add the local directory
> to the header search path.
>=20
> drivers/gpu/drm/imagination and drivers/net/ethernet/aquantia/atlantic
> use only the double-quote form for including the local headers, and
> there are no generated sources or headers in their directories. Hence,
> the local header search path is unneeded.
>=20
> The same applies to arch/loongarch/kvm/ because TRACE_INCLUDE_PATH is
> relative to include/trace/.
>=20
> I guess there exist more Makefiles with unnecessary header inclusion
> paths (and more cases where it is possible to delete the header search
> path by replacing #include <...> with #include "..."), but I do not have
> an easy way to detect it.
>=20
> These are unneeded inclusion paths that I happened to find.
>=20
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>=20
>  arch/loongarch/kvm/Makefile                     | 2 --
>  drivers/gpu/drm/imagination/Makefile            | 2 --
>  drivers/net/ethernet/aquantia/atlantic/Makefile | 2 --
>  3 files changed, 6 deletions(-)
>=20
> diff --git a/arch/loongarch/kvm/Makefile b/arch/loongarch/kvm/Makefile
> index 244467d7792a..7a0108a721c1 100644
> --- a/arch/loongarch/kvm/Makefile
> +++ b/arch/loongarch/kvm/Makefile
> @@ -3,8 +3,6 @@
>  # Makefile for LoongArch KVM support
>  #
> =20
> -ccflags-y +=3D -I $(srctree)/$(src)
> -
>  include $(srctree)/virt/kvm/Makefile.kvm
> =20
>  obj-$(CONFIG_KVM) +=3D kvm.o
> diff --git a/drivers/gpu/drm/imagination/Makefile b/drivers/gpu/drm/imagi=
nation/Makefile
> index ec6db8e9b403..3d9d4d40fb80 100644
> --- a/drivers/gpu/drm/imagination/Makefile
> +++ b/drivers/gpu/drm/imagination/Makefile
> @@ -1,8 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0-only OR MIT
>  # Copyright (c) 2023 Imagination Technologies Ltd.
> =20
> -subdir-ccflags-y :=3D -I$(srctree)/$(src)
> -
>  powervr-y :=3D \
>  	pvr_ccb.o \
>  	pvr_cccb.o \
> diff --git a/drivers/net/ethernet/aquantia/atlantic/Makefile b/drivers/ne=
t/ethernet/aquantia/atlantic/Makefile
> index 8ebcc68e807f..268a055086c4 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/Makefile
> +++ b/drivers/net/ethernet/aquantia/atlantic/Makefile
> @@ -8,8 +8,6 @@
> =20
>  obj-$(CONFIG_AQTION) +=3D atlantic.o
> =20
> -ccflags-y +=3D -I$(srctree)/$(src)
> -
>  atlantic-objs :=3D aq_main.o \
>  	aq_nic.o \
>  	aq_pci_func.o \

I'm afraid drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c,=20
=2E../hw_atl2/hw_atl2.c and .../hw_atl2/hw_atl2_utills{,_fw}.[ch] need to=
=20
be adjusted first.

Except for the atlantic related patch diff:
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

--fwy6oIwWUjQAVF0b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmYiiKAACgkQB1IKcBYm
EmnrQxAAunFD7ET2ixOJ1mZIQH/XqFzErlSihK9sOkn8LU1PLS4NPTNQbyytman0
I1pomoValbUTr01blxH4l6HH6sg61xj2vVnRCJxU44LU88tr4z5d0O37LO0oQpen
MM1HUyUxNz7UyrRa+9YMl4lp7YvbSVbAVVIpli48vlfkQ3Zjhrt0mlgv5JxwIhim
UyoaOIS7iLswsjNhqMicDr5NWg8k7WvRPsHHEaOXfu4rXLc1mNDNxorrK80mDMeb
YtrJ+a9B9cY5Gr48NCvjfcRh/w0DqBBi2WiRe97pcD5VY7qIAWhMQlRktFaf6pHC
4Gz9Q8pwVUsCk1dnGfqqBnei+8MZzrCmJ3bJSgcADPVUJ6HCNPfFK28swdy3idfP
yBd2y7BO32DrGQ9RJJ1A59LlyejjYSOONWLEDKdsnHQJYSpzK9czQ5Bxqb839fMI
YCAdZRcbyWt0OEHvcv5R4CeopdZdQ4uCRO8SsA/RiqAlCUkInxF3tRV6spPDbheF
7cO8Ubh7yc3fxLL+3tuVqDr9/rQeJuwUc4816riiWKqVivseJTXtpcDw+eatM+Pb
L5yZtxYyjHWtpaYI5dXTjiPu20pLZxxIbiox+0SvXYz2ctMr85/VqBGLzFsKHC36
bgUeI5o7nYCkU5fvKueBnrcK4pJ5lwcAdl8MOmImszrDkWOnbq0=
=Ct27
-----END PGP SIGNATURE-----

--fwy6oIwWUjQAVF0b--