Received-SPF: pass (google.com: domain of linux-kernel+bounces-151638-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 11:12:07 -0400
From: Frank Li <Frank.li@nxp.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: bhelgaas@google.com, wei.liu@kernel.org, kys@microsoft.com,
	haiyangz@microsoft.com, lpieralisi@kernel.org,
	linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org, Boqun.Feng@microsoft.com,
	sunilmut@microsoft.com, ssengar@microsoft.com
Subject: Re: [PATCH] PCI: Add a mutex to protect the global list
 pci_domain_busn_res_list
Message-ID: <ZiKJxz/vtn5/kBT8@lizhi-Precision-Tower-5810>
References: <20240419015302.13871-1-decui@microsoft.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240419015302.13871-1-decui@microsoft.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BhhL7iypL8H4Giee47ZlI9BKO8zwhL4TNX0JnHlmIMaJR8npEUm4ZN+60Zvx?=
 =?us-ascii?Q?pr4lVX3i/WVaKtC4N+epHbsrTgZ/RF0n8EzWG//h4jxHbobOEeB6iwahCrPa?=
 =?us-ascii?Q?2Ufl8UYkddm2SPFkQ1g9oh0HllP5QAt3AhTaIBrbQaghtK5shiE3vOOjXZT+?=
 =?us-ascii?Q?+pE25F8F0tlt2VeBmf72N0WPS+m/zWnSNB4EgrdDXzMYAAh4yLA7Z/KB1rls?=
 =?us-ascii?Q?ZYPBNySGgffnvepzhjz2eh4D0PTtzPTD+hchw+S1So7yav3UCZkYeje4GTXr?=
 =?us-ascii?Q?0r6sg2pHyH4CNwQ+t2J63iGqjl4hwcnPi7JSJr9G+1zz542lZvXJuuj365uy?=
 =?us-ascii?Q?mY0IxJbs2ElUMm62BPSxjdAQeLx4anV/Ny+EToku9pO3PSBitJXirkV2u9J9?=
 =?us-ascii?Q?hKu3dGk1wG8kElVxDfmvx6OT93fcvBQKNbcVmBugFNtnbPaC4pIp1YPxRH/L?=
 =?us-ascii?Q?f0tAc8I5RIFmlP1yzTuH5rOJroS9Tg5NBIuhBHR9/qMAevGSyev0dycvZWSA?=
 =?us-ascii?Q?7H8PCfICUhtsrQSC1basdqNQPVfqYQCF/qH/iyDL2e0Tcr6MAROm8wJjMom2?=
 =?us-ascii?Q?kz5mxvKan2+YQ4ftoYn8J2c2SKlIHBXbgFg0QZSjK0G5+6y0U6MdzwL5Owvu?=
 =?us-ascii?Q?Lx1RKpUZx5/gMXnx6guTD0lM860G2Z3g1J99+R6FPkXI81viXXAs/bAxavWY?=
 =?us-ascii?Q?99s/Z3yoMvkJU8/VA8TjsvSdmDhRFuO8s0VL8RAGXvgpdIZpuVSRsxOrW/1d?=
 =?us-ascii?Q?Q5Wfhz3c/RcglNwyYjK4WZBnRLZL4UfYE9/KpWmTluoo1ASVXq7o5wP081a8?=
 =?us-ascii?Q?h8BT2OUhxG9yPZ5ZdvymCIS6kvwwiMffY+CjUjw/BWrRkzxiZWcdVBrshggF?=
 =?us-ascii?Q?KE8NSWLWOW92xOAVTjUPoiW2nx5juTIWXRLCxadfwWEhpzPPGJf1flstfpV7?=
 =?us-ascii?Q?rrOQFIvxEbfeMHT4TOy9q4Nr8l/l3zryI/9rSk3RdQkivH0SLBOvJuCBHdKS?=
 =?us-ascii?Q?juvL5j9IbLlrIv2NqeFH5NbYu2T6YYCgCEOqlj+R5GZX4qlkx5pJUJBRf0eO?=
 =?us-ascii?Q?eBF6HmDV9b6hQDm5yqzDs0KABnevvk1raXnGNe+T586GqzGbfsipxTdDnt6u?=
 =?us-ascii?Q?hrieICubVbmHZfGkbDI17RWrp1k3zB7uDJ4ZrEblKMNdq0xbpgrE9BNWlqYt?=
 =?us-ascii?Q?TCXmSAoYQ+9CuF6eB25xZnNoW1BVCVTCJ+xbpr2582MI64/80EzEx8Scchtd?=
 =?us-ascii?Q?m08asBWZHtiQGe+0DGJ/GGL9ZN5IYxeeZmxs5CLQscbCBPAF7yUTn2U+1abi?=
 =?us-ascii?Q?hQCPZBOquZc953GnMQagNAelsJQZGm5e8WHeUZAetHM5lX6wzpAOYEb2xE0y?=
 =?us-ascii?Q?Rado62R6DTdpg+mkukhqSQ3yvV4x0/ERqPwJhSBeGDMccsogIr7wTbFf/pXj?=
 =?us-ascii?Q?6ys6f89U4a3NFA1gAE3URrk7wGolbWhBZ4zBYg0emRWBIL/A3dvzbeIiUDtw?=
 =?us-ascii?Q?+FLKEwiuX1nHGNuksze9k3yQ7sMV8maaln8+PeOsaxGV9Ki+ilJeSgKODEF/?=
 =?us-ascii?Q?1HKyV+bPQArFSDm6aiBQJRqE8Wi4vyhVVoqJscgN?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11c72167-0def-4f6c-62d9-08dc60831952
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 15:12:16.2365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HS4rMV2I2+00g3ErlwdHZ6CmQLZNWyg7Xp+512n+cXEU1ICPCG8ilGepx7ny/BG5P08/SYfoWJYO87dp+C36Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8210

On Thu, Apr 18, 2024 at 06:53:02PM -0700, Dexuan Cui wrote:
> There has been an effort to make the pci-hyperv driver support
> async-probing to reduce the boot time. With async-probing, multiple
> kernel threads can be running hv_pci_probe() -> create_root_hv_pci_bus() ->
> pci_scan_root_bus_bridge() -> pci_bus_insert_busn_res() at the same time to
> update the global list, causing list corruption.
> 
> Add a mutex to protect the list.
> 
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> ---
>  drivers/pci/probe.c | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index e19b79821dd6..1327fd820b24 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -37,6 +37,7 @@ LIST_HEAD(pci_root_buses);
>  EXPORT_SYMBOL(pci_root_buses);
>  
>  static LIST_HEAD(pci_domain_busn_res_list);
> +static DEFINE_MUTEX(pci_domain_busn_res_list_lock);
>  
>  struct pci_domain_busn_res {
>  	struct list_head list;
> @@ -47,14 +48,22 @@ struct pci_domain_busn_res {
>  static struct resource *get_pci_domain_busn_res(int domain_nr)
>  {
>  	struct pci_domain_busn_res *r;
> +	struct resource *ret;
>  
> -	list_for_each_entry(r, &pci_domain_busn_res_list, list)
> -		if (r->domain_nr == domain_nr)
> -			return &r->res;
> +	mutex_lock(&pci_domain_busn_res_list_lock);

Using
	guard(mutex)(&pci_domain_busn_res_list_lock);

to simple logic, especially there are goto.

You can avoid goto out, direct return NULL;

Frank

> +
> +	list_for_each_entry(r, &pci_domain_busn_res_list, list) {
> +		if (r->domain_nr == domain_nr) {
> +			ret = &r->res;
> +			goto out;
> +		}
> +	}
>  
>  	r = kzalloc(sizeof(*r), GFP_KERNEL);
> -	if (!r)
> -		return NULL;
> +	if (!r) {
> +		ret = NULL;
> +		goto out;
> +	}
>  
>  	r->domain_nr = domain_nr;
>  	r->res.start = 0;
> @@ -62,8 +71,10 @@ static struct resource *get_pci_domain_busn_res(int domain_nr)
>  	r->res.flags = IORESOURCE_BUS | IORESOURCE_PCI_FIXED;
>  
>  	list_add_tail(&r->list, &pci_domain_busn_res_list);
> -
> -	return &r->res;
> +	ret = &r->res;
> +out:
> +	mutex_unlock(&pci_domain_busn_res_list_lock);
> +	return ret;
>  }
>  
>  /*
> -- 
> 2.25.1
>