Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp722941lqt; Fri, 19 Apr 2024 08:33:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXmclwiwCe/73YN451iSiLV37T9/ntpKkAbpQm6YX52dl2YEEo1+Q7g/onHfZP+yKbuLZkJBxstyO1bPChyGjkKnfVoCyOTthkaLVmkPA== X-Google-Smtp-Source: AGHT+IENLVQooqzN0YCfDUnE6lFWYm9x8b10djQ1PNII0ZQ6vfJlTIgcF9gJSbIzE97JNG83d6KU X-Received: by 2002:a37:c40c:0:b0:78d:62b1:76d6 with SMTP id d12-20020a37c40c000000b0078d62b176d6mr3947762qki.10.1713540796895; Fri, 19 Apr 2024 08:33:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713540796; cv=pass; d=google.com; s=arc-20160816; b=AubCSYZ/Vo8DVtP/k91K11d1VVZZq3dZ38biM5vXGiFnpVMOKO4HOC+83OwtiDwfpT KovM4vjYVU/Ldtv2BrodpyYzi5qjWSU/ozBG2OMaBtS+4tCwbZfVPbR6zXkjKlfNdBD+ YAVqcohc71QdZdQ6ZMGsMswMfNvR6iJw4vGiFtAMTQlz/+Lxr8CwngzousdRufiVmbrJ BlOSHlSDtwtx28lxRsHih+1POz+QhFfON+qbWOdMXbEBQAT34ZmSmgDRIKKRYHyefre3 2aisXeLbYvcJoN72RBPwx2vqNBFppOgYjCZdtvwEtueug+mrMk17K0l5a/icQvlWi9m1 djWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=o7mWiw0UhBR10L7gyogqosxINz9kRfahxeuI2vpWaYI=; fh=LwxqO/4zDJ/VGK9EbghAhHNvoGyd1ilcBehMbah/w6M=; b=NZ4RRPV2OKz/L/hmLvshWR4UCD5H9eiRI/P9kcZ0RO/wjomfKKEEchcaQvCeLf85/t mp8Rc1MWrjM8tFv5q56TeiVCLP1/eNGtnk55h5b2d1HISoYL9NLh4U0VigC2gOqSkjw0 F3rkxuZ4TK50QEWK5IH+OGI3hO+z98LDbZD4LuGPjOxiiMhDpy/XbfsSgsFh3WRO7IsK +SA60HEG/GTqcSz8TfTRLWYvrBbIyrWwEd8VtpGHiGd4IpLXqoS4qKg9zKs0QOEjSLEx FbZ7l5/PWABMM3O+RNVQ6tSlJPbIZ9iKCV8X/EKpXGs+/fKr7wSD9OAz1301TdqV/T4X VWpg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pCbouzFU; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-151673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151673-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id e18-20020a05620a209200b0078d637e6e1dsi4050902qka.280.2024.04.19.08.33.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:33:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pCbouzFU; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-151673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151673-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9B1001C21A5D for ; Fri, 19 Apr 2024 15:33:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0B1412FB18; Fri, 19 Apr 2024 15:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pCbouzFU" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0171B12AAF4; Fri, 19 Apr 2024 15:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713540788; cv=none; b=EoDe/Y1ANugPh1Avy4HWL+a5Z6Uy5fvAXFPDfjdyaUfOWf7ZzWN1z4YithCPJFb1rwpkQYERYL/ANi52clY1MvKfLY7O9ieITNeBIYaFi8WF9oeiM7GzmT/9uDrHJuywKM6m7zepZLul+y6Bvpa8nwAYFAhUDSceDzVIXqg4Iag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713540788; c=relaxed/simple; bh=s2YlNF511b1ugPoK8gPNXpw42GPHoGPjYZZp8GRGfW0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=luzcXo07VtiLLnGdJ8Gz1X0hKZfHK++Qy7TD/UE8RFlAJEYuPS9iaYnfHRzNmhva0tQQRsq1hlUy1K984Sq5DAGJJ3ugeZ0JdtilFkRoNVfpxOj+RtQmxP7+C52RKSZdG7HNYYohIs50xXz4D0aIh2iwVdpfM9biXfB4R9wC+c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pCbouzFU; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D32B6C072AA; Fri, 19 Apr 2024 15:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713540787; bh=s2YlNF511b1ugPoK8gPNXpw42GPHoGPjYZZp8GRGfW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pCbouzFUoeBBdBnn1y0uZdUe6YdPbeuxy05dOAEeC5v2BTvjkjvD5nfZfwfQOjG6V Iriq9/Yb4VNX/Lr44U8vrjrHVvhMXbPAw9k+b9hKJKjlpPIvV2gDnR4liDv89qOV5G Kbd+KbnoAbcTeQUPEoqTdAReDI1CeLT+6SQkQkO8O8A6xO009ITDeneE94aP9alYl5 G95s8JZ2ejk9aUb/2vnRXGH/HrZ2On44hVbFXTbzQAOqqd9GiI0Be6mdad1+/9vl0h mHConzuXWk2VEjdwFeFiQIjUp/HTWS05Msc1WVhyCvVDxGOafId0lYzvY6u8ulT4hV X5NFqVs53MoYg== From: Will Deacon To: Aleksandr Aprelkov Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Robin Murphy , Joerg Roedel , Jason Gunthorpe , Nicolin Chen , Michael Shavit , Lu Baolu , Marc Zyngier , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iommu/arm-smmu-v3: Free MSIs in case of ENOMEM Date: Fri, 19 Apr 2024 16:32:56 +0100 Message-Id: <171345118104.301415.8430851318356217015.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240403053759.643164-1-aaprelkov@usergate.com> References: <20240403053759.643164-1-aaprelkov@usergate.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Wed, 03 Apr 2024 12:37:59 +0700, Aleksandr Aprelkov wrote: > If devm_add_action() returns ENOMEM, then MSIs allocated but > not freed on teardown. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/arm-smmu-v3: Free MSIs in case of ENOMEM https://git.kernel.org/will/c/80fea979dd9d Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev