Received-SPF: pass (google.com: domain of linux-kernel+bounces-151682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Josua Mayer <josua@solid-run.com>
Date: Fri, 19 Apr 2024 17:35:18 +0200
Subject: [PATCH net-next 2/2] net: phy: adin: add support for setting led-,
 link-status-pin polarity
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240419-adin-pin-polarity-v1-2-eaae8708db8d@solid-run.com>
References: <20240419-adin-pin-polarity-v1-0-eaae8708db8d@solid-run.com>
In-Reply-To: <20240419-adin-pin-polarity-v1-0-eaae8708db8d@solid-run.com>
To: Michael Hennerich <michael.hennerich@analog.com>, 
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
 Rob Herring <robh@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, 
 Alexandru Tachici <alexandru.tachici@analog.com>, 
 Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, 
 Russell King <linux@armlinux.org.uk>
Cc: Jon Nettleton <jon@solid-run.com>, 
 Yazan Shhady <yazan.shhady@solid-run.com>, netdev@vger.kernel.org, 
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
 Josua Mayer <josua@solid-run.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NllxOU00WnRiNDVHL0JMcGE1eDY0c3VJSWJXc2J1a1lRdFVRaVowZnMzdVBv?=
 =?utf-8?B?N2ZkdjZ6UDJ3QzUzUTB6cnpZUElxR1hGemV1N3B1aGVBbVB3eE4ycEdseXN0?=
 =?utf-8?B?bU1tdzM1Z2pLbkQvaFhDQVJEM2VMN2E5N29STHNscWpjS2RmaXBobjEyMGw4?=
 =?utf-8?B?WXJpU2duWjJYb014MlFFRC9HMGlublhvemtoYmJEeGlCOEZnT2ZjdjF2dS8z?=
 =?utf-8?B?Qk9MQ2ZaRFc0QkxZbmNtV2xpa3VlekxyZVRDYko5bG03UzNvejdUQXN3TSt5?=
 =?utf-8?B?a2I4cTRoblZZSVF5ZDdKU2lpQzl5QWI5T0dNVHMyRE1vOWNYUGhVeHZKbk1U?=
 =?utf-8?B?MVZsa1RDU1llTjhRdzdFVkcvZ2pqL1hReTU1bHlpeWczUVhieW9oN2tYeWd6?=
 =?utf-8?B?cTNFcVdua0J1U2s1T0pOSjlUdVYxdXl1Q1lYVXVmci9EanpjZUFSdGY5YTV5?=
 =?utf-8?B?anFRNitiRzFDT3Iwd0NTL25iYlYxTlkrdmkxQ21yL09qaHl3cnRsTDNoRCtF?=
 =?utf-8?B?R3cvZk9DcWdtQ1NzWlIvS1VYU25XendXSEFBdWhEZVpiMmdCcHVsb01IbVQy?=
 =?utf-8?B?UW5YMzBFcXZHNVJpOHF5a2VuU3R4cXV4YTczSGtzUTdySnZod3I4L2J0bU1s?=
 =?utf-8?B?UGdvek8rdmltc2NPanpidXg3eWxyRWZBdnJMbkowei9wM2wzMU8rUXdSa2I4?=
 =?utf-8?B?TzFQM1ZFVXNja0laditlL1JWTG9yalBXa3JZWEZsd0xjK3VnME56cXZwUXh0?=
 =?utf-8?B?UDRyVU9nNDl4ZHVUMG5VNU85d0I2QWlOVElzWjNZRUtzRlJ2YnZ3OENxSXRs?=
 =?utf-8?B?bmRRN3ZCVjRSTXNPelFySThUNmhmNVZXdFc5cEhYU0I1REJqQ1pLR28yZnh6?=
 =?utf-8?B?NVcxSHZacXUydTA1Zjk5N3ROeG9GbFMzYXJPZlFaTytYREhvNENYWjY0d3Rr?=
 =?utf-8?B?MFlkWUFsWldkWlpGSm11cjFlMVVmQzlLWXBKWnFYUlJySkZFWXh6SmFwdzJB?=
 =?utf-8?B?Vk1EYVhGSVc0U3VLL0RXb3I4d0FaSWNxSEdsWFd6N2tpL2pwYm85eENKdlFz?=
 =?utf-8?B?TXZjMHlDSUR6cG5jT0txdXBuYXp0Q0Z4c3Zidis0UjgwaUtUNU01OWdpK0Qx?=
 =?utf-8?B?dkw4S1JacWYzYkI1ZDl4NVNBNEZ6VGk5bm5nckxDNElqNHJjVmZxWmRoRlh3?=
 =?utf-8?B?NnUzWDFhV21xQzZUMWNjM1d2b1R6MnJFUjNKV3hvbDhreWJkOHNlOFhNZkVt?=
 =?utf-8?B?QjZvRkF5c0dGa3lMRFRSZlAwaC9sbjRwUE5xcFJXdjVCNm5FNkZnMlRhRnpy?=
 =?utf-8?B?c004NkpIOFIwZ3BGQmNYZWZFanM1eGlTU3BwTmJjRjJQZmticHdpMHNwZ001?=
 =?utf-8?B?U21hNk5rcUJYWFZGZEI2Y21oUU1MTXkzWXRKTXpvcEdMMmwzMmR0d3RmR2F4?=
 =?utf-8?B?d1Bsa0V0dG9hY0dDcDhBQ1JvWFR4Q25kcjRwV3pNb3Z6QjZEWEswQ0praWtP?=
 =?utf-8?B?QnE3VEMzM1hjSjFQNWxXUGtqSTd1OHBMaWtBenZHdW82N1ltYWFQU1lTSlJT?=
 =?utf-8?B?V3N2U3gvV1poZ09mS05kZ0hJWkRxWkNSenZubWZ5aTZIdmwzTzREbHlCclk0?=
 =?utf-8?B?R3RpZ2JVN20xb0hGU2kyNHlFdDlteXMrdU45ZEJLcDFMYk50TVlicit0N0ZX?=
 =?utf-8?B?cGMxbnp4SnFEVHhGNnBxQWc5N2FDREdSTWNFTm5RMFhqOGJhQWpXTVVUYmU0?=
 =?utf-8?B?OFFIdXlRN0VFVnFjdm9TTFZQaURqZWx2cWRtcDRkMXJpeTdzb1dqZ2s2Q1FO?=
 =?utf-8?B?Nmxad3BuN01CRWF5Q2VJcU5PQ1B0VzRKLzlFMmhvR29NdzN0WitTQjVUb1pI?=
 =?utf-8?B?OXRmbXAvWGlER3p3d1JQSGRCbGhITjVVOExOYUV3UThKSnRYa3JPaU5lbEpl?=
 =?utf-8?B?aENaMmE1ZVhmZUE4dWNzUTN2QnVlTHlpSFlTemVveGM4SXk3czlrOHhvaEl1?=
 =?utf-8?B?NUxkRm53S2ZTL2wzb0ZXaUhCNEluYVpLOTJVR0NYRzZzY2pTZnp1Z3VMUVd5?=
 =?utf-8?B?OHpSeGdjbHVsOHM4VHJkOGJhNFpJSDFTV215UzFRVUgyU1ZoMERJVmpkeG1t?=
 =?utf-8?Q?wa9r/tNxuQjFF4twyMXBRijay?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43097cc6-d8da-4df8-5001-08dc608655c2
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB7586.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 15:35:26.1235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qOiZNjiG+KHEdiuMIDIYlnCMlganAZO1TD4cqtdBXv5sjaOb3zSHwO3BrgFkJ8E3Su/VjMNFhko3xUn9Mj0kGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250

ADIN1300 supports software control over pin polarity for both LED_0 and
LINK_ST pins.

Configure the polarity during probe based on device-tree properties.

Led polarity is only set if specified in device-tree, otherwise the phy
can choose either active-low or active-high based on external line
voltage. Link-status polarity is set to active-high as default if not
specified, which is always the reset-default.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 drivers/net/phy/adin.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 2e1a46e121d9..53159dea6381 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -114,6 +114,9 @@
 
 #define ADIN1300_CDIAG_FLT_DIST(x)		(0xba21 + (x))
 
+#define ADIN1300_LED_A_INV_EN_REG		0xbc01
+#define   ADIN1300_LED_A_INV_EN			BIT(0)
+
 #define ADIN1300_GE_SOFT_RESET_REG		0xff0c
 #define   ADIN1300_GE_SOFT_RESET		BIT(0)
 
@@ -158,6 +161,9 @@
 #define ADIN1300_RMII_20_BITS			0x0004
 #define ADIN1300_RMII_24_BITS			0x0005
 
+#define ADIN1300_GE_LNK_STAT_INV_EN_REG		0xff3c
+#define   ADIN1300_GE_LNK_STAT_INV_EN		BIT(0)
+
 /**
  * struct adin_cfg_reg_map - map a config value to aregister value
  * @cfg:	value in device configuration
@@ -522,6 +528,49 @@ static int adin_config_clk_out(struct phy_device *phydev)
 			      ADIN1300_GE_CLK_CFG_MASK, sel);
 }
 
+static int adin_config_pin_polarity(struct phy_device *phydev)
+{
+	struct device *dev = &phydev->mdio.dev;
+	int ret;
+	u32 val;
+
+	/* set led polarity, if property present */
+	if (device_property_present(dev, "adi,led-polarity")) {
+		ret = device_property_read_u32(dev, "adi,led-polarity", &val);
+		if (ret)  {
+			return ret;
+		} else if (val > 1) {
+			phydev_err(phydev, "invalid adi,led-polarity\n");
+			return -EINVAL;
+		}
+
+		ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+				     ADIN1300_LED_A_INV_EN_REG,
+				     ADIN1300_LED_A_INV_EN, val);
+		if (ret)
+			return ret;
+	}
+
+	/* set link-status polarity, default to active-high (0) */
+	if (device_property_present(dev, "adi,link-st-polarity")) {
+		ret = device_property_read_u32(dev, "adi,link-st-polarity", &val);
+		if (ret) {
+			return ret;
+		} else if (val > 1) {
+			phydev_err(phydev, "invalid adi,link-st-polarity\n");
+			return -EINVAL;
+		}
+	} else {
+		val = 0;
+	}
+
+	ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+			     ADIN1300_GE_LNK_STAT_INV_EN_REG,
+			     ADIN1300_GE_LNK_STAT_INV_EN, val);
+
+	return ret;
+}
+
 static int adin_config_init(struct phy_device *phydev)
 {
 	int rc;
@@ -548,6 +597,10 @@ static int adin_config_init(struct phy_device *phydev)
 	if (rc < 0)
 		return rc;
 
+	rc = adin_config_pin_polarity(phydev);
+	if (rc < 0)
+		return rc;
+
 	phydev_dbg(phydev, "PHY is using mode '%s'\n",
 		   phy_modes(phydev->interface));
 

-- 
2.35.3