Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp730389lqt; Fri, 19 Apr 2024 08:46:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXkFlQUJP3hQaRDxRxzD1EY6uBuFhmqemJGPabLw6VxLfjAqUX5py+AK+9BDfaC/DbCSKK/DWNdJ4hayb4TnKQralvsZ1UyxO9T3zRNJg== X-Google-Smtp-Source: AGHT+IHFyvTRtBhVZc/h2LQCnKS+Ni5RO3yY3gsizqLpkbYp/yQV8TAy1QrRoCHiG9GTwwyRSL0P X-Received: by 2002:a05:6a00:4f8c:b0:6e6:843f:1d05 with SMTP id ld12-20020a056a004f8c00b006e6843f1d05mr3355285pfb.25.1713541564603; Fri, 19 Apr 2024 08:46:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713541564; cv=pass; d=google.com; s=arc-20160816; b=G/FQ5KOCO1OmULnaEXowAjCgYsllMzYBa6HJIzgc/29x2gvGMvGNCsYftdPbGoEU41 Rf9NZWJNr3pr0TRV7slQjo1p5AN99CdsDEzMJCw3ISEsab9TVLJxAUxflpc6Qontkzvk AuIVdVSJrkEJguhVLP4Bs8BhlzEkmklCT7Ia7cGP+9HM2nVJ1ltwL41o6H+dfSL/EE22 RAzuoGbL3v9qqOxpVcN8s1LBJts7SZHNYUpx2kRGnqRyGly57Kc87bo3aUdFsBzGZpv7 Qabhx/HZ9vnssQ+EgTQUys8MwuRdWQ1y5Zn61GXFaWcu3LVTVpz5ml1BY19UNybQuoyU 4BwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :from:dkim-signature; bh=Igt3nyZHnJFoLExicXWRh9ig32kbEPXi1h6YLsNI80Q=; fh=ctd/zrUdyxAbsqW6rimtkAhkTO25g4VYX37qBlAVRAE=; b=ClymxujjW7Ihue/8AjcbI3+4jl1vnAdfyjwSc9hTLkHMLJreqDDXbogAEWh2oDRJLW ymton0pNDXdGnGGao98BQsAP/J69GMDc7M886RA3ten6ne1WpJbDgCKjbww/AuwCxQt5 Ot7W0tGL60MA31epp9NVziYy5k3lvD0O8IMPunqUhiHCogGK0oD1aHF6NALJOVYEgBdg y1dgFk9lDMDT4aKFa7BzksNzbXjYyoDzTyhvtz7c92cOPq9RsJOXQFiQdsIfHKoSlI0j PM8hoOYA7NN/u5SmEJPUkeR4TjjIcjQ7RxaJEiFdq5Qs6YUTlECfmQ2v1Y7/Qza92nFF zfiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=c4BSm3zF; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-151698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151698-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id q7-20020a631f47000000b005f756bc8282si3255787pgm.595.2024.04.19.08.46.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=c4BSm3zF; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-151698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151698-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BF253B21381 for ; Fri, 19 Apr 2024 15:46:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 74EA91304BA; Fri, 19 Apr 2024 15:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c4BSm3zF" Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22A9F12F5A3; Fri, 19 Apr 2024 15:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713541549; cv=none; b=uZrcoj+g6v9ypcfEDO+BG6wfMATIVdURaQ34quhlJf+uf3+17T1mbjbxcazAFYRqPezM/WfboKbar9S5XdlG+69/uDx1KKvf00tiEjfsAF4zwWw6u0Vlt1nRbVUgCm5szjtYNBgZyu2h3+IvHyBuH4kCtEzhQskL/31RxWGKlXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713541549; c=relaxed/simple; bh=VsHiV3sJXY6clmFYZP87P9hiEDmV+Q8vGENBwO5KwDA=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=lVKKyjwyHyquif4wqyRwB77CHrQDvMdkEP6RgpYSpCk6H0nxgac5eva411NR6PFzR5G9/qKvt97JT+beYphcvizO+IYpxN9dEkqWoWhIF/tDJ+/vg+prXfF+NkixLnMgl0GIrG240JGQzre20jJ4eSZJu9WN4Cibh20hKUq6l6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c4BSm3zF; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a5590f3b60eso28284566b.1; Fri, 19 Apr 2024 08:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713541546; x=1714146346; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=Igt3nyZHnJFoLExicXWRh9ig32kbEPXi1h6YLsNI80Q=; b=c4BSm3zFpG9jzcPHUZE+Y202qUNKS0AKxAUfbf5rcrziogzV85YbOzOMBBZpvkoLFc 7clak/PaNAg9rCsr0NW/bYBNsBpJHf34m336AIvaiV/zoMgT6n4VPdaSQn9mAxhfFg4c Skbo2/Jg5Rp4uadUxsMmdFeNE8d60nETMni3i5ad3ev6aDbra8Qa0WMjQZE8gGNU0JWD upwn9+r39Kwb0UCpI5zSCwmIbO8RZFJpEE3tPNnjXntI1bzZa9ThOqBy3RxjKbBmzdh3 h6r7p/JqdaNpGT1WP+NbiUTsCvkHcSye4zJyxmdNjmhUh4C0kqD5h/4I/2oqIVEbs+ZO eAhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713541546; x=1714146346; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Igt3nyZHnJFoLExicXWRh9ig32kbEPXi1h6YLsNI80Q=; b=evqBp1t2UQcab2s6xVMtcWkuvjhiRkir42yuod+b5fcMDrkL+rXPXUlMnTk72QdOFB DsggNjEwNfWAhf2qz3S3x/rKgVtZoaq8XP2k+3qJkuNOw6EET20m2xhEYciBNQ/xzRjU OyDxGFNR3bTNmQvRULyjR3vlTjWATV67kz5WaAm2OyLE+Jr9tpDghZqHNO/4SW7gmt1T NK3U8P18jQsnCXTEoqjrv7L9VkSjjykFNLDij9vNQuVec4hHOxkzpEqHfi1kPQcmt4Ee guJLOVJc45hSXZbaCV4CVcxmUVwR7zpmMmlVXmgQlEKWZyvr5Cwear2aDeensjGRxmY0 U2kw== X-Forwarded-Encrypted: i=1; AJvYcCXZpo5f/QDiDOqqQB+wdKHokiShMTaZkgrY1orKJcI7MJSxMD65teNB4Cr+CmncAEvKuZ1ssElZLp/4bMvbOuHdEIcvzLGPNV7Fs55W2Sa+qZk1rmSBWdF5mY4MPHuiXbpwzNh6FcR0NzgKGpuEkTcvL8RJc0Bsfg9j9jZXBZTx8GezmlvUS6R2gFCzgVeXfA0G8VZ1oP+oIPFIpXqc X-Gm-Message-State: AOJu0YxvT9hyKoP1E1phhRKAgsptv+S45pDvizPckJj+lXRhdPYeFKbd L5185slKL75oAyJI8JlK6hL1RCbKlFniNSs1WoY/fXkFBnAKtMhI X-Received: by 2002:a17:906:6c99:b0:a52:2d81:6d1 with SMTP id s25-20020a1709066c9900b00a522d8106d1mr1716531ejr.51.1713541546339; Fri, 19 Apr 2024 08:45:46 -0700 (PDT) Received: from [192.168.18.253] (54-240-197-236.amazon.com. [54.240.197.236]) by smtp.gmail.com with ESMTPSA id i21-20020a170906a29500b00a526a992d82sm2331342ejz.4.2024.04.19.08.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 08:45:46 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <38a88d9c-4908-4658-a6fa-63ff7a534132@xen.org> Date: Fri, 19 Apr 2024 16:45:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: paul@xen.org Subject: Re: [PATCH 05/10] KVM: x86: Explicitly disable TSC scaling without CONSTANT_TSC To: David Woodhouse , kvm@vger.kernel.org Cc: Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Oliver Upton , Marcelo Tosatti , jalliste@amazon.co.uk, sveith@amazon.de References: <20240418193528.41780-1-dwmw2@infradead.org> <20240418193528.41780-6-dwmw2@infradead.org> Content-Language: en-US Organization: Xen Project In-Reply-To: <20240418193528.41780-6-dwmw2@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/04/2024 20:34, David Woodhouse wrote: > From: David Woodhouse > > KVM does make an attempt to cope with non-constant TSC, and has notifiers > to handle host TSC frequency changes. However, it *only* adjusts the KVM > clock, and doesn't adjust TSC frequency scaling when the host changes. > > This is presumably because non-constant TSCs were fixed in hardware long > before TSC scaling was implemented, so there should never be real CPUs > which have TSC scaling but *not* CONSTANT_TSC. > > Such a combination could potentially happen in some odd L1 nesting > environment, but it isn't worth trying to support it. Just make the > dependency explicit. > > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/svm/svm.c | 3 ++- > arch/x86/kvm/vmx/vmx.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Paul Durrant