Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp731549lqt; Fri, 19 Apr 2024 08:48:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFN9bfZZPF4rF/xH7uoYiuujDic8QSNN2hKx6u9FucNkkMf3ibcrNUbhkuGp7w+YSbA7s2qfp/XEo4xbib46DZFy1ve9dh4vO0F7pUaw== X-Google-Smtp-Source: AGHT+IG8E+3C4DiuEjJZr8BWa0RtthIugE2QM5P5rOCWDKhiOhWVtRwBaH9GqSHrWx1ajLAwDl73 X-Received: by 2002:a05:6808:2129:b0:3c7:443c:96d7 with SMTP id r41-20020a056808212900b003c7443c96d7mr3345190oiw.31.1713541684668; Fri, 19 Apr 2024 08:48:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713541684; cv=pass; d=google.com; s=arc-20160816; b=e9xDONO4NWahVgltvBQLo9ahydF1ehVWC0D5vwcDMvJ8/npRC0S91sKNnmy9UoMSzy wkd2A7c0goLlpFd2dWsFF7zF5fvgeqT/JvgssSNN0PAR11kz/ZsCYn4OoREcQoTrUP05 yltIC4CYkKVCq4xeEwOP9pH4Eaau4gHTXXBLDUeKecCrX+gZVPDSP9Gr2Mb1UILw+KuJ fw61CRb4DErCwCSdZWev43XGhyNFVDqJelpRNU/5Z1AJdAuThn/DW72GB4DnJG36PGv/ C+M59nkdiT8XxUa+jGMgBg/gP7YxcRNzT5bbptavkeRlLK1OWdbnrdifjO9w0NWuXXV4 a2TA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JLXEF/5VB2hcB1dYfUi8oj/pSt/FLjk9X5NuzMP6VaU=; fh=8GWTnxZ0Lff0a28w1dyWkfPwqm4yFnhVebv663CMjYQ=; b=gGXUafttt/xoZUHY2ghQE2cof1hdEEzS9pdtr+rW9/6hkl3K2yCeGPp/fTQ+DRZ//N BBfckH7VJs0X0B2RWNIQuOB8yUnu4PGGuFs4s85rsQi5zDylvQiKkN+G0AjFLXc9RfHl 1WJ9+8immvjFu/ORZD5HsTg6il3YsHpxDBDmS60E6cv9GnpLZWfYSNf082M+LQdsAy6g hSvx6j0zsBziCUFYZmhDKXmbkySewJ4bdj+CXQRjzVf7qwhLqD0JhvQHwtZVurK2ntlo CFaJ2spc1Tr5SU8VQjSFGlKKLN4oJfe6FlZZs6mldzNUvopBZHP+NTJ0AJm4TlNfMC8w 85kQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=IdnBr154; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-151700-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151700-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e18-20020ac85992000000b004365842cbdesi4142049qte.353.2024.04.19.08.48.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:48:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-151700-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=IdnBr154; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-151700-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-151700-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1933F1C23579 for ; Fri, 19 Apr 2024 15:47:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A0C62130A44; Fri, 19 Apr 2024 15:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IdnBr154" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D4D12FB34; Fri, 19 Apr 2024 15:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713541638; cv=none; b=lPrTpvtKOG4Nk+7Lre8OoWs+fc2uf9fqyNP06iYuLxhZ+esTuKl/nyvlf4FY/e17eIl1/OL6ca302VId6Iwu6YrGz9oKtqm3RZ2lKRj8inRI9eBphSWPhL05xVDWrp3jWo2rJ4SMLadnQPQNxSHpKk3a4SZIcfPwqcQE4RPW3OQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713541638; c=relaxed/simple; bh=EL9kCsTV22lvYw6+slnwCr5qeD8Oo1czDJiqY4Q9Kwc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BiipVfu77P9T0bRDUP+pr6qK1tKJDOJaDfu0x9hcaTZkAIKW8iHE3FLTKpY5KbAbVCCl4YKbOH7fT2otDEqHRNG1Wh9pW3UIUwcDd9GmfHc93go57cEyME61e7/BAjsZ9P1vf5xBNpp5GYLVTW8HMpiEj54uoF7IbspcJphQGXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=IdnBr154; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JLXEF/5VB2hcB1dYfUi8oj/pSt/FLjk9X5NuzMP6VaU=; b=IdnBr15472jY5I52M21qLM7ixL 43CCwNezqBDlC3cUaCOsoyfDJO7Bi19fT7afae4F14aeBNn5R/bikFzt3U7MW9BtYCPcXUISx13pk M/V2QS7uzu6ltce8i7LCBVEHBBKUb0RZxyWI7JDcNvxSL5YfJ5Cc5c29ATNCvW6e8ll8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rxqS8-00DSp2-Iz; Fri, 19 Apr 2024 17:47:04 +0200 Date: Fri, 19 Apr 2024 17:47:04 +0200 From: Andrew Lunn To: Josua Mayer Cc: Michael Hennerich , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandru Tachici , Heiner Kallweit , Russell King , Jon Nettleton , Yazan Shhady , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: phy: adin: add support for setting led-, link-status-pin polarity Message-ID: <65411c68-c76a-499d-88c7-e80ca59a3027@lunn.ch> References: <20240419-adin-pin-polarity-v1-0-eaae8708db8d@solid-run.com> <20240419-adin-pin-polarity-v1-2-eaae8708db8d@solid-run.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419-adin-pin-polarity-v1-2-eaae8708db8d@solid-run.com> On Fri, Apr 19, 2024 at 05:35:18PM +0200, Josua Mayer wrote: > ADIN1300 supports software control over pin polarity for both LED_0 and > LINK_ST pins. > > Configure the polarity during probe based on device-tree properties. > > Led polarity is only set if specified in device-tree, otherwise the phy > can choose either active-low or active-high based on external line > voltage. Link-status polarity is set to active-high as default if not > specified, which is always the reset-default. > > Signed-off-by: Josua Mayer Hi Josua Please take a look at: commit 447b80a9330ef2d9a94fc5a9bf35b6eac061f38b Author: Alexander Stein Date: Wed Jan 31 08:50:48 2024 +0100 net: phy: dp83867: Add support for active-low LEDs Add the led_polarity_set callback for setting LED polarity. Signed-off-by: Alexander Stein Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Andrew --- pw-bot: cr