Received-SPF: pass (google.com: domain of linux-kernel+bounces-151736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <534247e4-76d6-41d2-86c7-0155406ccd80@oracle.com>
Date: Fri, 19 Apr 2024 12:17:01 -0400
User-Agent: Mozilla Thunderbird
From: boris.ostrovsky@oracle.com
Subject: Re: [PATCH] KVM/x86: Do not clear SIPI while in SMM
To: Igor Mammedov <imammedo@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240416204729.2541743-1-boris.ostrovsky@oracle.com>
 <c7091688-8af5-4e70-b2d7-6d0a7134dbbe@redhat.com>
 <66cc2113-3417-42d0-bf47-d707816cbb53@oracle.com>
 <CABgObfZ-dFnWK46pyvuaO8TKEKC5pntqa1nXm-7Cwr0rpg5a3w@mail.gmail.com>
 <77fe7722-cbe9-4880-8096-e2c197c5b757@oracle.com>
 <Zh8G-AKzu0lvW2xb@google.com>
 <77f30c15-9cae-46c2-ba2c-121712479b1c@oracle.com>
 <20240417144041.1a493235@imammedo.users.ipa.redhat.com>
 <cdbd1e4e-a5a3-4c3f-92e5-deee8d26280b@oracle.com>
Content-Language: en-US
In-Reply-To: <cdbd1e4e-a5a3-4c3f-92e5-deee8d26280b@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cmlSRzZXZW5tZjIrQUpLdW91bFpNVXFpNzFMVWtZVXNUcUlXRldtUWdtcm9q?=
 =?utf-8?B?dDk2MnJ2VWowTWZMdGFheXZqK2prVlhjaDFzYktXbVEvQldTNlFsd0JRTmh2?=
 =?utf-8?B?d1NDakZsV3QvSi9CWXE3M3JWdjZzazFUYmZIbFVxUkYvWWJPWWVWZVZkQXJX?=
 =?utf-8?B?RVRCbjR4V1lQdVNCL2N3alJJNk00ZFJFekNscDF0TUlZWFlDRjg0bG5PQUxz?=
 =?utf-8?B?bEJOOG04Q2htZWhQV3BtdTlHbGxJbWg1eDcwSHBJbThuYmV5RTRhRkt2Y3lw?=
 =?utf-8?B?dlV2cXdSVXE2dVVWRllheDhMUEdkdVBMOHl3SWhuekxWb0pzcm5GaGIwZDJz?=
 =?utf-8?B?aEQ5c0I0VC9ka0ZmZmtMQnB5UW1VU2VvcXZDZjR0ZUpQdG03Sm8wZGpFRzE5?=
 =?utf-8?B?YkdOZ3cwa2JURWl2YXV0VWVjR2F5RXFMUk85VmhqUjJrS25ZRTM5dmgzSWN1?=
 =?utf-8?B?Y1NveC82QlFlcXUraWFoaTFQNWFFRTR4Q05mUjBwaFVLa05kUEIyODJtMEJs?=
 =?utf-8?B?YXlZUmJ3Y1JQTVJOakJ6MkpPbTBhbnVwVmlvWm4wUGl0N01lcGhZMGNTUnRi?=
 =?utf-8?B?ck9lYk5yNm16bDluWE9RRFlFSEpzM0JwMnRyY0s1MjlVN0ZWSVFrbDZTQVlV?=
 =?utf-8?B?dmJFeHN3cVRORFJiL0hDbFdHcTZRMFlUdWlPQUpCamJ4MDMxNWpIVmxRd0hL?=
 =?utf-8?B?WGRmNjl2d2I3VEV5SWtIUTM4K3Z4ZlE0cTRkVWNlcXp6cUkyNVU0S0ZsdmFm?=
 =?utf-8?B?NjhmUm9lcCttNGNFQXVVOHIxdkVDLzRNaE1OVVNHZmx5TlpJUjB3d2hLVkIw?=
 =?utf-8?B?UVlPNWhXUEdDWVp1VURVa21nVjhJQllheU16ZHgrbHNpVno3aUcrV0Qwb3oz?=
 =?utf-8?B?cnlSbmNPejk1UmJ2MTU0L0docTV0Z09iQmNtVEtsdHllVTdlTnc1RTVndWdP?=
 =?utf-8?B?MTdBK2hsT1lkM3hrNDNrempKMXhmNllEbXl0UVdxSld3M1haVDM1MGVIbGJI?=
 =?utf-8?B?YlFxcDFHWEF1TEF0VURwYzVJazdGYWtjeHlPQUpDN1Q1UHNUb2wvM251NHBz?=
 =?utf-8?B?clhzb1U2b045bXQ4S3VnVG5aaG9zNFVxN2kwWDRBODdQenFRTGNZMWZ4MUc0?=
 =?utf-8?B?VytaWFpWV1EwRWEzSGordXowbGlQV3plZGFsWnVjakdYK1U3Uy9QdVhNSVkz?=
 =?utf-8?B?OVk0Nlc5ckd6YnVka3AvRmxDdmdlSFJEYTZjZmFXd0hpWEJUTmFERDVRWWNv?=
 =?utf-8?B?M0pBUVBaQjFXeU1vWGRwQ1dRcGRrNG9kbUxOZzZYTnRSNHRyeUxSR3JKaHlO?=
 =?utf-8?B?dDl6azI0R2VDazVsQ0syczl2cVZURE04TmxPM2RQNmRVVDFaVEVSR0xvbXZv?=
 =?utf-8?B?R0FaNjdaWi83Zi9Da0xqaWo1bmlSVkhuVXFHMFdUQTFkWEtRYXAxcmVZVGk4?=
 =?utf-8?B?UThqZ1VFd0NmZDUxclpmdzQ3M0RKMmtqdmFieGxiRURROSs5bStidTlqcFNQ?=
 =?utf-8?B?bTVwY2Nod0NxOXdMT3lkZ2VXQ3FyNFlTTTJybFhqZU1OSFZ0TTRVZExoS1Ux?=
 =?utf-8?B?Uk5FZEJLczdJRXIrU01JU0s2SSs4akNjV0hDbmdYTG04SEh1QUlaNTZSVC95?=
 =?utf-8?B?UDgvS1BhckJQdUFKc2FPNFFpOU1yRnlhSGNtN3lFdFlwVVl0NjV5YlgxemEz?=
 =?utf-8?B?SHNlMytyYkVSbVc1czc1QVFaUUYxbXN3b25oRkx3YnpKcFNRamQvWkFMeFhI?=
 =?utf-8?B?alFwdEJqcU9PR2gvWk9tVXhwZ3NFeVdRWTJIUHN3V0tIRXZuYXFyZC9RMjBz?=
 =?utf-8?B?cmYzU2NteGFBVmozYjNpdmhqUW9JL2NBQ1BlWnlndDNKV0xKZkZhM0dpeDY1?=
 =?utf-8?B?aWt5QmdFM2wxc1YrcFhSUGVUbGp5MWF4Z3loS3NOQmdhb2VGR1RQb1M4V09E?=
 =?utf-8?B?K2MrZnR5Y0ZFSFhtSHQ3NTJ3V3g1NUtrM0ZtL1hIai9aSE1FNXkwNU1VU2Z6?=
 =?utf-8?B?N0ZTaCtUbmZvMkpQdkU5M0ZYVVVIekViWWMrbjhDN1MwQ2xOb2oyR1BKS0Nx?=
 =?utf-8?B?c09MNktrRllOQzhPTjNqZFkzOXNmTW9Id0JYY0trc3BkRnR6NFBsdHRGZWs3?=
 =?utf-8?B?cEovc1ZvcFdwL0dZdm1lNmNqSHJJQ3pjUm5hbmFEdmJSdzFEeXpwbGMwNEJk?=
 =?utf-8?B?TUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	TmUWNX6m0q1wBQ5AbRHmRjxF8nMB5MVl9iR1PNr69irmj1KZzqAzHAX+PjDeSKH7t/iESLKkxaDz4viDliZaUBjcBhXhzOTPgH0lQdQ7de87l3SuzG+YQ7sy6ynM7DT6oab8/cunVI268kOcGjLiFiIN1D49OeiDkgCuWZ9FfIMYEhlriWV+mBlr5dinJdDyjOOAzB4LUgef9gyDYzWY/9aiEiVIP7GvDQJ2mPJ0BpMNoFLzqkvH8IhQdU3mTbXPG6pPQIpuz1U24Hmi9+uObfzyzim2eZiCAgFcPVupQOo02gPYI8Ao3G75pzON+T/ZDGJ9J041geYyujlrfNESZNGOxCWoFa4nITRgp3w0nxnP3YVWvOgIllHHKJdpi/GLEjMkE1HUGmDunuDxE7cQYtKLcLT3crwJc0COrnRE9cMzdPGc61qJP2y4/Wwvw5NEyr+l/0gGLqk2pCMnyOrpBCbz5BFhYtFi4zp73mpnrtxa7GFiJbIov2put9ly6QPNuN7MI1mgUGS9/5K0SOnU9frQ0jPLe/emH56O+zgBuNbFeBgKWXm5IW0Dj1H/d+GXkG7/+H1UlwyGcZ2WXM9M9b5RO9EJ1i7wvKh8zIOGnrU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef32b692-e5be-4de7-2efc-08dc608c2739
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 16:17:05.1005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gZiwL6VSCM51FnYhR1H2zdly37VZfEN4e21HUXx+jOROzAN85ncBZfTuyiWqc9GkyrkwQmtEn8VohxMSEJ1K4HexMEDDTf+Ym6HgbdtRlm4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6036
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-19_11,2024-04-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999
 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404190123
X-Proofpoint-ORIG-GUID: jwP5OC7ZylrvahylrtUy2EAM8r84PnCZ
X-Proofpoint-GUID: jwP5OC7ZylrvahylrtUy2EAM8r84PnCZ


On 4/17/24 9:58 AM, boris.ostrovsky@oracle.com wrote:
> 
> I noticed that I was using a few months old qemu bits and now I am 
> having trouble reproducing this on latest bits. Let me see if I can get 
> this to fail with latest first and then try to trace why the processor 
> is in this unexpected state.

Looks like 012b170173bc "system/qdev-monitor: move drain_call_rcu call 
under if (!dev) in qmp_device_add()" is what makes the test to stop failing.

I need to understand whether lack of failures is a side effect of timing 
changes that simply make hotplug fail less likely or if this is an 
actual (but seemingly unintentional) fix.

-boris