Received-SPF: pass (google.com: domain of linux-kernel+bounces-151740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 19:18:57 +0300
From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= <ast@fiberby.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] dpaa2-switch: flower: validate control flags
Message-ID: <od4mb3t53s4feadbtjc74ayh4phv7yv7p6dqot5ylqockcnqin@vnsdvzn4tmlj>
References: <20240418161802.189247-1-ast@fiberby.net>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240418161802.189247-1-ast@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?CSzgDDTyake/z0lqZ2FDUImpxqKLYXC/rTTqfZe6D8z3Fdv7A4/ehMglhN?=
 =?iso-8859-1?Q?gaM9CIvEJ8CVd9vRSbMMCjhzaByjq2xZG5eB8nzBVvmpLWyO/G/QJeUAS0?=
 =?iso-8859-1?Q?z3HqtCFW7yI4c1v6/o+QdByiSJinBMb6Txh/B2l4O4a9smq6CfVHnLYCFA?=
 =?iso-8859-1?Q?nCMoHJ6RxN6BTxevBsnY/36+LziSrBter+YWdty3hwEGXlYxkzgBV+QUbt?=
 =?iso-8859-1?Q?lQCbsjKgwtC7lXvoaRuWR1W4UdQb7so9j8WoJ9xOqlzkrOdgUzLfH2VUkF?=
 =?iso-8859-1?Q?388ZvUunK84euE1klnSeb3GcRxWHuyN+LrE3yxZpPokuV0F9Fa6Zv8C4ez?=
 =?iso-8859-1?Q?fWihLTYAX5kmr7Q/AZDt5ddCnd90uTd/c3CLcXv9PBP+DH/AhnHQA9l72s?=
 =?iso-8859-1?Q?7dCpP/szFV8HdTt9rWYkWItWL82YDCbt6pxkyMPQSTXcYhswOUQoeKK7e3?=
 =?iso-8859-1?Q?f/vmBJqw6GRHSlolAH40gr6Y7jXCS68hZc6kQiGYEb2NsIRliG2UZEnpWu?=
 =?iso-8859-1?Q?6BjUHOiVEYyrzbRFtePpNjVXWAHUgwlubx8aBt/NHc0XxvLmyhpbzsTSSo?=
 =?iso-8859-1?Q?KEi6pD1kjmldx8xXcEwx+dYnQGw4I5EywDXgC1NVFwAaCrcUph/gBr4I0C?=
 =?iso-8859-1?Q?k+gAVpGQCOKePjWe2qWELfxeI1UisWSK2OBjQapGWy55G8RG663vWZbcj7?=
 =?iso-8859-1?Q?59UmuJOfqu/qaayT4cra6+3CiJXssKcnYrdr25ebQNaIFd+7f5fzEGbXVE?=
 =?iso-8859-1?Q?BI+TeEHF98t8ldvKLKDx1+orkP6qQ3n6jlNcKcLigVLPpgcRYFryh027fH?=
 =?iso-8859-1?Q?gYeW2UZrdA3gorLBYzNq9gTJcC0Dzza5o9gvL4BySz2sw2MEj1WAV0bYH1?=
 =?iso-8859-1?Q?r+tYtVCuLARGc4zxHU7yw2P4dcJRCszElzEvzf0zKOyHtQJ4hp6iKHI/JD?=
 =?iso-8859-1?Q?mLAuXki9cqeXVLz2ugbZiEdpz5MU3uPLqZuELvc5p00vLiZXVfs6cYh58k?=
 =?iso-8859-1?Q?t2F9i2lj1Z0rMGFEpbN7onFqZvMDZ7w3BNIb4oO5yO6V4GpSmJyWtZgX4L?=
 =?iso-8859-1?Q?jtNsCkSiw9LNYx3alX5f2LaLvopmpRo/2xPwQ3ZdzcoZ2TRQQkT0lEvvXM?=
 =?iso-8859-1?Q?YNUxXOvibSAmqNeRLRNxDl6EugDSUsvVBbl7VQ9j0eYthRD7D7hJyZRsXC?=
 =?iso-8859-1?Q?qY7U+W303Mf+xU/oY7tcn1kPwMyFzqDQB/YTr3DouTXYstCNIbcoD0hCxf?=
 =?iso-8859-1?Q?3fbczJpI+Byc+YI/BRU92Ftp43e3HfI/aHzErrI/g6ZZ6bq0Pt6/Wgx51z?=
 =?iso-8859-1?Q?G6l1BzLVc0EdA3UIzGtCKESHW9zrEcL3oa86gyG/AxWYbK+ETryoV/6m/T?=
 =?iso-8859-1?Q?KJWSdsuYT6E5vgZJWnzKBnpAIq4CwMw1pDZwymS21XdYVa7v0t5ljYB+f6?=
 =?iso-8859-1?Q?Spp+BifEFNel1daw1CP3BxfaitFO9mMnNb5glxiARsgBlGvrOvZzyir2v+?=
 =?iso-8859-1?Q?CEb3KpU7WHRCjL85YgRUAM6cF2BDI9CNyAV21V33zoteiKHosTj10uBtLi?=
 =?iso-8859-1?Q?+MEF+CiXw8jKkCs0btjSYbfnInSS3DMgnh/KcapmflNPoBaPk2qMjmyvAn?=
 =?iso-8859-1?Q?mzXtx99FfTJT0t5scLgKTLuyR9vSdhj8d9?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebdef7c1-101e-4f68-43af-08dc608c6b9c
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8877.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 16:18:59.9312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Za5/9CiocfwRSHwm9ZRDmLqOrKASb3stvGqLjT/kvU9rrX/CfEAW95eDWRDjOkNqr4Qh31COUgHID2UKJzVVSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9792

On Thu, Apr 18, 2024 at 04:18:01PM +0000, Asbj?rn Sloth T?nnesen wrote:
> This driver currently doesn't support any control flags.
> 
> Use flow_rule_match_has_control_flags() to check for control flags,
> such as can be set through `tc flower ... ip_flags frag`.
> 
> In case any control flags are masked, flow_rule_match_has_control_flags()
> sets a NL extended error message, and we return -EOPNOTSUPP.
> 
> Only compile-tested.
> 
> Signed-off-by: Asbj?rn Sloth T?nnesen <ast@fiberby.net>

Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com>