Received-SPF: pass (google.com: domain of linux-kernel+bounces-151542-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Apr 2024 21:59:11 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Isaku Yamahata <isaku.yamahata@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, xiaoyao.li@intel.com,
	binbin.wu@linux.intel.com, seanjc@google.com,
	rick.p.edgecombe@intel.com, isaku.yamahata@linux.intel.com
Subject: Re: [PATCH 2/7] KVM: Add KVM_MAP_MEMORY vcpu ioctl to pre-populate
 guest memory
Message-ID: <ZiJ4r70tsphVk45Q@yilunxu-OptiPlex-7050>
References: <20240417153450.3608097-1-pbonzini@redhat.com>
 <20240417153450.3608097-3-pbonzini@redhat.com>
 <20240417193625.GJ3039520@ls.amr.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417193625.GJ3039520@ls.amr.corp.intel.com>

> > +#ifdef CONFIG_KVM_GENERIC_MAP_MEMORY
> > +	case KVM_CAP_MAP_MEMORY:
> > +		if (!kvm)
> > +			return 1;
> > +		/* Leave per-VM implementation to kvm_vm_ioctl_check_extension().  */
> 
> nitpick:
>                 fallthough;

A little tricky. 'break;' should be more straightforward.  

Thanks,
Yilun

> 
> >  #endif
> >  	default:
> >  		break;
> > -- 
> > 2.43.0
> > 
> > 
> > 
> 
> -- 
> Isaku Yamahata <isaku.yamahata@intel.com>
>