Received-SPF: pass (google.com: domain of linux-kernel+bounces-151756-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Li, Xin3" <xin3.li@intel.com>
To: "Gao, Chao" <chao.gao@intel.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "linux-doc@vger.kernel.org"
	<linux-doc@vger.kernel.org>, "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>, "seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "corbet@lwn.net"
	<corbet@lwn.net>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "x86@kernel.org"
	<x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "shuah@kernel.org"
	<shuah@kernel.org>, "vkuznets@redhat.com" <vkuznets@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>, "Shankar, Ravi V"
	<ravi.v.shankar@intel.com>, "xin@zytor.com" <xin@zytor.com>
Subject: RE: [PATCH v2 09/25] KVM: VMX: Switch FRED RSP0 between host and
 guest
Thread-Topic: [PATCH v2 09/25] KVM: VMX: Switch FRED RSP0 between host and
 guest
Thread-Index: AQHaWe/p8mDo/Zfb1Ue0O++EkKDe07FwFkwAgAAja6A=
Date: Fri, 19 Apr 2024 16:37:24 +0000
Message-ID: <SA1PR11MB6734AC2442F6615CB3DA7203A80D2@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20240207172646.3981-1-xin3.li@intel.com>
 <20240207172646.3981-10-xin3.li@intel.com> <ZiJ+RkHDJzalqN05@chao-email>
In-Reply-To: <ZiJ+RkHDJzalqN05@chao-email>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jw+syHabGdQG9RaRPwK+NFwlQ6hDzZPkobtCtmL1ZPVJlpYyKKizYJg66br5?=
 =?us-ascii?Q?UTKXkVnBiAk82mBTDliQ+y/DWYuh2kFJtr2J0lTf0og+64gvkTvBe5/Ki5MP?=
 =?us-ascii?Q?dtn6aJYK0ysRe+WUIkyuUp2ob6mObUcIs8oe/lMRiHmAw3wFb2tDqek4i46w?=
 =?us-ascii?Q?S8NKNd1jhOdcr8lf8rrYSHtliLIbF9pP86yoRv166Rc6vd0yKNd3U/AXaqcA?=
 =?us-ascii?Q?IgQUgufZfnIJSYygiTxze0FN4FXAwmwTPq879nIzcI9HPPZNg7Jx24WfVsJm?=
 =?us-ascii?Q?EXbQnEAXTt+9sWdtyCdh0UDpvifZVOu4AheyjZaGvTIw9Y8+o+ZmeHDTW2Sc?=
 =?us-ascii?Q?TYH9tl3Ve4/epDKQPyqeE4JjhyS/k4J4W4ETHFDU62y0AGS6FIJqiz3TyigD?=
 =?us-ascii?Q?NDA8Uyb2K2wPX8lWolrHgGTwtiqB4Wf4QkolJbqjr9Keh35ZB8jsrMkC673/?=
 =?us-ascii?Q?2yBHsum+p90muL1HhXhMsBW2r88Kuar+hictdkqbNYhqwtSFD5QwATQ9QEMw?=
 =?us-ascii?Q?9vyURPUUabiNAmjA8djstTPjJoATIdTz/sC4Nl4bu8ds7z/pJzIcbmhLi+FG?=
 =?us-ascii?Q?duxntDKFphFHXL76JA4uNmJ3d0dMLNPWkCa0MLW7w/y+wPBvdLx3ZSlZumix?=
 =?us-ascii?Q?sWTnb/GZnIjcM3bqP5YMqs2X4QsSAN1vtfHbWFHDHhLoQaviajHvhrysLrl1?=
 =?us-ascii?Q?qPU4nAQmxq/z8MXcmrn5Z8dz6k4beYaUhnNw7Z5cm0dZhhOgnBJA+HVyATPd?=
 =?us-ascii?Q?X7EavX8NP402fRZke6mZ3m6wbROd7sijC3nkHJ0vxcZclrVb4h2zefwb11er?=
 =?us-ascii?Q?oKV0nr/Mvc3lSLTUXoeIQTnk+j59Q0hUyKFort9FfExazhg+qiUZ62vMFm+a?=
 =?us-ascii?Q?UVMU8dCmP0LzLmnBhsexTrezpM8iiypb0t5lVB7vnNnwaoInkgFba+UAnJBu?=
 =?us-ascii?Q?3RStuDzN1k73Nhejgl6apECUzPiEbD72XOIMM9xSNnvNjyJ3OvUHGC5VVKTD?=
 =?us-ascii?Q?mOmTHqDw1oMYVRPfjNDw+KYYPBM9QOYOBRjG2TsLZUdxkPBlf7tXBPQoVqoH?=
 =?us-ascii?Q?f+80e5Mj1zHXmg9RpLkF/9saV3v8kxNl8ACXZakVHRCxLqL821UVW/xilcPu?=
 =?us-ascii?Q?2uL3v+FiT7r2w+m4pih+GJqitoQnW3K3hUcBIChHDCdaUulQBCuURmg5Jqa4?=
 =?us-ascii?Q?QnzddKWQK+6r71F3gtmd4DUCcKZVfzLusMVIfOXaREqS7oNw6/Z09JmLC9sW?=
 =?us-ascii?Q?q/crg619q+bV8soUHnBDzFcmAtdCXrgYcHdNgDn1AGMHTeoi4SazsZTI8noM?=
 =?us-ascii?Q?gv4YEl9KZx7DPYbIV2PuYUPnoJV1SI5cVnKWkvTcWwJQodUnhIT9a6EO7oRQ?=
 =?us-ascii?Q?u9/F6vmc7sdKziNtxn+ASHiyaYVqdV47N/6Ps+PHhDRYt+bi4FQzS/O+UNNJ?=
 =?us-ascii?Q?1otTM5Wv30cxtWJlspc4rBMklDwI6iEhr3wTpLw6CSePtuB0o3cyHudIVXOE?=
 =?us-ascii?Q?KIEbqcqCktjMDgrFDSCFmVAnW6BvwmgcogtmhqjWWj9um8g6NBrMYr1zpOBl?=
 =?us-ascii?Q?GdZjSKvz8ozgsIIAMGTqA60s6vJAv0Z6tsMzx0GJ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4200ee6b-5c61-454b-324a-08dc608efdde
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2024 16:37:24.0510
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1MoKENc4arE40Oa4qVGM8RbvW+g7gcYlwcF8rrvAVOzSU2goErfAh1FsfiVcIghTHi1epXkVDAHq6PJvrd2acQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8051
X-OriginatorOrg: intel.com

> >+		if (unlikely(vmx->msr_host_fred_rsp0 =3D=3D 0))
> >+			vmx->msr_host_fred_rsp0 =3D
> read_msr(MSR_IA32_FRED_RSP0);
>=20
> can we just drop this and use "(unsigned long)task_stack_page(current) +
> THREAD_SIZE"
> as host fred rsp0?

I thought about it, however, don't see a strong reason that it's better,
 i.e., is RDMSR slower than reading 'stack' from current task_struct?

>=20
> >+		wrmsrl(MSR_IA32_FRED_RSP0, vmx->msr_guest_fred_rsp0);
>=20
> any reason to not use wrmsrns?

Good call!


> >+	}
> > #else
> > 	savesegment(fs, fs_sel);
> > 	savesegment(gs, gs_sel);
> >@@ -1381,6 +1391,11 @@ static void vmx_prepare_switch_to_host(struct
> vcpu_vmx *vmx)
> > 	invalidate_tss_limit();
> > #ifdef CONFIG_X86_64
> > 	wrmsrl(MSR_KERNEL_GS_BASE, vmx->msr_host_kernel_gs_base);
> >+
> >+	if (guest_can_use(&vmx->vcpu, X86_FEATURE_FRED)) {
> >+		vmx->msr_guest_fred_rsp0 =3D read_msr(MSR_IA32_FRED_RSP0);
> >+		wrmsrl(MSR_IA32_FRED_RSP0, vmx->msr_host_fred_rsp0);
>=20
> same question.

Will do!

Thanks!
    Xin