Received-SPF: pass (google.com: domain of linux-kernel+bounces-151780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 19 Apr 2024 09:51:52 -0700
From: Shradha Gupta <shradhagupta@linux.microsoft.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: Easwar Hariharan <eahariha@linux.microsoft.com>,
	Ani Sinha <anisinha@redhat.com>, KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Add a header in ifcfg and nm keyfiles describing the
 owner of the files
Message-ID: <20240419165152.GA506@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240418120549.59018-1-anisinha@redhat.com>
 <19df975d-167f-424a-92ce-5135cbeb8a07@linux.microsoft.com>
 <CY5PR21MB3759203A552E72B7F2669FACBF0E2@CY5PR21MB3759.namprd21.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CY5PR21MB3759203A552E72B7F2669FACBF0E2@CY5PR21MB3759.namprd21.prod.outlook.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Thu, Apr 18, 2024 at 07:01:20PM +0000, Dexuan Cui wrote:
> > From: Easwar Hariharan <eahariha@linux.microsoft.com>
> > Sent: Thursday, April 18, 2024 9:16 AM
> > 
> > On 4/18/2024 5:05 AM, Ani Sinha wrote:
> > > A comment describing the source of writing the contents of the ifcfg and
> > > network manager keyfiles (hyperv kvp daemon) is useful. It is valuable
> 
> s/hyperv/Hyper-V/
> 
> > > +#define CFG_HEADER "# Generated by hyperv key-value pair daemon.
> > Please do not modify.\n"
> 
> s/hyperv/Hyper-V/
> 
> > Looks good to me, I'll defer to other folks on the recipient list on whether
> > "hyperv" should be capitalized as HyperV or other such feedback.
> 
> It's recommended to use "Hyper-V". Wei can help fix this so I guess
> there is no need to resend the patch :-)
Sounds good!