Received-SPF: pass (google.com: domain of linux-kernel+bounces-151802-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Li, Xin3" <xin3.li@intel.com>
To: "Gao, Chao" <chao.gao@intel.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "linux-doc@vger.kernel.org"
	<linux-doc@vger.kernel.org>, "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>, "seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "corbet@lwn.net"
	<corbet@lwn.net>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "x86@kernel.org"
	<x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "shuah@kernel.org"
	<shuah@kernel.org>, "vkuznets@redhat.com" <vkuznets@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>, "Shankar, Ravi V"
	<ravi.v.shankar@intel.com>, "xin@zytor.com" <xin@zytor.com>
Subject: RE: [PATCH v2 08/25] KVM: VMX: Initialize VMCS FRED fields
Thread-Topic: [PATCH v2 08/25] KVM: VMX: Initialize VMCS FRED fields
Thread-Index: AQHaWfAGYi3jnyVfhUO4UU7qBPwTVbFwEDkAgAAvQkA=
Date: Fri, 19 Apr 2024 17:02:59 +0000
Message-ID: <SA1PR11MB67343F4567F769E3262A27F9A80D2@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20240207172646.3981-1-xin3.li@intel.com>
 <20240207172646.3981-9-xin3.li@intel.com> <ZiJ5LrjddiLticvR@chao-email>
In-Reply-To: <ZiJ5LrjddiLticvR@chao-email>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7A0HnII6GAZeYvSiNkOyFAdq3cZ+EAxcqSB0xNXRbgV3SBy3Bz+zsJLubew0?=
 =?us-ascii?Q?I48tCwcMVIPLhu8O0d8765nRJp7Om1EtUW+X6SJh98PcSvM8PPmUNEWf4vaL?=
 =?us-ascii?Q?9G8hRUdjmcwd4ioLokFCZWi+YKw7PViDj9hpM2si35gJP0wdWfCOzqf6lqiz?=
 =?us-ascii?Q?bsfRCp2yqaPtXhdU456oAtIhQOws7/1nHT91kai0SOedznm1Hnlsw5vco08W?=
 =?us-ascii?Q?2OfxhQH4EAInTmpVG1VqYYxUYYrlnSxW9/2w5JoCrDKu9Ofe8V8kHQ1cpCL2?=
 =?us-ascii?Q?GrUeJCulOUV2+JgkuQLrYt8SeqKZk7w4e+C4kKumO+y4oNS8CU99X0WbFn6I?=
 =?us-ascii?Q?Cda925P11RvpToV+kXypHJytGKpm5eay4LteMM9ev+yjPaL820twi2ZiiPw5?=
 =?us-ascii?Q?3lkI0Capls1r1rj1w4YbUUN+QPak1Z/1cd/RA6f29yoPE2u8KzajM/HfQhkN?=
 =?us-ascii?Q?3pdoyhewvSkdpdkNhlqqrMaBK0CWLiWO01Gq77MpFwrBYSTntp0GBzg/+gLK?=
 =?us-ascii?Q?P11YURU0JfTqhgMNEZUBYmErOrJVY9o1ruEALnLuc7M95SRPh4496F8UxebF?=
 =?us-ascii?Q?8ZH1dzGKUILYNZGheSTDw7q1KOioscWEYqEeTzebgoLhlpkqtF+nekQD7Ajg?=
 =?us-ascii?Q?oTUpjaHtj17kcW/FNeJiCXDl0NaBjChIEzWutwYBBfUe+erXJ6CWGnp06/z7?=
 =?us-ascii?Q?xG1OwNI4QSpXjQhzt5wLlh58ozdbJwGNGvQ6ozs9shwt/j2yV/7Z1BELkKNB?=
 =?us-ascii?Q?cgVjhVHWEctir5CLb6P17UUbyJcpqXyUDO1Vw536i2WBud2Jqy1tX0eJ8xir?=
 =?us-ascii?Q?U5Slqx0ptjOkq6rhz3+JHus02WJlK3OpB2gnsxvZ5f/uenKFXMthk/M7HVg0?=
 =?us-ascii?Q?PSEdRLeMcxWEnm4B/LZCAOFaat9U1uWKVvQZCwjQxQi/JnN2+6pNomWNxsRb?=
 =?us-ascii?Q?TjMx3+CO8tVAX2XH6ThqwQB8ac8bq8G5ELPzcg0pg8AdYN6DniB3yJYlrckn?=
 =?us-ascii?Q?hAzmLtczY4qRc4dZSnsh5yu9zWp0uiblYg1vOPAv9TsUAtP7ya4Epj8AniRW?=
 =?us-ascii?Q?YQkrd4Z93JhTa2SowM0rQ1lhubotnkpIpCGs5NXKCubjJwhiey8perVuqdbZ?=
 =?us-ascii?Q?MTSrwikZWx5c+MUYDV1zVavGYVHl04JheJkE+lDks2GoAiDiB0VFVwzme2xC?=
 =?us-ascii?Q?BczpBuEjTkdb/AzlpTBfKbctGWdcBkYFXXM9yGHDd7aH6EGCqqiqN6E/6r4F?=
 =?us-ascii?Q?4uExHE3y9HlCP4VdAhsJxg9BO5+d80s3SI+5K/VgTvvNRVpex/5KQnSEgGaM?=
 =?us-ascii?Q?ypB0ePbn6XdU/nGPGQcIoyU+A489UOHksOTqOF8uZk/dMQGg9K7hHjCd68Vn?=
 =?us-ascii?Q?3eGFXMAztw+L+gAyzsdm6YXelC599qDQRngKJFTz/j5Y5xStARjrxsJL+vR/?=
 =?us-ascii?Q?vUEn9pDfrtaY4UwtiXcWTeL3LQQlxeY/OWdn+/8MLHpOF4iZ0osu1A/sZU05?=
 =?us-ascii?Q?xtOdHEZj5Itoxudocwmo6UtPAqDi+0YI2F4zsLXRV7ZGxfVzpSa41tYQShA2?=
 =?us-ascii?Q?VEYUT3drtXGrRUGWUeapqsKtCl8UMmxK70k0CeHn?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d95399a1-cb8a-4500-e509-08dc60929104
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2024 17:02:59.4048
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 24sJlHVj365fWFWPDv1dJdUELlWnWLAdhfiLOafRq35d3ERdRJ0V2eVYsinlLmJ9pCB/GuxWDHYw06AWSmGYzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7470
X-OriginatorOrg: intel.com

> >+#ifdef CONFIG_X86_64
>=20
> is this #ifdeffery neccesary?

Yes, otherwise build fails on 32 bit.

>=20
> I assume kvm_cpu_cap_has(X86_FEATURE_FRED) is always false
> for !CONFIG_X86_64.
> Looks most of FRED changes in core kernel don't have such #ifdeffery.

Because it's not a compile time false, instead false from runtime.

>=20
> >+		/* Per-CPU FRED MSRs */
>=20
> Please explain why these six MSRs are updated here and why only they are =
updated in
> this comment.

The explanation is kind of implicit "per-CPU", I will make it more explicit=
=09

Thanks!
    Xin