Received-SPF: pass (google.com: domain of linux-kernel+bounces-151816-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 20 Apr 2024 01:22:33 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
CC: Xuewen Yan <xuewen.yan94@gmail.com>, Abel Wu <wuyun.abel@bytedance.com>,
	Ingo Molnar <mingo@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <juri.lelli@redhat.com>, Tim Chen <tim.c.chen@intel.com>, "Tiwei
 Bie" <tiwei.btw@antgroup.com>, Honglei Wang <wanghonglei@didichuxing.com>,
	Aaron Lu <aaron.lu@intel.com>, Chen Yu <yu.chen.surf@gmail.com>, Yujie Liu
	<yujie.liu@intel.com>, <linux-kernel@vger.kernel.org>, kernel test robot
	<oliver.sang@intel.com>, Tianchen Ding <dtcccc@linux.alibaba.com>
Subject: Re: [RFC PATCH] sched/eevdf: Return leftmost entity in pick_eevdf()
 if no eligible entity is found
Message-ID: <ZiKoWSlTD8oSWI0R@chenyu5-mobl2>
References: <758ebf4e-ee84-414b-99ec-182537bcc168@bytedance.com>
 <20240408115833.GF21904@noisy.programming.kicks-ass.net>
 <ZhPtCyRmPxa0DpMe@chenyu5-mobl2>
 <20240409092104.GA2665@noisy.programming.kicks-ass.net>
 <ZiAWTU5xb/JMn/Hs@chenyu5-mobl2>
 <CAB8ipk-fejQ41Jgk6z52+T6CP+impwbaOAfhA9vG_-FB9BeRyw@mail.gmail.com>
 <ZiEaKOQwiNEglYtS@chenyu5-mobl2>
 <20240419082440.GB6345@noisy.programming.kicks-ass.net>
 <ZiJBqRafMdBi+wCV@chenyu5-mobl2>
 <20240419162428.GB23130@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240419162428.GB23130@noisy.programming.kicks-ass.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5XXL5KCL+xFth9rUgWI4mbpO/7cdLFVWrZpZ3kteMq5fyktGK9G/4zJWu/vG?=
 =?us-ascii?Q?9rPhVL4nqCekC1woW1vhcAfYOEv1jDlfnStiWdu5/6EK5eRuCX+8Tg75txmu?=
 =?us-ascii?Q?KfsArmjwCOd41/14QiC3oQTlcXk9c1Hj3BW6iaQDmd9dsCzMIX/gaeRIZiTv?=
 =?us-ascii?Q?IVnfd/+6mYfDv81czND/aD0lsYuGxRaffFPcS9+JVOjVZDdfQJTRksFZoXD+?=
 =?us-ascii?Q?iiPoBGXXV+3cg3Iss4HDqWcCq9EH3ghY+8EF/6UjDVlNLX9MHG/6rxaVh9zL?=
 =?us-ascii?Q?3r0yXW4yQwug0EcCmb0MWOlCMXKZX63Gb2EUL8CbpLWNO4OwLP3kPJFr7f80?=
 =?us-ascii?Q?jorSKKt0sIVlg3XY6VuXXSPEI4mo4/3T1DORC2a2z++Mgcq5Vu1mJy0uUplR?=
 =?us-ascii?Q?A9LROxoWqhSpFg1vJj33haKbSPGz8FbGjd/KTi24ZJwrSJJLTVXaS4eoVHbR?=
 =?us-ascii?Q?krOSS5hoirpf9LZMqv7LYfcIFoF9JGnv3S9k+UwDMFAUhBqUaZr86/2v5bJv?=
 =?us-ascii?Q?eQUNb/WOKDhTMHYlB0BeDKyBzsmGyeVV2a4QKal8wTUR/SQRD9D7eBtuQ8YN?=
 =?us-ascii?Q?shBlxlulCQkUeD3fRZqgcbTCuKhUCq6PX0VVCcpyCVhrgiDA5grO8yO8EQty?=
 =?us-ascii?Q?mpCLknHIcfY3t7tLEXNR39Z0+X6ZDPb9hQQyaRW6imeKk8Rq8EGYkD6xDbPL?=
 =?us-ascii?Q?KkoAFMv7WkyH7HOdGdGLIDhjJ3iUAj5QAWFqo5FDdG4PfDz5o+H9LFkoAraD?=
 =?us-ascii?Q?VYlgQMHzKC/JYIi31rD6mbylQuNJTpbFeRhY00j8/U7tzQ75JHr7fnj17Lcm?=
 =?us-ascii?Q?aUXdsvvRTFdUmscPkZfAWqiPZRsdzCHljRG7xVIlyC3H/N23e0MP6vpvAK6c?=
 =?us-ascii?Q?SXhiekY1igBOs+zH3FlR9XHFLGRL+SGWO/dgWS+xXpm2cCOjAea3DTvC9Ipn?=
 =?us-ascii?Q?vAVyYqC0HHG/ZEUF2QW/+slAu2OoRycnydbz1onvlUQl6GIsUEAi3+K+dPL/?=
 =?us-ascii?Q?KBtAl+f/ywdB0bAYS5nn4/Wu6kjI9e4e5IGejQoqNRGcXjqzOA3KsceIuHys?=
 =?us-ascii?Q?Aaft4rCTfcQam/Se6Q267SkLOtAaq3bJORmjXWf3wXQsQmmnjCERg96Ckx44?=
 =?us-ascii?Q?RUg1vv0JvEFuMVvu0B01uL1xnYIc8LiFtCPUsIOUJQclX+LTiD/TipdbsDQT?=
 =?us-ascii?Q?vRKwQ4tzO06wy0bm7U4whhJ+hgxnRKnusVIZsliFKycco6ct5KJmwFu3zq5M?=
 =?us-ascii?Q?2qqLeCmIZNZHf3GBTSlannChDUag844tPAxeTHjdqqe/WBPhwDLRRTTuKUSA?=
 =?us-ascii?Q?Kg11bsoFE1RZ9KuG6dPw8d9QzEDwhiTnOuYSIRYWdcZhVvTXXnk61Ip2hAZY?=
 =?us-ascii?Q?7wkqzT0GAWd/akCQof1hLpViSWSpLa7nVuDXMgDJnaxmfLllmlUTI4pVoYO9?=
 =?us-ascii?Q?Mko0ztx/20exCHLQEOLd2yValOO53x3ZUHLXImwnpI6U95BP0B9HUVwb6fkq?=
 =?us-ascii?Q?ZSA04IgYT8kr3Jmd3Bla+uFua3mJyxFtpqdvPpzcls/JcIHR8E8PidDK46ug?=
 =?us-ascii?Q?UOoYyU3Y6BzVQhDyLNX6f9onBojFYEvhY5CXpMe2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8aef1d1a-b09e-4dfa-4c3b-08dc6095554e
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 17:22:48.0463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GkNyUcsvft0fMoxcuWO/4iAXh1rlHlfNkI3flKGd0nZj+qeePE19Qec0zarXu8dNw8JWIc6m9c0U9SYRyRBdew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176
X-OriginatorOrg: intel.com

On 2024-04-19 at 18:24:28 +0200, Peter Zijlstra wrote:
> On Fri, Apr 19, 2024 at 06:04:25PM +0800, Chen Yu wrote:
> 
> > > Also, could you put a few words in on how often these clips are hit? I
> > > suspect it's fairly rare (but crucial when it does).
> > 
> > Everytime it happens a subsequent NULL pointer exception usually happens.
> > The trace data was posted here: 
> 
> That was not the question. Suppose I put a printk whenever the clamp()
> actually changes the value, do I get a stormflood of output, or do I get
> a sporadic blip.

I see, it is not a frequent clamp - around 5~30 clamp per CPU every second,
when running trinity.

thanks,
Chenyu