Received-SPF: pass (google.com: domain of linux-kernel+bounces-151826-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Apr 2024 10:34:29 -0700
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Zijlstra <peterz@infradead.org>, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 1/2] cpu: Re-enable CPU mitigations by default for !X86
 architectures
Message-ID: <20240419173429.dj6nzgg3t23f52ol@treble>
References: <20240417001507.2264512-1-seanjc@google.com>
 <20240417001507.2264512-2-seanjc@google.com>
 <20240419160537.namt5yaxhhvwwa3r@treble>
 <ZiKgAh1aNBGHpOof@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZiKgAh1aNBGHpOof@google.com>

On Fri, Apr 19, 2024 at 09:46:58AM -0700, Sean Christopherson wrote:
> > It seems confusing to have two config options which have very similar
> > names and similar purposes (with subtle differences depending on the
> > arch).
> > 
> > How about we instead just get rid of the x86-specific
> > SPECULATION_MITIGATIONS and replace it with a menu which depends on
> > CPU_MITIGATIONS:
> 
> Huh, didn't realize that was possible.
> 
> I agree that having two things for the same thing is confusing, though Boris'
> idea to do s/SPECULATION_MITIGATIONS/X86_CPU_MITIGATIONS would help a fair bit
> on that front.
> 
> My only hesitation is that x86's menu and the common config knob end up in
> completely different locations.

I'm thinking this is a minor issue because CPU_MITIGATIONS is enabled by
default, so it should almost always be enabled unless the user disables
it, in which case they wouldn't be looking for the x86-specific
mitigations anyway.

Regardless it seems very common for a menu "depends on" to be in a
different file.  We could put CPU_MITIGATIONS in arch/Kconfig which is a
fairly logical place for the dependency.

-- 
Josh