Received-SPF: pass (google.com: domain of linux-kernel+bounces-151832-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
From: Shresth Prasad <shresthprasad7@gmail.com>
Date: Fri, 19 Apr 2024 23:16:37 +0530
Message-ID: <CAE8VWiLErhCkD9w+Rbh8mTnRQs-4iJDBrWdVXXFFFDQ3yeTaLg@mail.gmail.com>
Subject: Re: [PATCH] drivers: use __free attribute instead of of_node_put()
To: vincenzo.mezzela@gmail.com
Cc: gregkh@linuxfoundation.org, 
	Javier Carrasco <javier.carrasco.cruz@gmail.com>, Julia Lawall <julia.lawall@inria.fr>, 
	linux-kernel@vger.kernel.org, rafael@kernel.org, 
	Shuah Khan <skhan@linuxfoundation.org>, sudeep.holla@arm.com
Content-Type: text/plain; charset="UTF-8"

> Please fix the subject line to be "backlight: <driver>: ...". I came
> very close to deleting this patch without reading it ;-) .

Really sorry about that, I'll fix it.

> Do we need to get dev->of_node at all? The device, which we are
> borrowing, already owns a reference to the node so I don't see
> any point in this function taking an extra one.
>
> So why not simply make this:
>
>     struct device_node *np = dev->of_node;

Looking at it again, I'm not sure why the call to of_node_put is there in
the first place. I think removing it would be fine.

I'll fix both of these issues and send a patch v2.

Regards,
Shresth