Received-SPF: pass (google.com: domain of linux-kernel+bounces-151858-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240418-alice-mm-v6-0-cb8f3e5d688f@google.com>
 <20240418-alice-mm-v6-1-cb8f3e5d688f@google.com> <ZiKltinLGvKlBivm@boqun-archlinux>
In-Reply-To: <ZiKltinLGvKlBivm@boqun-archlinux>
From: Alice Ryhl <aliceryhl@google.com>
Date: Fri, 19 Apr 2024 20:12:24 +0200
Message-ID: <CAH5fLgh0rFMQcAA4a=Vk8uEkyHP455KeihR-2BkkOpgHS6teKA@mail.gmail.com>
Subject: Re: [PATCH v6 1/4] rust: uaccess: add userspace pointers
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>, Matthew Wilcox <willy@infradead.org>, 
	Al Viro <viro@zeniv.linux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, 
	Kees Cook <keescook@chromium.org>, Alex Gaynor <alex.gaynor@gmail.com>, 
	Wedson Almeida Filho <wedsonaf@gmail.com>, Gary Guo <gary@garyguo.net>, 
	=?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, 
	Benno Lossin <benno.lossin@proton.me>, Andreas Hindborg <a.hindborg@samsung.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>, 
	Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>, 
	Joel Fernandes <joel@joelfernandes.org>, Carlos Llamas <cmllamas@google.com>, 
	Suren Baghdasaryan <surenb@google.com>, Arnd Bergmann <arnd@arndb.de>, Trevor Gross <tmgross@umich.edu>, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	rust-for-linux@vger.kernel.org, Christian Brauner <brauner@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 19, 2024 at 7:11=E2=80=AFPM Boqun Feng <boqun.feng@gmail.com> w=
rote:
>
> On Thu, Apr 18, 2024 at 08:59:17AM +0000, Alice Ryhl wrote:
> [...]
> > +    /// Reads the entirety of the user slice, appending it to the end =
of the provided buffer.
> > +    ///
> > +    /// Fails with `EFAULT` if the read happens on a bad address.
> > +    pub fn read_all(mut self, buf: &mut Vec<u8>, flags: Flags) -> Resu=
lt {
> > +        let len =3D self.length;
> > +        buf.reserve(len, flags)?;
>
> (Reportedy by Miguel)
>
> When compile with `make rusttest`, kernel crate is compiled as userspace
> program, so we need to explicitly pick where the `reserve` comes from
> (Vec or VecExt), the current version will hit the following error:
>
>         error[E0061]: this method takes 1 argument but 2 arguments were s=
upplied
>            --> rust/kernel/uaccess.rs:296:13
>             |
>         296 |         buf.reserve(len, flags)?;
>             |             ^^^^^^^    -------
>             |                        | |
>             |                        | unexpected argument of type `Flags=
`
>             |                        help: remove the extra argument
>             |
>         note: method defined here
>            --> /home/boqun/linux-rust/rust/test/sysroot/lib/rustlib/src/r=
ust/library/alloc/src/vec/mod.rs:910:12
>             |
>         910 |     pub fn reserve(&mut self, additional: usize) {
>             |            ^^^^^^^
>
>         error[E0277]: the `?` operator can only be applied to values that=
 implement `Try`
>            --> rust/kernel/uaccess.rs:296:9
>             |
>         296 |         buf.reserve(len, flags)?;
>             |         ^^^^^^^^^^^^^^^^^^^^^^^^ the `?` operator cannot be=
 applied to type `()`
>             |
>             =3D help: the trait `Try` is not implemented for `()`
>
>         error: aborting due to 2 previous errors
>
>         Some errors have detailed explanations: E0061, E0277.
>         For more information about an error, try `rustc --explain E0061`.
>
> and we need to the following fix
>
> diff --git a/rust/kernel/uaccess.rs b/rust/kernel/uaccess.rs
> index 39481e374c40..80f7e7ca2f5e 100644
> --- a/rust/kernel/uaccess.rs
> +++ b/rust/kernel/uaccess.rs
> @@ -293,7 +293,7 @@ pub fn read<T: FromBytes>(&mut self) -> Result<T> {
>      /// Fails with `EFAULT` if the read happens on a bad address.
>      pub fn read_all(mut self, buf: &mut Vec<u8>, flags: Flags) -> Result=
 {
>          let len =3D self.length;
> -        buf.reserve(len, flags)?;
> +        VecExt::<u8>::reserve(buf, len, flags)?;
>
>          // The call to `try_reserve` was successful, so the spare capaci=
ty is at least `len` bytes
>          // long.

I'm sorry, what? This seems like a problem with `make rusttest`.

Alice