Received-SPF: pass (google.com: domain of linux-kernel+bounces-151879-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 20 Apr 2024 00:09:56 +0530 (GMT+05:30)
From: Shresth Prasad <shresthprasad7@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: vincenzo.mezzela@gmail.com, gregkh@linuxfoundation.org,
	Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	Julia Lawall <julia.lawall@inria.fr>, linux-kernel@vger.kernel.org,
	rafael@kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <5128b428-c26e-46ea-8289-1e7580f4fbf8@gmail.com>
In-Reply-To: <20240419182642.b7li4mlnvryephhg@bogus>
References: <CAE8VWiLErhCkD9w+Rbh8mTnRQs-4iJDBrWdVXXFFFDQ3yeTaLg@mail.gmail.com> <20240419182642.b7li4mlnvryephhg@bogus>
Subject: Re: [PATCH] drivers: use __free attribute instead of of_node_put()
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

19 Apr 2024 11:56:47 pm Sudeep Holla <sudeep.holla@arm.com>:

> On Fri, Apr 19, 2024 at 11:16:37PM +0530, Shresth Prasad wrote:
>>> Please fix the subject line to be "backlight: <driver>: ...". I came
>>> very close to deleting this patch without reading it ;-) .
>>=20
>> Really sorry about that, I'll fix it.
>>=20
>>> Do we need to get dev->of_node at all? The device, which we are
>>> borrowing, already owns a reference to the node so I don't see
>>> any point in this function taking an extra one.
>>>=20
>>> So why not simply make this:
>>>=20
>>> =C2=A0=C2=A0=C2=A0 struct device_node *np =3D dev->of_node;
>>=20
>> Looking at it again, I'm not sure why the call to of_node_put is there i=
n
>> the first place. I think removing it would be fine.
>>=20
>> I'll fix both of these issues and send a patch v2.
>=20
> I assume you are using lore "Reply using the --to, --cc, and..." option
> or something similar.
>=20
> You seem to have mixed up 2 different message ID. I was not able to make
> any sense of this email.
>=20
> You have wrongly used [1] but you really want [2]. I think both have
> very similar $subject and hence the confusion. Another reason
> why getting subject right is very important on the mailing list.
>=20
> --=20
> Regards,
> Sudeep
>=20
> [1] 20240419131956.665769-1-vincenzo.mezzela@gmail.com
> (https://lore.kernel.org/all/20240419131956.665769-1-vincenzo.mezzela@gma=
il.com/)
> [2] 20240419111613.GA12884@aspen.lan
> https://lore.kernel.org/all/20240419111613.GA12884@aspen.lan/
I'm very new to using mailing lists, sorry for any confusion. I was indeed =
using the reply option on lore. I'll be more careful next.

Is there anyway to remove the incorrect reply from this thread?

Regards,
Shresth Prasad