Received-SPF: pass (google.com: domain of linux-kernel+bounces-151882-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <80a764dc-b54c-443b-9832-977ab9f6d7cf@arm.com>
Date: Fri, 19 Apr 2024 19:50:09 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 15/16] thermal: core: Drop the .throttle() governor
 callback
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
References: <13515747.uLZWGnKmhe@kreacher> <2701448.BddDVKsqQX@kreacher>
Content-Language: en-US
From: Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <2701448.BddDVKsqQX@kreacher>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 4/10/24 18:42, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Since all of the governors in the tree have been switched over to using
> the new callbacks, either .trip_crossed() or .manage(), the .throttle()
> governor callback is not used any more, so drop it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/thermal/thermal_core.c |   11 -----------
>   drivers/thermal/thermal_core.h |    4 ----
>   2 files changed, 15 deletions(-)
> 
> Index: linux-pm/drivers/thermal/thermal_core.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_core.c
> +++ linux-pm/drivers/thermal/thermal_core.c
> @@ -310,15 +310,6 @@ static struct thermal_governor *thermal_
>   	return def_governor;
>   }
>   
> -static void handle_non_critical_trips(struct thermal_zone_device *tz,
> -				      const struct thermal_trip *trip)
> -{
> -	struct thermal_governor *governor = thermal_get_tz_governor(tz);
> -
> -	if (governor->throttle)
> -		governor->throttle(tz, trip);
> -}
> -
>   void thermal_governor_update_tz(struct thermal_zone_device *tz,
>   				enum thermal_notify_event reason)
>   {
> @@ -418,8 +409,6 @@ static void handle_thermal_trip(struct t
>   
>   	if (trip->type == THERMAL_TRIP_CRITICAL || trip->type == THERMAL_TRIP_HOT)
>   		handle_critical_trips(tz, trip);
> -	else
> -		handle_non_critical_trips(tz, trip);
>   }
>   
>   static void update_temperature(struct thermal_zone_device *tz)
> Index: linux-pm/drivers/thermal/thermal_core.h
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_core.h
> +++ linux-pm/drivers/thermal/thermal_core.h
> @@ -32,8 +32,6 @@ struct thermal_trip_desc {
>    *			thermal zone.
>    * @trip_crossed:	called for trip points that have just been crossed
>    * @manage:	called on thermal zone temperature updates
> - * @throttle:	callback called for every trip point even if temperature is
> - *		below the trip point temperature
>    * @update_tz:	callback called when thermal zone internals have changed, e.g.
>    *		thermal cooling instance was added/removed
>    * @governor_list:	node in thermal_governor_list (in thermal_core.c)
> @@ -46,8 +44,6 @@ struct thermal_governor {
>   			     const struct thermal_trip *trip,
>   			     bool crossed_up);
>   	void (*manage)(struct thermal_zone_device *tz);
> -	int (*throttle)(struct thermal_zone_device *tz,
> -			const struct thermal_trip *trip);
>   	void (*update_tz)(struct thermal_zone_device *tz,
>   			  enum thermal_notify_event reason);
>   	struct list_head	governor_list;
> 
> 
> 


Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>