Received-SPF: pass (google.com: domain of linux-kernel+bounces-151887-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 20 Apr 2024 00:22:41 +0530 (GMT+05:30)
From: Shresth Prasad <shresthprasad7@gmail.com>
To: daniel.thompson@linaro.org
Cc: deller@gmx.de, dri-devel@lists.freedesktop.org,
	javier.carrasco.cruz@gmail.com, jingoohan1@gmail.com,
	julia.lawall@inria.fr, lee@kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, shresthprasad7@gmail.com,
	skhan@linuxfoundation.org
Message-ID: <819a56c3-bbaf-4d5e-87de-78c1312c56d1@gmail.com>
In-Reply-To: <20240419111613.GA12884@aspen.lan>
Subject: Re: [PATCH][next] drivers: video: Simplify device_node cleanup
 using __free
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable


> Please fix the subject line to be "backlight: <driver>: ...". I came
> very close to deleting this patch without reading it ;-) .

Really sorry about that, I'll fix it.

> Do we need to get dev->of_node at all? The device, which we are
> borrowing, already owns a reference to the node so I don't see
> any point in this function taking an extra one.
>
> So why not simply make this:
>
> =C2=A0=C2=A0=C2=A0 struct device_node *np =3D dev->of_node;

Looking at it again, I'm not sure why the call to `of_node_put` is there in=
 the first place. I think removing it will be fine.

I'll fix both of these issues and send a patch v2.

Regards,
Shresth