Received-SPF: pass (google.com: domain of linux-kernel+bounces-151924-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Aapo Vienamo <aapo.vienamo@linux.intel.com>,
        Linus Walleij
	<linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "Andy
 Shevchenko" <andy@kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Mika Westerberg
	<mika.westerberg@linux.intel.com>,
        Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>
Subject: RE: [PATCH] gpio: Add Intel Granite Rapids-D vGPIO driver
Thread-Topic: [PATCH] gpio: Add Intel Granite Rapids-D vGPIO driver
Thread-Index: AQHakjC6i7OisBxFg0KE35p6PF3J07FwAqng
Date: Fri, 19 Apr 2024 19:59:48 +0000
Message-ID: <MW5PR84MB1842F4C102CBFA73E861F420AB0D2@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20240419080555.97343-1-aapo.vienamo@linux.intel.com>
In-Reply-To: <20240419080555.97343-1-aapo.vienamo@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zJbj0jYsDLJ8DcSB6bErvaRoq2NfvQc5Bv9LUfPSL2dZCXBH8raXkGSKn3lE?=
 =?us-ascii?Q?GmnB17hTi1vIFy4MDK1zVHhrXqoqcqNunQ+4olAmQzTatoABmSfZPm9w/twQ?=
 =?us-ascii?Q?0qlqpu3F5VQKBGMqW2kifOs1X6gEZto5xWl1XQH7/MHv8iEHY/E0HNaNXi39?=
 =?us-ascii?Q?x77p/RqwqSHMnfgtEJdM6NOm7vxm0L9GeQQ09DxI8SiWkX08EYpGa6st3BcO?=
 =?us-ascii?Q?9x4M0vu/CuxXMcXhZW6PKKchWt92cLYyIlsSRu6r0E6hJ3bwHjOiU3Sp8lD1?=
 =?us-ascii?Q?VYNVGUuPBj9kPtYSWMV5Si/kVnRu37H9zE5B8gN+1fhRLzx2wytPRKH10/ue?=
 =?us-ascii?Q?ClpUVSREN83O9Q/uVr+Dk8YHfFTeOPcXNRqX1M/5EgrSgE2DRYYcd0ItEG/a?=
 =?us-ascii?Q?sIkNnfgvq96/MeOTmDbHjbPx4ZUhxEUP1n3FntWF6MP1RWeKQnrWkcGWc2z4?=
 =?us-ascii?Q?U3qvomio2ubvlGJ8uY9M5IStiBrsXHMQKdilt7OvpZiYzy+SUNEWuw0YYkq7?=
 =?us-ascii?Q?KDw4F1oCiQ7s/Yr6Mk6X06PzHqvyoZjBBmyDzqqg9DMawNXufOJPrl1wcGAP?=
 =?us-ascii?Q?+oRARgn/jB1QGTz1L6apiY9bU9soNSvZTbmgmLb0OHGGSGnvYMpdj8EitTSs?=
 =?us-ascii?Q?XHnLWotAwDz1hfP9RUJ3Z/IcW2FEehHbtkPMPy3h98lMnxhxNqvLKbLMW7Pa?=
 =?us-ascii?Q?HLZd0VfTE9Eic3e/Ux38scwWmLEFIL26gm25KBlsK8tjPpDMKxTq8ep64EcP?=
 =?us-ascii?Q?TiSd+MoK/UDVHj4YKv0EMqfZBZrVdz1lrbI6CXBwTgrGhw3Oq9xr4WHUeK3G?=
 =?us-ascii?Q?LCnUsO1mPsenunSzrY2d9JA6ajkDQxI8ivGi4LoFlJlixHeILqA5v8Yl9Sun?=
 =?us-ascii?Q?N/EY8CTWq04LqUNXyazSaVTHVCEl/iXcpnFpB7sUQZ09S7x5JpvPek9vQkbo?=
 =?us-ascii?Q?6Z3AMIhw8CATNTFBp54oeq1HTGMe5hHLIo4tj1r4P9TTO7FLbjCEo/SC0MOo?=
 =?us-ascii?Q?NCBgYuzcSGL5wAeTHx7xEzgIAtpMokArDuq8D0ZZFfaRixXouXR9KenVzR4I?=
 =?us-ascii?Q?zvdLzLm/wv9gf8L6dgrmFpUocCHRo/tyagLYXp12rCWsG1BLoCW/ktrXaeY7?=
 =?us-ascii?Q?lgWCLvu12LaWoW1qp/PkUC50KlKdGuLvcejCP0OQHJOs+0uxPpHxlGgkRPrI?=
 =?us-ascii?Q?V9iZO6ajW4UOcyoEYnToBB/nDP223KA7nSxEY8XFYssoQ24WlJKbSAItJ4pd?=
 =?us-ascii?Q?fgl0s38LqHk6txcuuA17hxOpq8W/7MkcfBqtBQO/tn+emoga0z44NGrsdSB6?=
 =?us-ascii?Q?LVwwXrsrA5SfNnpHUFH8gHG24XJP81gNeLr6i+lHKlac5eizCdjWYqD3xkUX?=
 =?us-ascii?Q?CnXKD2ot/ljL9+6vkKsWPhij0ZTrP2x/6oAVWbiCAd6VeC/A5L2aoELrV/22?=
 =?us-ascii?Q?fODw53lXy7CzFSQXlZzKS4RXKGMeYyffSUyJHk71Y+KRkRryVW198O79suCB?=
 =?us-ascii?Q?FNvaANGaPRmaJ27bwG0LkUBF2/B2+/L5AGk1+31a55PN1sucuRcEnAW5z+MV?=
 =?us-ascii?Q?m8LozB4709P7IIC+WeA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 9372aff9-fd77-4a47-c6fd-08dc60ab4494
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2024 19:59:48.5763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hYkShjx3cTckHcRaqjnOoxn/+0I+BzK4p77yZgGS2Ao2URZygiQpjPkPYFOqyWGf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1928
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: V42NOh3V-zIN77QidtbGP-R8GnO7nXlP
X-Proofpoint-ORIG-GUID: V42NOh3V-zIN77QidtbGP-R8GnO7nXlP
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-19_15,2024-04-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0
 mlxscore=0 phishscore=0 mlxlogscore=946 suspectscore=0 bulkscore=0
 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404190154


> -----Original Message-----
> From: Aapo Vienamo <aapo.vienamo@linux.intel.com>
> Sent: Friday, April 19, 2024 3:06 AM
> Subject: [PATCH] gpio: Add Intel Granite Rapids-D vGPIO driver
>=20
..

> +static int gnr_gpio_probe(struct platform_device *pdev)
> +{
> +	size_t num_backup_pins =3D IS_ENABLED(CONFIG_PM_SLEEP) ? GNR_NUM_PINS
> : 0;
> +	struct device *dev =3D &pdev->dev;
> +	struct gpio_irq_chip *girq;
> +	struct gnr_gpio *priv;
> +	void __iomem *regs;
> +	int irq, ret;
> +
> +	priv =3D devm_kzalloc(dev, struct_size(priv, pad_backup,
> num_backup_pins), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
> +
> +	regs =3D devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(regs))
> +		return PTR_ERR(regs);
> +
> +	irq =3D platform_get_irq(pdev, 0);
> +	if (irq < 0)
> +		return irq;
> +
> +	ret =3D devm_request_irq(dev, irq, gnr_gpio_irq, IRQF_SHARED |
> IRQF_NO_THREAD,
> +			       dev_name(dev), priv);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to request interrupt\n");

All of these early returns will leave the memory allocated to priv
forever, since priv isn't saved anywhere until:

> +	platform_set_drvdata(pdev, priv);