Received-SPF: pass (google.com: domain of linux-kernel+bounces-151975-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ba929890d6c6fbdb78f3aa8d9b761184.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240415134532.3467817-1-arnd@kernel.org>
References: <20240415134532.3467817-1-arnd@kernel.org>
Subject: Re: [PATCH] clk: sophgo: avoid open-coded 64-bit division
From: Stephen Boyd <sboyd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To: Arnd Bergmann <arnd@kernel.org>, Chen Wang <unicorn_wang@outlook.com>, Inochi Amaoto <inochiama@outlook.com>, Michael Turquette <mturquette@baylibre.com>
Date: Fri, 19 Apr 2024 14:38:27 -0700
User-Agent: alot/0.10

Quoting Arnd Bergmann (2024-04-15 06:45:20)
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> On 32-bit architectures, the 64-bit division leads to a link failure:
>=20
> arm-linux-gnueabi-ld: drivers/clk/sophgo/clk-cv18xx-pll.o: in function `f=
pll_calc_rate':
> clk-cv18xx-pll.c:(.text.fpll_calc_rate+0x26): undefined reference to `__a=
eabi_uldivmod'
>=20
> This one is not called in a fast path, and there is already another div_u=
64()
> variant used in the same function, so convert it to div64_u64_rem().
>=20
> Fixes: 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied to clk-next