Received-SPF: pass (google.com: domain of linux-kernel+bounces-151990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 19 Apr 2024 15:06:11 -0700
From: Joe Perches <joe@perches.com>
To: Nam Cao <namcao@linutronix.de>
Cc: apw@canonical.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: add "Reported-and-tested-by:" tag
In-Reply-To: <20240419191957.42396-1-namcao@linutronix.de>
References: <20240419191957.42396-1-namcao@linutronix.de>
Message-ID: <a8094ffbabd308752cb02cd1c1d5b67c@perches.com>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

On 2024-04-19 12:19, Nam Cao wrote:
> The tag "Reported-and-tested-by:" is used all the time. Add this tag.
> 
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9c4c4a61bc83..ff44720fcf23 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -618,6 +618,7 @@ our $signature_tags = qr{(?xi:
>  	Tested-by:|
>  	Reviewed-by:|
>  	Reported-by:|
> +	Reported-and-tested-by:|
>  	Suggested-by:|
>  	To:|
>  	Cc:
> @@ -712,7 +713,7 @@ sub find_standard_signature {
>  	my ($sign_off) = @_;
>  	my @standard_signature_tags = (
>  		'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
> -		'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
> +		'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 
> 'Reported-and-tested-by'

Missing a colon
>  	);
>  	foreach my $signature (@standard_signature_tags) {
>  		return $signature if (get_edit_distance($sign_off, $signature) <= 
> 2);